Bug 271781 - www/nginx http_upload_module issue with pcre2
Summary: www/nginx http_upload_module issue with pcre2
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-02 06:15 UTC by Artyom Davidov
Modified: 2025-11-16 01:25 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments
Patch to incorporate work-around for the pcre2 issue (4.60 KB, patch)
2023-06-02 06:19 UTC, Artyom Davidov
no flags Details | Diff
nginx extra-patch-ngx_http_upload_module.c and friends (4.65 KB, patch)
2025-03-06 23:44 UTC, Mark Linimon
no flags Details | Diff
New patch based on github pull request 152 (1.61 KB, patch)
2025-03-11 00:30 UTC, Artyom Davidov
no flags Details | Diff
New patch based on github pull request 152 (1.66 KB, patch)
2025-11-16 01:25 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Artyom Davidov 2023-06-02 06:15:07 UTC
There is a known incompatibility issue in http_upload_module and nginx pcre2 engine that was reported to upstream almost a year ago at https://github.com/fdintino/nginx-upload-module/issues/140
Since that there were no upstream fixes for this issue but there is a pending pull-request at https://github.com/fdintino/nginx-upload-module/pull/142 that adds a new configuration file option that helps to work-around it.
Due to the recent removal of the port option that allows to build nginx with the previous pcre engine it will be great if we could add the fix from that pull-request to the port to make nginx http_upload_module usable again.
Comment 1 Artyom Davidov 2023-06-02 06:19:12 UTC
Created attachment 242552 [details]
Patch to incorporate work-around for the pcre2 issue

Proposed patch that incorporates work-around from https://github.com/fdintino/nginx-upload-module/pull/142
Comment 2 Artyom Davidov 2024-05-14 01:27:59 UTC
Ping! 
Any update on this issue?
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2025-03-06 23:44:37 UTC
Created attachment 258377 [details]
nginx extra-patch-ngx_http_upload_module.c and friends

^Triage: rebase patch.
Comment 4 Artyom Davidov 2025-03-07 01:06:34 UTC
(In reply to Mark Linimon from comment #3)
Hi Mark!
It seems that there is a newer patch available that doesn't introduce new configuration variables but just fixes the standard upload_pass_form_field functionality at https://github.com/fdintino/nginx-upload-module/pull/152
Maybe we should pick that one instead?

But I haven't tested that patch by myself though.
Comment 5 Artyom Davidov 2025-03-11 00:30:36 UTC
Created attachment 258547 [details]
New patch based on github pull request 152

This is a new simpler and smaller patch for the issue.
It is based on https://github.com/fdintino/nginx-upload-module/pull/152

It doesn't introduce any new options but instead just brings back the previous upload_pass_form_field option behavior.
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2025-11-16 01:25:35 UTC
Created attachment 265443 [details]
New patch based on github pull request 152

^Triage: rebase patch.