Bug 271842 - net-mgmt/netdisco: Depends on Plack Middleware Headers, not in ports
Summary: net-mgmt/netdisco: Depends on Plack Middleware Headers, not in ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-05 14:04 UTC by Einar Bjarni Halldórsson
Modified: 2023-06-21 15:19 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (dgeo)


Attachments
Add new port p5-Plack-Middleware-Headers and add as dependency for netdisco (3.59 KB, patch)
2023-06-05 15:00 UTC, Einar Bjarni Halldórsson
einar: maintainer-approval? (dgeo)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Einar Bjarni Halldórsson 2023-06-05 14:04:19 UTC
After upgrading netdisco to netdisco-2.061001 I get this error when starting netdisco:

Error while loading /usr/local/bin/netdisco-web-fg: Can't locate Plack/Middleware/Headers.pm

Plack/Middleware/Headers is a fork of Header, which is in ports (p5-Plack-Middleware-Header).
Comment 1 Einar Bjarni Halldórsson 2023-06-05 15:00:17 UTC
Created attachment 242618 [details]
Add new port p5-Plack-Middleware-Headers and add as dependency for netdisco

Latest version of netdisco in ports depends on Plack/Middleware/Headers.pm which is not in ports.

This patch adds it as a port (p5-Plack-Middleware-Headers) and adds it as a run-time dependency of netdisco
Comment 2 Einar Bjarni Halldórsson 2023-06-05 16:06:08 UTC
(In reply to Einar Bjarni Halldórsson from comment #1)

Forgot to add PORTREVISION for netdisco...
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-06-05 16:21:05 UTC
How is p5-Plack-Middleware-Header different from p5-Plack-Middleware-Headers?
Comment 4 Einar Bjarni Halldórsson 2023-06-05 17:44:28 UTC
(In reply to Fernando Apesteguía from comment #3)

Headers is apparantly a fork and an extension of Header.
I have no experience of either, I simply noticed it's needed by netdisco after the last upgrade.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2023-06-06 07:06:37 UTC
Maybe perl@ can shed some light here?

I'm a bit reluctant to add a new port which name is almost the same as another one already present in the ports collection.
Comment 6 Einar Bjarni Halldórsson 2023-06-06 08:24:00 UTC
(In reply to Fernando Apesteguía from comment #5)

I understand your concern.

The different libraries are:

https://metacpan.org/pod/Plack::Middleware::Header
https://metacpan.org/pod/Plack::Middleware::Headers

From Headers page:
"This module is an extened fork of Plack::Middleware::Header, originally created by Masahiro Chiba. Additional contributions by Wallace Reis."
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-06-21 15:17:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a0d95819bb37f40fde9e9b89301ea9679ce19004

commit a0d95819bb37f40fde9e9b89301ea9679ce19004
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2023-06-21 15:07:41 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-06-21 15:07:41 +0000

    www/p5-Plack-Middleware-Headers: new port

    Fork of p5-Plack-Middleware-Header needed to fix the run time of
    net-mgmt/netdisco.

    PR:             271842
    Reported by:    einar@isnic.is

 www/Makefile                                    |  1 +
 www/p5-Plack-Middleware-Headers/Makefile (new)  | 21 +++++++++++++++++++++
 www/p5-Plack-Middleware-Headers/distinfo (new)  |  3 +++
 www/p5-Plack-Middleware-Headers/pkg-descr (new) |  5 +++++
 www/p5-Plack-Middleware-Headers/pkg-plist (new) |  2 ++
 5 files changed, 32 insertions(+)
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2023-06-21 15:19:10 UTC
Committed,

Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-06-21 15:19:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a7157ce581a935b27cccbf16a60e49cc70a11a68

commit a7157ce581a935b27cccbf16a60e49cc70a11a68
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2023-06-21 15:12:07 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-06-21 15:12:07 +0000

    net-mgmt/net-disco: Fix runtime

    Add missing runtime dependency.

    PR:             271842
    Reported by:    einar@isnic.is
    Fixes:          d7272b56ac851a1e032199f3043fc7c9e2c4f1a3

 net-mgmt/netdisco/Makefile | 1 +
 1 file changed, 1 insertion(+)