Created attachment 243098 [details] graphics/exiv2: upgrade to v0.28 note this is incomplete, all ports using exiv2 need to be tested and the PORTREVISION bumped, all this is still pending. Will add more patches.
Created attachment 243100 [details] converters/pdf2djvu: update to 0.9.19 this should be committed along the exiv2 0.28 update. @Samy, would you want to default-enable the XMP option now?
Created attachment 243103 [details] graphics/exiv2: upgrade to v0.28 (take #2) revised after diizzy@'s review on https://reviews.freebsd.org/D40828
Created attachment 243104 [details] graphics/exiv2: upgrade to v0.28 (take #3) minor revision after IRC discussion with diizzy@ about Python deps for test
Created attachment 243106 [details] graphics/exiv2 0.28 update (take #4) reformat to please portfmt/portclippy/portlint
Created attachment 243111 [details] graphics/gexiv2: patch to make compatible with exiv2 0.28
Created attachment 243124 [details] -textproc-libextractor-mark-broken-and-deprecated.patch
Created attachment 243125 [details] patch to fix exiv2 part in bulk_extractor, and update while here, and enable "make test"
Created attachment 243135 [details] converters/pdf2djvu: update to 0.9.19 and make exiv2 0.28 compatible
Created attachment 243136 [details] graphics/darktable: make compatible with exiv2 0.28
Created attachment 243137 [details] graphics/filmulator: make compatible with exiv2 0.28
Created attachment 243138 [details] graphics/geeqie: make compatible with exiv2 0.28
Created attachment 243139 [details] graphics/gimp-lensfun-plugin: make compatible with exiv2 0.28
Created attachment 243140 [details] astro/gpscorrelate: make compatible with exiv2 0.28
Created attachment 243141 [details] graphics/hugin: make compatible with exiv2 0.28
Created attachment 243142 [details] sysutils/krename: make compatible with exiv2 0.28
Created attachment 243143 [details] graphics/nomacs: make compatible with exiv2 0.28
Created attachment 243144 [details] astro/merkaartor: make compatible with exiv2 0.28
Created attachment 243145 [details] graphics/krita: make compatible with exiv2 0.28
Created attachment 243146 [details] graphics/oyranos: make compatible with exiv2 0.28 (unmaintained port, no approval required)
Created attachment 243147 [details] graphics/photivo: make compatible with exiv2 0.28
I seem to have fixes graphics/lux but get strange compiler errors. fuz@, can you lend a hand? [00:02:09] [ 85% 27/28] /usr/local/libexec/ccache/c++ -I/wrkdirs/usr/ports/graphics/lux/work/kfj-pv-f49809a01243 -I/usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -DNDEBUG -std=gnu++11 -O3 -D START_IN_FULLSCREEN_MODE=true -DSTART_WITH_AUTO_QUALITY=false -fno-math-errno -Wno-unused-value -D VECTORIZE -D USE_HWY -D PV_ARCH=PV_PLAIN -D PV_ARCHNAME=\"plain\" -D PV_PRIORITY=5 -D PV_VIABILITY=is_viable -D FLV_PLAIN -MD -MT CMakeFiles/lux.dir/pv_rendering_plain.cc.o -MF CMakeFiles/lux.dir/pv_rendering_plain.cc.o.d -o CMakeFiles/lux.dir/pv_rendering_plain.cc.o -c /wrkdirs/usr/ports/graphics/lux/work/.build/pv_rendering_plain.cc [00:02:09] FAILED: CMakeFiles/lux.dir/pv_rendering_plain.cc.o [00:02:09] /usr/local/libexec/ccache/c++ -I/wrkdirs/usr/ports/graphics/lux/work/kfj-pv-f49809a01243 -I/usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -DNDEBUG -std=gnu++11 -O3 -D START_IN_FULLSCREEN_MODE=true -DSTART_WITH_AUTO_QUALITY=false -fno-math-errno -Wno-unused-value -D VECTORIZE -D USE_HWY -D PV_ARCH=PV_PLAIN -D PV_ARCHNAME=\"plain\" -D PV_PRIORITY=5 -D PV_VIABILITY=is_viable -D FLV_PLAIN -MD -MT CMakeFiles/lux.dir/pv_rendering_plain.cc.o -MF CMakeFiles/lux.dir/pv_rendering_plain.cc.o.d -o CMakeFiles/lux.dir/pv_rendering_plain.cc.o -c /wrkdirs/usr/ports/graphics/lux/work/.build/pv_rendering_plain.cc [00:02:44] [ 89% 27/28] /usr/local/libexec/ccache/c++ -I/wrkdirs/usr/ports/graphics/lux/work/kfj-pv-f49809a01243 -I/usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -DNDEBUG -std=gnu++11 -O3 -D START_IN_FULLSCREEN_MODE=true -DSTART_WITH_AUTO_QUALITY=false -fno-math-errno -Wno-unused-value -D VECTORIZE -D USE_HWY -mavx2 -march=haswell -mpclmul -maes -D hn=hn_avx2 -D PV_ARCH=PV_AVX2 -D PV_ARCHNAME=\"avx2\" -D PV_PRIORITY=1 -D PV_VIABILITY=has_avx2 -D FLV_AVX2 -MD -MT CMakeFiles/lux.dir/pv_rendering_avx2.cc.o -MF CMakeFiles/lux.dir/pv_rendering_avx2.cc.o.d -o CMakeFiles/lux.dir/pv_rendering_avx2.cc.o -c /wrkdirs/usr/ports/graphics/lux/work/.build/pv_rendering_avx2.cc [00:02:44] FAILED: CMakeFiles/lux.dir/pv_rendering_avx2.cc.o [00:02:44] /usr/local/libexec/ccache/c++ -I/wrkdirs/usr/ports/graphics/lux/work/kfj-pv-f49809a01243 -I/usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -DNDEBUG -std=gnu++11 -O3 -D START_IN_FULLSCREEN_MODE=true -DSTART_WITH_AUTO_QUALITY=false -fno-math-errno -Wno-unused-value -D VECTORIZE -D USE_HWY -mavx2 -march=haswell -mpclmul -maes -D hn=hn_avx2 -D PV_ARCH=PV_AVX2 -D PV_ARCHNAME=\"avx2\" -D PV_PRIORITY=1 -D PV_VIABILITY=has_avx2 -D FLV_AVX2 -MD -MT CMakeFiles/lux.dir/pv_rendering_avx2.cc.o -MF CMakeFiles/lux.dir/pv_rendering_avx2.cc.o.d -o CMakeFiles/lux.dir/pv_rendering_avx2.cc.o -c /wrkdirs/usr/ports/graphics/lux/work/.build/pv_rendering_avx2.cc [00:02:44] [ 92% 27/28] /usr/local/libexec/ccache/c++ -I/wrkdirs/usr/ports/graphics/lux/work/kfj-pv-f49809a01243 -I/usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -DNDEBUG -std=gnu++11 -O3 -D START_IN_FULLSCREEN_MODE=true -DSTART_WITH_AUTO_QUALITY=false -fno-math-errno -Wno-unused-value -D VECTORIZE -D USE_HWY -msse4.2 -march=westmere -mpclmul -maes -D hn=hn_sse42 -D PV_ARCH=PV_SSE42 -D PV_ARCHNAME=\"sse4.2\" -D PV_PRIORITY=3 -D PV_VIABILITY=has_sse42 -D FLV_SSE42 -MD -MT CMakeFiles/lux.dir/pv_rendering_sse42.cc.o -MF CMakeFiles/lux.dir/pv_rendering_sse42.cc.o.d -o CMakeFiles/lux.dir/pv_rendering_sse42.cc.o -c /wrkdirs/usr/ports/graphics/lux/work/.build/pv_rendering_sse42.cc [00:02:44] FAILED: CMakeFiles/lux.dir/pv_rendering_sse42.cc.o [00:02:44] /usr/local/libexec/ccache/c++ -I/wrkdirs/usr/ports/graphics/lux/work/kfj-pv-f49809a01243 -I/usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wno-deprecated-declarations -DNDEBUG -std=gnu++11 -O3 -D START_IN_FULLSCREEN_MODE=true -DSTART_WITH_AUTO_QUALITY=false -fno-math-errno -Wno-unused-value -D VECTORIZE -D USE_HWY -msse4.2 -march=westmere -mpclmul -maes -D hn=hn_sse42 -D PV_ARCH=PV_SSE42 -D PV_ARCHNAME=\"sse4.2\" -D PV_PRIORITY=3 -D PV_VIABILITY=has_sse42 -D FLV_SSE42 -MD -MT CMakeFiles/lux.dir/pv_rendering_sse42.cc.o -MF CMakeFiles/lux.dir/pv_rendering_sse42.cc.o.d -o CMakeFiles/lux.dir/pv_rendering_sse42.cc.o -c /wrkdirs/usr/ports/graphics/lux/work/.build/pv_rendering_sse42.cc
Created attachment 243148 [details] UNTESTED!! graphics/lux: make compatible with exiv2 0.28
still to check: photoqt-1.6_10.log pinot-1.21_8.log qt5-webengine-5.15.8_3.log rawstudio-2.0_24.log siril-1.0.6_6.log ufraw-0.22.20210424_8.log viewnior-1.8_2.log webkit2-gtk4-2.38.3_2.log the webkit2/webengine may be unrelated, will check later
Comment on attachment 243142 [details] sysutils/krename: make compatible with exiv2 0.28 Ship it! Dima, on behalf of @kde
Comment on attachment 243145 [details] graphics/krita: make compatible with exiv2 0.28 Ship it! Dima, on behalf of @kde
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8f2c42142d37933e4e12eafa520386b740c2a7ba commit 8f2c42142d37933e4e12eafa520386b740c2a7ba Author: Christoph Moench-Tegeder <cmt@FreeBSD.org> AuthorDate: 2023-07-02 19:48:34 +0000 Commit: Christoph Moench-Tegeder <cmt@FreeBSD.org> CommitDate: 2023-07-02 19:48:34 +0000 graphics/gexiv2: prepare for exiv2 0.28 PR: 272311 Reported by: mandree@ graphics/gexiv2/Makefile | 5 +- graphics/gexiv2/files/patch-06adc8fb70cb (new) | 1296 ++++++++++++++++++++++++ 2 files changed, 1298 insertions(+), 3 deletions(-)
gexiv2 done (8f2c42142d37) without the hassle of gitlab
Created attachment 243154 [details] graphics/photoqt: make compatible with exiv2 0.28
Created attachment 243155 [details] graphics/rawstudio: make compatible with exiv2 0.28
Created attachment 243156 [details] deskutils/pinot: make compatible with exiv2 0.28
Created attachment 243157 [details] astro/siril: make compatible with exiv2 0.28
Created attachment 243158 [details] graphics/viewnior: make compatible with exiv2 0.28
Created attachment 243159 [details] graphics/ufraw: make compatible with exiv2 0.28
Created attachment 243160 [details] make graphics/lux compat w/ exiv2 0.28, take #2 - turn REINPLACE_CMD into patch file. test compile dispatched
Comment on attachment 243160 [details] make graphics/lux compat w/ exiv2 0.28, take #2 - turn REINPLACE_CMD into patch file. LGTM if a build test passes. Build test already passes on arm64. Amd64 has a bunch of SIMD variants of the code exclusive to this architecture, so there may be chances for errors not seen on other platforms. Prior build failure could be due to an OOM condition; this port needs a lot of RAM to compile (>2GB per make job).
Comment on attachment 243147 [details] graphics/photivo: make compatible with exiv2 0.28 Not sure why bump port revision, but the code looks fine.
Comment on attachment 243137 [details] graphics/filmulator: make compatible with exiv2 0.28 Ditto.
Comment on attachment 243143 [details] graphics/nomacs: make compatible with exiv2 0.28 LGTM
(In reply to Alexey Dokuchaev from comment #37) because the exiv2 .so major version changed, and we therefore need to bump revision of all consumers to trigger rebuilds in the pkg building cluster and also make people aware.
Comment on attachment 243158 [details] graphics/viewnior: make compatible with exiv2 0.28 Nice, it also fixes clang 16 build on current! Thanks
Created attachment 243166 [details] multimedia/mythtv: revise pkg-plist after exiv2 0.28 upgrade
Created attachment 243167 [details] graphics/luminance-qt5: make compatible with exiv2 0.28
Created attachment 243168 [details] graphics/qgis-ltr: make compatible with exiv2 0.28
Created attachment 243169 [details] graphics/qgis: make compatible with exiv2 0.28
Created attachment 243170 [details] graphics/gthumb: make compatible with exiv2 0.28
Created attachment 243171 [details] graphics/kphotoalbum: make compatible with exiv2 0.28
Created attachment 243172 [details] graphics/exiv2: upgrade to 0.28, take #5, fix _MSVC_LANG -Wundef warnings, accepted upstream
Comment on attachment 243170 [details] graphics/gthumb: make compatible with exiv2 0.28 graphics/gthumb: BZ flags maintainer gnome@ the same as nobody, set to approved
Comment on attachment 243136 [details] graphics/darktable: make compatible with exiv2 0.28 Thank you!
Created attachment 243175 [details] graphics/digikam: make compatible with exiv2 0.28
Based on just 132amd64 test builds, this would seem ready to land now, all exiv2 consumers that I found with grepping through /usr/ports for exiv2 now compile with the patches (where exiv2 was optional, I believe I used poudriere options -cn cat/port to enable XMP or exiv2 or thereabouts). Exception is textproc/libextractor, which has no dependent ports, and will be marked deprecated/broken. I would launch test builds for 12.4-amd64 now and let this rest another day or two so maintainers can look at the patches for their ports.
Comment on attachment 243171 [details] graphics/kphotoalbum: make compatible with exiv2 0.28 Ship it! Dima, on behalf of kde@
Created attachment 243176 [details] graphics/filmulator - make compatible with exiv2 0.28 #2 - unified prior patches Hi Alexey, I messed up the earlier graphics/filmulator patch. Sorry. This is the one I intend to commit, git squashed from two earlier ones. Let you review everything, and linearize history while keeping one concern in one commit.
Comment on attachment 243175 [details] graphics/digikam: make compatible with exiv2 0.28 Ship it! Dima, on belalf of kde@
(In reply to Matthias Andree from comment #40) > because the exiv2 .so major version changed, and we therefore need to > bump revision Ah, silly me, I neglected to look at the exiv2 changes themselves and naively assumed they've kept the ABI intact, sorry about that.
Comment on attachment 243176 [details] graphics/filmulator - make compatible with exiv2 0.28 #2 - unified prior patches > (int) exifData["Exif.Image.Orientation"].value().toInt64(); Does the new version provide more generic bitwidth-neutral method like .toInt() so we can get rid of the C-style (int) cast? Ditto for below. Just an observation, I trust your judgment.
(In reply to Alexey Dokuchaev from comment #57) No they don't. This is the relevant header diff between 0.27 and 0.28, and they also assume C++17... - std::string toString() const; - std::string toString(long n) const; - long toLong(long n =0) const; - float toFloat(long n =0) const; - Rational toRational(long n =0) const; - Value::AutoPtr getValue() const; - const Value& value() const; + [[nodiscard]] std::string toString() const override; + [[nodiscard]] std::string toString(size_t n) const override; + [[nodiscard]] int64_t toInt64(size_t n = 0) const override; + [[nodiscard]] float toFloat(size_t n = 0) const override; + [[nodiscard]] Rational toRational(size_t n = 0) const override; + [[nodiscard]] Value::UniquePtr getValue() const override; + [[nodiscard]] const Value& value() const override;
Comment on attachment 243170 [details] graphics/gthumb: make compatible with exiv2 0.28 Patch is good, but please use PATCH_SITES and PATCHFILES instead unless it doesn't apply. With hat: gnome
(In reply to Charlie Li from comment #59) @vishwin, that is exactly one issue. Gitlab leaves garbage at the end of the patch and I do not want to play review-and-update-distinfo games if they update their Gitlab and the layout of the patches changes. An added blank or CR is sufficient to break the checksum. This has happened before, and diizzy@ warned me not to use gitlab sites for PATCH_SITES and PATCHFILES. I'll go with his recommendation instead.
(In reply to Matthias Andree from comment #60) GitHub does it too if you want to be pedantic. "Review-and-update-distinfo games" is a minor issue that gnome@ is willing to eat, not least to keep files/ to a minimum or empty, especially if the patch involved is an upstream commit.
Comment on attachment 243169 [details] graphics/qgis: make compatible with exiv2 0.28 I am fine with it, thanks.
Comment on attachment 243168 [details] graphics/qgis-ltr: make compatible with exiv2 0.28 I am fine with it, thanks.
Comment on attachment 243144 [details] astro/merkaartor: make compatible with exiv2 0.28 Build against exiv2 0.27 fails as expected Build against exiv2 0.28 from this PR succeeds: https://heesakkers.info/showandtell/merkaartor-0.19.0_14.log No run-tests performed, I believe this is an obscure function in Merkaartor, I don't expect any issues with it, approved.
(In reply to Matthias Andree from comment #48) Thank you for updating sysutils/bulk_extractor port. I tested build of graphics/exiv2 port with this patch (take #5), but it failed with size mismatch in fetch stage. ----------------------------------------------------------------------- $ make /!\ exiv2-0.28.0,1: Makefile warnings, please consider fixing /!\ Not validating first entry in CATEGORIES due to being outside of PORTSDIR. Please ensure this is proper when committing. ===> License GPLv2+ accepted by the user ===> exiv2-0.28.0,1 depends on file: /usr/local/sbin/pkg - found => exiv2-0.28.0-Source.tar.gz doesn't seem to exist in /usr/ports/distfiles/. => Attempting to fetch https://github.com/Exiv2/exiv2/releases/download/v0.28.0/exiv2-0.28.0-Source.tar.gz exiv2-0.28.0-Source.tar.gz 42 MB 7653 kBps 06s => 16c1cd7da0cd159ee2d53c39088564edaf046c77.patch doesn't seem to exist in /usr/ports/distfiles/. => Attempting to fetch https://github.com/Exiv2/exiv2/commit/16c1cd7da0cd159ee2d53c39088564edaf046c77.patch fetch: https://github.com/Exiv2/exiv2/commit/16c1cd7da0cd159ee2d53c39088564edaf046c77.patch: size mismatch: expected 4997, actual 4995 => Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/16c1cd7da0cd159ee2d53c39088564edaf046c77.patch fetch: http://distcache.FreeBSD.org/ports-distfiles/16c1cd7da0cd159ee2d53c39088564edaf046c77.patch: Not Found => Couldn't fetch it - please try to retrieve this => port manually into /usr/ports/distfiles/ and try again. *** Error code 1 Stop. make: stopped in /usr/home/nobutaka/devel/bulk_extractor/ports/graphics/exiv2 $
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7314f3d14ab7912d70800cae62bf5ffc778376f3 commit 7314f3d14ab7912d70800cae62bf5ffc778376f3 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-03 00:04:45 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:09:12 +0000 graphics/digikam: make compatible with exiv2 0.28 NOTE: Upstream has just tagged digikam 8.1.0 which should also work with exiv2 0.28, see here: https://invent.kde.org/graphics/digikam/-/blob/v8.1.0/NEWS But the web site does not yet mention 8.1.0 and the release tarball is not available, so upgrading might be premature. PR: 272311 graphics/digikam/Makefile | 2 +- ...ataengine_engine_metaengine__comments.cpp (new) | 11 +++ ...dataengine_engine_metaengine__data__p.cpp (new) | 11 +++ ...etadataengine_engine_metaengine__exif.cpp (new) | 98 ++++++++++++++++++++++ ...etadataengine_engine_metaengine__iptc.cpp (new) | 29 +++++++ ...etadataengine_engine_metaengine__item.cpp (new) | 65 ++++++++++++++ ...s_metadataengine_engine_metaengine__p.cpp (new) | 11 +++ ...ibs_metadataengine_engine_metaengine__p.h (new) | 22 +++++ ...metadataengine_engine_metaengine__xmp.cpp (new) | 20 +++++ 9 files changed, 268 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=eadb1e6037c802f9224cc541e4a2d74a0aabf064 commit eadb1e6037c802f9224cc541e4a2d74a0aabf064 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-03 00:02:57 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:09:05 +0000 graphics/qgis: make compatible with exiv2 0.28 PR: 272311 graphics/qgis/Makefile | 1 + .../patch-src_core_raster_qgsexiftools.cpp (new) | 38 ++++++++++++++++++++++ graphics/qgis/pkg-plist | 1 + 3 files changed, 40 insertions(+)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fdb2482b6e7785727848c99d54cb2bc22ec8cb7f commit fdb2482b6e7785727848c99d54cb2bc22ec8cb7f Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-01 15:27:44 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:09:12 +0000 *: Bump PORTREVISION of all graphics/exiv2 users because its library version changed to 28 so we need to rebuild/relink. PR: 272311 Differential Revision: https://reviews.freebsd.org/D40828 deskutils/gnome-photos/Makefile | 2 +- devel/kf5-kfilemetadata/Makefile | 2 +- devel/kio-extras/Makefile | 1 + graphics/art/Makefile | 1 + graphics/gwenview/Makefile | 1 + graphics/libkexiv2/Makefile | 1 + graphics/phototonic/Makefile | 1 + graphics/shotwell/Makefile | 1 + net/gerbera/Makefile | 2 +- textproc/libextractor/Makefile | 2 +- 10 files changed, 10 insertions(+), 4 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8870a6436d134814a551bb5d30c37a05968d428b commit 8870a6436d134814a551bb5d30c37a05968d428b Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 23:53:46 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:43 +0000 graphics/qgis-ltr: make compatible with exiv2 0.28 PR: 272311 graphics/qgis-ltr/Makefile | 1 + .../patch-src_core_raster_qgsexiftools.cpp (new) | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0e4d3e69d22d89c1e0972f90bab859473c3935ca commit 0e4d3e69d22d89c1e0972f90bab859473c3935ca Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 22:08:28 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:12 +0000 graphics/ufraw: make compatible with exiv2 0.28 PR: 272311 graphics/ufraw/Makefile | 6 +- graphics/ufraw/files/patch-ufraw__exiv2.cc (new) | 74 ++++++++++++++++++++++++ 2 files changed, 78 insertions(+), 2 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5e7242d99af0988c1a6d12cac50f75e0ba9d63dc commit 5e7242d99af0988c1a6d12cac50f75e0ba9d63dc Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 21:47:18 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:11 +0000 deskutils/pinot: make compatible with exiv2 0.28 PR: 272311 deskutils/pinot/Makefile | 2 +- .../patch-Tokenize_filters_Exiv2ImageFilter.cc (new) | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=164a774986db9c3161e903ddd059f6e54c7b5981 commit 164a774986db9c3161e903ddd059f6e54c7b5981 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 21:45:05 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:11 +0000 graphics/rawstudio: make compatible with exiv2 0.28 PR: 272311 graphics/rawstudio/Makefile | 2 +- .../rawstudio/files/patch-librawstudio_rs-exif.cc | 65 +++++++++++++++++++ .../patch-plugins_load-gdk_exiv2-colorspace.cpp | 39 ++++++++++++ .../patch-plugins_meta-exiv2_exiv2-metadata.cpp | 72 ++++++++++++++++++++++ 4 files changed, 177 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cac713a28e172a4bee0dd29f6130a6f229d38e45 commit cac713a28e172a4bee0dd29f6130a6f229d38e45 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 23:18:46 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:12 +0000 multimedia/mythtv: revise pkg-plist after exiv2 0.28 upgrade mythtv used to expect exiv2 0.27.99 or newer, and would replace and install a local copy of exiv2 if missing. With exiv2 0.28 in the ports tree, mythtv will pick it up from the system, and we need to purge the relevant files from pkg-plist. PR: 272311 multimedia/mythtv/Makefile | 2 +- multimedia/mythtv/pkg-plist | 45 --------------------------------------------- 2 files changed, 1 insertion(+), 46 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8b78f1c8e484fb13f9fbab472c052558f63c68a2 commit 8b78f1c8e484fb13f9fbab472c052558f63c68a2 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 23:23:59 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:13 +0000 graphics/luminance-qt5: make compatible with exiv2 0.28 PR: 272311 graphics/luminance-qt5/Makefile | 2 +- .../files/patch-src_Exif_ExifOperations.cpp (new) | 88 ++++++++++++++++++++++ .../files/patch-src_Libpfs_exif_exifdata.cpp (new) | 29 +++++++ ...c_TransplantExif_TransplantExifDialog.cpp (new) | 11 +++ 4 files changed, 129 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=75ccfcf996ef3dc7f908a9e6ee97f2f18d47ab28 commit 75ccfcf996ef3dc7f908a9e6ee97f2f18d47ab28 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 22:01:06 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:11 +0000 graphics/viewnior: make compatible with exiv2 0.28 PR: 272311 graphics/viewnior/Makefile | 2 +- .../viewnior/files/patch-src_uni-exiv2.cpp (new) | 63 ++++++++++++++++++++++ 2 files changed, 64 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=919c0e9e652965d81fa317d57ca91ffdb51bbb9e commit 919c0e9e652965d81fa317d57ca91ffdb51bbb9e Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 21:41:53 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:10 +0000 graphics/photoqt: make compatible with exiv2 0.28 PR: 272311 graphics/photoqt/Makefile | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a050789426c42aadc060c10ea6ba98ee2b837e3a commit a050789426c42aadc060c10ea6ba98ee2b837e3a Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 21:56:03 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:11 +0000 astro/siril: make compatible with exiv2 0.28 PR: 272311 astro/siril/Makefile | 2 +- astro/siril/files/patch-src_core_exif.cpp (new) | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=77c434f5032412b13bc6b86ce70e8e62f12f74b1 commit 77c434f5032412b13bc6b86ce70e8e62f12f74b1 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-03 00:03:41 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:09:11 +0000 graphics/gthumb: make compatible with exiv2 0.28 Obtained from: https://gitlab.gnome.org/GNOME/gthumb/-/commit/3376550ae109286de09ce5f89e05060eb80230a7 PR: 272311 graphics/gthumb/Makefile | 2 +- ...-3376550ae109286de09ce5f89e05060eb80230a7 (new) | 375 +++++++++++++++++++++ 2 files changed, 376 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c07ec62a7d3830b4fd3b07eb4e95823d2c3029f8 commit c07ec62a7d3830b4fd3b07eb4e95823d2c3029f8 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 10:31:01 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:07 +0000 textproc/libextractor: mark broken and deprecated as a consequence of PR: 272311 textproc/libextractor/Makefile | 4 ++++ 1 file changed, 4 insertions(+)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b9dc9f829d86b0fa40532de868554dc69b3c9a16 commit b9dc9f829d86b0fa40532de868554dc69b3c9a16 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 14:45:40 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:10 +0000 graphics/oyranos: make compatible with exiv2 0.28 PR: 272311 graphics/oyranos/Makefile | 2 +- ...es_color_modules_devices_oyranos__cmm__oyRE.cpp | 77 +++++++++++++++++++++- 2 files changed, 77 insertions(+), 2 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7557de031dbd5b6b7abb5e14fbf1c28216d9b524 commit 7557de031dbd5b6b7abb5e14fbf1c28216d9b524 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 13:26:50 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:09 +0000 sysutils/krename: make compatible with exiv2 0.28 PR: 272311 sysutils/krename/Makefile | 2 +- sysutils/krename/files/patch-src_exiv2plugin.cpp (new) | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8c672e3456117f47aaaf3584405b674f8c34540d commit 8c672e3456117f47aaaf3584405b674f8c34540d Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 10:56:10 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:07 +0000 sysutils/bulk_extractor: fix for exiv2 0.28, update → 2.0.3 Caused by: PR: 272311 sysutils/bulk_extractor/Makefile | 5 +- sysutils/bulk_extractor/distinfo | 6 +- ..._be20__api_dfxml__cpp_src_dfxml__writer.h (new) | 13 +++ .../files/patch-src_scan__exiv2.cpp (new) | 125 +++++++++++++++++++++ 4 files changed, 144 insertions(+), 5 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c18dfc530ea227bb514506dfc7295b91e0b4adcf commit c18dfc530ea227bb514506dfc7295b91e0b4adcf Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 14:19:04 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:09 +0000 graphics/nomacs: make compatible with exiv2 0.28 PR: 272311 graphics/nomacs/Makefile | 2 +- ...tch-ImageLounge_src_DkCore_DkMetaData.cpp (new) | 187 +++++++++++++++++++++ ...patch-ImageLounge_src_DkCore_DkMetaData.h (new) | 20 +++ 3 files changed, 208 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7684f850fde165b5cc6e9df067d2fc0e1a3a03ff commit 7684f850fde165b5cc6e9df067d2fc0e1a3a03ff Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 12:32:40 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:07 +0000 graphics/geeqie: make compatible with exiv2 0.28 Mostly https://github.com/BestImageViewer/geeqie/commit/86d5f780bae35d0fc2122646ff415633b5f15a60 without the #if mess. Note there is a remaining NEF crasher reported against newer 2.1, supposedly fixed by https://github.com/BestImageViewer/geeqie/commit/c45cca777aa3477eaf297db99f337e18d9683c61 which is not part of this commit. PR: 272311 graphics/geeqie/Makefile | 3 +- graphics/geeqie/files/patch-src_exiv2.cc (new) | 95 ++++++++++++++++++++++++++ 2 files changed, 97 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b6555cf39dd1d05fe12e581950b36d9d6038722f commit b6555cf39dd1d05fe12e581950b36d9d6038722f Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 14:00:58 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:09 +0000 astro/merkaartor: make compatible with exiv2 0.28 PR: 272311 astro/merkaartor/Makefile | 2 +- .../files/patch-src_Docks_GeoImageDock.cpp (new) | 38 ++++++++++++++++++++++ 2 files changed, 39 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f13af80790bd8020ef983cef5ad252972bf316ec commit f13af80790bd8020ef983cef5ad252972bf316ec Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 12:53:49 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:08 +0000 astro/gpscorrelate: make compatible with exiv2 0.28 PR: 272311 astro/gpscorrelate/Makefile | 11 +++- astro/gpscorrelate/files/patch-exif-gps.cpp | 92 +++++++++++++++++++++++++++-- 2 files changed, 95 insertions(+), 8 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4e79a077ff6661edd98bd83266d6c8a9dbd8be4b commit 4e79a077ff6661edd98bd83266d6c8a9dbd8be4b Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 13:19:50 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:08 +0000 graphics/hugin: make compatible with exiv2 0.28 PR: 272311 graphics/hugin/Makefile | 2 +- ...-src_hugin__base_panodata_Exiv2Helper.cpp (new) | 27 +++++++++++++ ...src_hugin__base_panodata_SrcPanoImage.cpp (new) | 47 ++++++++++++++++++++++ 3 files changed, 75 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=31eddbf0fa9911b71a8b4f37ea2245cbb137a8f1 commit 31eddbf0fa9911b71a8b4f37ea2245cbb137a8f1 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-03 00:04:09 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:09:11 +0000 graphics/kphotoalbum: make compatible with exiv2 0.28 PR: 272311 graphics/kphotoalbum/Makefile | 2 +- .../kphotoalbum/files/patch-DB_FileInfo.cpp (new) | 11 +++++++++++ .../files/patch-lib_kpaexif_Database.cpp (new) | 20 ++++++++++++++++++++ .../patch-lib_kpaexif_DatabaseElement.cpp (new) | 11 +++++++++++ .../files/patch-lib_kpaexif_Info.cpp (new) | 20 ++++++++++++++++++++ 5 files changed, 63 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=738d7427d67024949b1541cf2968f16aa3b6f384 commit 738d7427d67024949b1541cf2968f16aa3b6f384 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 14:48:40 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:10 +0000 graphics/photivo: make compatible with exiv2 0.28 PR: 272311 graphics/photivo/Makefile | 2 +- .../photivo/files/patch-Sources_ptImageHelper.cpp | 52 +++++++++++++++++++++- .../photivo/files/patch-Sources_ptMain.cpp (new) | 11 +++++ 3 files changed, 63 insertions(+), 2 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d58c19e0f1a684ed9c8c16057056cb4d0daa58ec commit d58c19e0f1a684ed9c8c16057056cb4d0daa58ec Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 12:49:16 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:08 +0000 graphics/gimp-lensfun-plugin: make compatible with exiv2 0.28 PR: 272311 graphics/gimp-lensfun-plugin/Makefile | 17 ++++++++++++++--- .../files/patch-src_gimplensfun.cpp (new) | 20 ++++++++++++++++++++ 2 files changed, 34 insertions(+), 3 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ecc765c90f846cd53ba26fd2b3825f9db3852244 commit ecc765c90f846cd53ba26fd2b3825f9db3852244 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 11:25:39 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:06 +0000 graphics/darktable: make compatible with exiv2 0.28 PR: 272311 graphics/darktable/Makefile | 2 +- .../darktable/files/patch-src_common_exif.cc (new) | 681 +++++++++++++++++++++ 2 files changed, 682 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5f1836a182b87f8402cf50e86e889c9cdf9f32be commit 5f1836a182b87f8402cf50e86e889c9cdf9f32be Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 11:33:03 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:06 +0000 graphics/filmulator: make compatible with exiv2 0.28 PR: 272311 graphics/filmulator/Makefile | 2 +- .../files/patch-core_imwriteJpeg.cpp (new) | 11 +++++++++++ .../files/patch-database_exifFunctions.cpp (new) | 20 ++++++++++++++++++++ 3 files changed, 32 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ce4a214fb7091fc6a141b9d278e17e65029368b9 commit ce4a214fb7091fc6a141b9d278e17e65029368b9 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-01 11:58:04 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:05 +0000 graphics/exiv2: upgrade to 0.28 Add DOCS and DOXYGEN options to allow building/installing extra documentation. Cherry-pick a few fixes from the upstream Git repo, and add one FreeBSD-specific fix to libprocinfo interface that caused crashes in the test rig, and add sscanf/printf vs type fixes. Fix a few things in exiv2 and Adobe XMP SDK found while test-compiling exiv2 consumers. All local fixes to .cpp filed with upstream repo as pull req. While here, reformat/rearrange to please portlint and portfmt/portclippy. Assisted and Reviewed by: diizzy@ PR: 272311 Differential Revision: https://reviews.freebsd.org/D40828 graphics/exiv2/Makefile | 71 ++++++++++-------- graphics/exiv2/distinfo | 18 ++++- .../files/patch-_MSVC_LANG-warning-Wundef (new) | 84 ++++++++++++++++++++++ graphics/exiv2/files/patch-cmake_mainSetup.cmake | 4 +- graphics/exiv2/files/patch-src_version.cpp (new) | 16 +++++ .../exiv2/files/patch-xmpsdk_src_XMPMeta.cpp (new) | 15 ++++ .../files/patch-xmpsdk_src_XMPUtils.cpp (new) | 17 +++++ graphics/exiv2/pkg-plist | 12 ++-- 8 files changed, 194 insertions(+), 43 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f858ee546f4f41478867fce862496935fdfe723b commit f858ee546f4f41478867fce862496935fdfe723b Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-02 13:35:32 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:08:09 +0000 graphics/krita: make compatible with exiv2 0.28 Obtained from: https://invent.kde.org/graphics/krita/-/commits/64382cb061e622211e0f96a1a88f649084c95911 PR: 272311 graphics/krita/Makefile | 2 +- .../files/patch-git-exiv2-a-e7bf1f0d299 (new) | 582 +++++++++++++++++++++ 2 files changed, 583 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a3a68eda0484fbbc23a313b5e338e281662b40f1 commit a3a68eda0484fbbc23a313b5e338e281662b40f1 Author: Jan Beich <jbeich@FreeBSD.org> AuthorDate: 2023-07-09 23:43:56 +0000 Commit: Jan Beich <jbeich@FreeBSD.org> CommitDate: 2023-07-09 23:49:06 +0000 graphics/gexiv2: mark BROKEN on i386 after ce4a214fb709 In file included from ../gexiv2/gexiv2-metadata.cpp:21: ../gexiv2/gexiv2-stream-io.h:49:39: error: non-virtual member function marked 'override' hides virtual member function int seek (long offset, Position pos) override; ^ /usr/local/include/exiv2/basicio.hpp:165:15: note: hidden overloaded virtual function 'Exiv2::BasicIo::seek' declared here: type mismatch at 1st parameter ('int64_t' (aka 'long long') vs 'long') virtual int seek(int64_t offset, Position pos) = 0; ^ ../gexiv2/gexiv2-metadata.cpp:152:71: error: non-virtual member function marked 'override' hides virtual member function int seek(seek_offset_t offset, Exiv2::BasicIo::Position position) override { ^ /usr/local/include/exiv2/basicio.hpp:165:15: note: hidden overloaded virtual function 'Exiv2::BasicIo::seek' declared here: type mismatch at 1st parameter ('int64_t' (aka 'long long') vs '(anonymous namespace)::GioIo::seek_offset_t' (aka 'long')) virtual int seek(int64_t offset, Position pos) = 0; ^ ../gexiv2/gexiv2-metadata.cpp:533:43: error: allocating an object of abstract class type 'StreamIo' StreamIo::ptr_type stream_ptr{new StreamIo (cb)}; ^ /usr/local/include/exiv2/basicio.hpp:165:15: note: unimplemented pure virtual method 'seek' in 'StreamIo' virtual int seek(int64_t offset, Position pos) = 0; ^ ../gexiv2/gexiv2-metadata.cpp:552:37: error: allocating an object of abstract class type '(anonymous namespace)::GioIo' GioIo::ptr_type gio_ptr{new GioIo (stream)}; ^ /usr/local/include/exiv2/basicio.hpp:165:15: note: unimplemented pure virtual method 'seek' in 'GioIo' virtual int seek(int64_t offset, Position pos) = 0; ^ ../gexiv2/gexiv2-metadata.cpp:744:43: error: allocating an object of abstract class type 'StreamIo' StreamIo::ptr_type stream_ptr{new StreamIo (cb)}; ^ In file included from ../gexiv2/gexiv2-stream-io.cpp:13: ../gexiv2/gexiv2-stream-io.h:49:39: error: non-virtual member function marked 'override' hides virtual member function int seek (long offset, Position pos) override; ^ /usr/local/include/exiv2/basicio.hpp:165:15: note: hidden overloaded virtual function 'Exiv2::BasicIo::seek' declared here: type mismatch at 1st parameter ('int64_t' (aka 'long long') vs 'long') virtual int seek(int64_t offset, Position pos) = 0; ^ PR: 272311 graphics/gexiv2/Makefile | 2 ++ 1 file changed, 2 insertions(+)
The branch main has been updated by mandree: URL: https://cgit.FreeBSD.org/ports/commit/?id=e89a070af87a164b229ae5153105b5266b3dfe90 commit e89a070af87a164b229ae5153105b5266b3dfe90 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-09 22:14:18 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-09 22:14:18 +0000 graphics/exiv2: fix fetching checksums of patches have changed, we may need to move these dist patches into our local repo to avoid suffering from upstream changes to formatting, or try using .diff instead of .patch. --- graphics/exiv2/distinfo | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
The branch main has been updated by mandree: URL: https://cgit.FreeBSD.org/ports/commit/?id=35f6785273f4a00224ce47eaa63527acc3ff76e1 commit 35f6785273f4a00224ce47eaa63527acc3ff76e1 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2023-07-10 06:08:30 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-07-10 06:34:50 +0000 graphics/gexiv2: revert cherry-pick upstream patch to make compatible with exiv2 0.28. This reverts commit 4669ac03f2316ac2db9e72867fbb558c48ef5db3. It should not have been committed because 8f2c42142d37 already addressed the same issue. Reverting that commit fixes patch errors. --- graphics/gexiv2/Makefile | 3 --- graphics/gexiv2/distinfo | 4 +--- 2 files changed, 1 insertion(+), 6 deletions(-)
(In reply to commit-hook from comment #95) @cmt, Christoph, can you check if upstream has done anything about this? OTOH I am wondering why not both use off_t or such types. We may need to work this out with exiv2 as well, but until that changes, gexiv2 should either properly convert between its and exiv2's types, This int64_t (long long on i386, long on many others) blocks the following ports on i386 because they need gexiv2 in their default configuration: graphics/elementary-photos graphics/entangle graphics/gegl graphics/gimp-app deskutils/gnome-photos science/gramps x11-fm/nautilus graphics/rapid-photo-downloader graphics/shotwell sysutils/tracker-miners graphics/variety
that incomplete phrase should read ...or follow exiv2's function signatures exactly.
(In reply to Matthias Andree from comment #98) the problem persists in gexiv2's HEAD as of today. Looks like a "if it was good enough for K&R, it will do fur us" kind of coding. Should be fixable (may need some testing), but then historic hardware is not that high on my list of priorities.