Bug 272749 - ndp(8): correct a few xo_emit formats
Summary: ndp(8): correct a few xo_emit formats
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 13.2-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-net (Nobody)
URL:
Keywords: ipv6, patch
Depends on:
Blocks:
 
Reported: 2023-07-27 09:02 UTC by Helge Oldach
Modified: 2023-09-13 13:38 UTC (History)
2 users (show)

See Also:

Attachments
patch (937 bytes, patch)
2023-07-27 09:02 UTC, Helge Oldach 		no flags Details | Diff
patch (1.28 KB, patch)
2023-09-13 13:38 UTC, Helge Oldach 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2023-07-27 09:02:31 UTC 
Created attachment 243638 [details]
patch

Fix are a few incorrect xo_emit formats which are hiding useful printout for ndp -p and ndp -a.
Comment 1 Mina Galić freebsd_triage 2023-07-27 13:51:22 UTC 
Hi Helge,

i know this is a pretty trivial patch, but we're trying to get rid of src patches in Bugzilla. Unlike ports, there's no established process to get them committed quickly, and bugzilla has no review system like Phabricator (https://reviews.freebsd.org/) or Github (https://github.com/freebsd/freebsd-src)

See https://docs.freebsd.org/en/articles/contributing/ for more info.

in general: Patches are made against the "main" branch, and then MFC'd down to stable. I mention this because this bug is open against Version 13.2-STABLE. 

Either way, I'm assigning this to net@ now.
Comment 2 Helge Oldach 2023-07-27 14:08:13 UTC 
I forgot to add that this patch applies cleanly to main (with fuzz and offset though).
Comment 3 Helge Oldach 2023-09-13 13:38:49 UTC 
Created attachment 244806 [details]
patch

Added a correction for the ts_print function as well.