Bug 273377 - textproc/libxmlb: Update to 0.3.14
Summary: textproc/libxmlb: Update to 0.3.14
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL: https://github.com/hughsie/libxmlb/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-27 05:33 UTC by Daniel Engberg
Modified: 2023-11-05 07:56 UTC (History)
1 user (show)

See Also:
arrowd: maintainer-feedback+

Attachments
Patch for libxmlb (5.09 KB, patch)
2023-08-27 05:33 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-08-27 05:33:33 UTC 
Created attachment 244376 [details]
Patch for libxmlb

- Make DOCS optional to avoid pulling in gtk-doc

Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist, make test)

Poudriere testport OK 13.2-RELEASE (aarch64)

Tested with following consumers in 13.2-RELEASE (aarch64) using Poudriere:
devel/appstream
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2023-08-27 12:48:35 UTC 
Oh, I missed this bug report. You patch looks good, Daniel, why didn't you commit it yourself?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-08-27 14:12:09 UTC 
I'm not a member of desktop@
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2023-08-27 16:37:28 UTC 
The change isn't invasive, almost trivial. I think no one would blame you have you committed it without desktop@ approval.

Please push this in.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-08-27 17:41:31 UTC 
I'd rather follow our guidelines and get an approval
Comment 5 Gleb Popov freebsd_committer freebsd_triage 2023-08-27 18:20:28 UTC 
You have my approval with desktop@ hat, then.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-11-05 07:53:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ee85af825abaa760e8504cee2a45c3fbe457bc5f

commit ee85af825abaa760e8504cee2a45c3fbe457bc5f
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-11-05 01:05:43 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-11-05 07:52:11 +0000

    textproc/libxmlb: Add option for DOCS

    Make DOCS optional to avoid pulling in gtk-doc

    PR:             273377
    Approved by:    desktop (arrowd)

 textproc/libxmlb/Makefile  |  6 ++++-
 textproc/libxmlb/distinfo  |  2 +-
 textproc/libxmlb/pkg-plist | 64 +++++++++++++++++++++++-----------------------
 3 files changed, 38 insertions(+), 34 deletions(-)