Bug 273611 - x11/nvidia-settings Update to 535.104.05
Summary: x11/nvidia-settings Update to 535.104.05
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kevin Bowling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-07 07:24 UTC by Bartek Jasicki
Modified: 2024-01-01 20:55 UTC (History)
2 users (show)

See Also:
kbowling: maintainer-feedback-


Attachments
Update to 535.104.05 (2.12 KB, patch)
2023-09-07 07:24 UTC, Bartek Jasicki
no flags Details | Diff
Update to 535.104.05 with removed PORTREVISION (2.15 KB, patch)
2023-12-31 08:11 UTC, Bartek Jasicki
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bartek Jasicki 2023-09-07 07:24:14 UTC
Created attachment 244687 [details]
Update to 535.104.05

Updated to the newest version of the stable version of the driver. The main change is switching from Gtk2 to Gtk3. There are other changes too, the port wasn't updated by a long time. ;) Please test do everything works as expected, especially with older drivers.
Comment 1 Bartek Jasicki 2023-10-27 08:53:31 UTC
I think we waited log enough for the feedback here. :) Can we now commit this patch, or there are any problems to solve?
Comment 2 N.J. Mann 2023-12-28 11:56:27 UTC
I have been running with your update for a week now and have discovered
no regressions.  I have tried the GUI a few times and that seems okay.  I
use the CLI regularly to collect fan speed and temperature data for display
on my desktop using sysutils/conky.  I also use the CLI to control the GPU
performance depending on what applications I am running.  All work fine.

I have one comment on your patch: you should have removed the setting of
PORTREVISION since DISTVERSION (PORTVERSION) has been changed.  See the
Porters Handbook section 5.2.3.1.

If you update your patch with this one change we can start badgering
committers to get it in the repro.
Comment 3 Bartek Jasicki 2023-12-31 08:11:35 UTC
Created attachment 247368 [details]
Update to 535.104.05 with removed PORTREVISION

(In reply to N.J. Mann from comment #2)

First, I apologize for delay in answer. For some reason, I don't get any mails, either from Bugzilla or mailing lists.

Thank you for testing the patch and the correction. Here is the same patch, with removed PORTREVISION setting, so it should work. ;)

And mandatory, Happy New Year.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-01-01 20:55:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7f0c993b24da25102c2e0dd60580c4c88c509385

commit 7f0c993b24da25102c2e0dd60580c4c88c509385
Author:     Bartek Jasicki <thindil@laeran.pl.eu.org>
AuthorDate: 2024-01-01 19:56:39 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-01-01 20:53:53 +0000

    x11/nvidia-settings: Update to 535.104.05

    Switch to GTK3

    PR:             273611
    Approved by:    x11 (maintainer timeout)

 x11/nvidia-settings/Makefile | 12 ++++++------
 x11/nvidia-settings/distinfo |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-01-01 20:55:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a07ed4237d4a5db9a949a22d1259bb966db8442d

commit a07ed4237d4a5db9a949a22d1259bb966db8442d
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-01-01 20:46:32 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-01-01 20:53:53 +0000

    x11/nvidia-settings: Update to 535.146.02

    PR:             273611
    Approved by:    x11 (maintainer timeout)

 x11/nvidia-settings/Makefile | 2 +-
 x11/nvidia-settings/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)