Bug 27422 - change request
Summary: change request
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 1.0-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-05-18 05:50 UTC by jason
Modified: 2001-07-20 23:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jason 2001-05-18 05:50:01 UTC
Add to sync missing header for exit(3) and prototype main() to standard.

diffs to current
http://www.smethers.net/~jason/FreeBSD/patches/bin.sync.0.u.diff
Comment 1 Mike Barcroft freebsd_committer freebsd_triage 2001-07-18 04:09:43 UTC
State Changed
From-To: open->closed

The include for <stdlib.h> was added to sync(8) 4 weeks ago. 
Also, we have corrected gcc so that it no longer warns about 
a non-prototyped main().
Comment 2 Mike Barcroft freebsd_committer freebsd_triage 2001-07-20 23:16:00 UTC
On Fri, Jul 20, 2001 at 03:51:33PM -0500, Jason wrote:
> On Tuesday 17 July 2001 10:13, mike@FreeBSD.org wrote:
> > Also, we have corrected gcc so that it no longer warns about
> > a non-prototyped main().
> >
> > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27422
> 
> What if I decide to use a complier other than gcc? It may break.
> 
> Why not correct the code? You can be sure that someone will bring this kind 
> of stuff up again and again. Why not fix just it now and have it over with?

A prototype of main() should never be required.  A warning such
as a missing prototype is almost never a fatal error.  The only
reason we corrected gcc was because of the WARNS lockdown we are
currently doing (see -audit archives for details).

Best regards,
Mike Barcroft