Bug 275078 - audio/audacity: Fix build with x11-toolkits/wxgtk32 3.2.4
Summary: audio/audacity: Fix build with x11-toolkits/wxgtk32 3.2.4
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks: 274367
  Show dependency tree / graph
 
Reported: 2023-11-14 14:03 UTC by Nuno Teixeira
Modified: 2023-11-22 09:03 UTC (History)
2 users (show)

See Also:

Attachments
fix with wx 3.2.4 (1.16 KB, patch)
2023-11-14 14:03 UTC, Nuno Teixeira 		xxjack12xx: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2023-11-14 14:03:47 UTC 
Created attachment 246306 [details]
fix with wx 3.2.4

Apply upstream patch to fix build with wxgtk32 3.2.4

https://github.com/audacity/audacity/issues/5598
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-14 14:05:29 UTC 
Since this commit with be part of upcoming release 3.4.2 it seems to be safe to apply it now.

Cheers
Comment 2 Jack 2023-11-14 19:08:46 UTC 
Comment on attachment 246306 [details]
fix with wx 3.2.4

Patch applies cleanly and looks ok.
Comment 3 Jack 2023-11-14 19:10:04 UTC 
I can't seem to get the flags for the patch to change to + for some reason.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-14 19:23:58 UTC 
(In reply to Jack from comment #3)

Did you tried click on details after "eduardo: maintainer-approval?"
Comment 5 Jack 2023-11-14 19:32:45 UTC 
Comment on attachment 246306 [details]
fix with wx 3.2.4

Changing maintainer-approval on flags for eduardo from ? to +, let's see if it changes this time.
Comment 6 Jack 2023-11-14 19:33:15 UTC 
Flags still stuck on ? even after I changed from ? to +
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-15 06:50:31 UTC 
(In reply to Jack from comment #6)

Something is nor right here.
Please try again as I use you maintainer address in requestee field.
Comment 8 Jack 2023-11-15 06:53:39 UTC 
Looks like that worked.
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-22 09:03:33 UTC 
Updated to 3.4.2 that includes wxWigets 3.2.4 build fix