Bug 275211 - lang/rust: Garbage collect powerpc patches
Summary: lang/rust: Garbage collect powerpc patches
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Rust Team
Depends on:
Reported: 2023-11-20 11:37 UTC by Mikael Urankar
Modified: 2023-11-22 16:39 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rust)

v0 (2.79 KB, patch)
2023-11-20 11:37 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer 2023-11-20 11:37:00 UTC
@Piotr: can we remove these patches?
I don't understand what this line is supposed to do:
(Triple.getOSMajorVersion() == 0 || Triple.getOSMajorVersion() >= 13))

It fixes rust-bootstrap@powerpc after https://github.com/rust-lang/llvm-project/commit/5d585c9dd07d0df4d450e2b1ba61fb17a5153aac
Comment 1 Mikael Urankar freebsd_committer 2023-11-20 11:37:36 UTC
Created attachment 246444 [details]
Comment 2 Piotr Kubaj freebsd_committer 2023-11-21 21:48:28 UTC
I'll test it, but basically this line means that if the target is powerpc-unknown-freebsd13.0 (or newer version) or if the version is not specified (so the target is powerpc-unknown-freebsd), then secureplt is enabled.
Comment 3 Piotr Kubaj freebsd_committer 2023-11-21 21:49:50 UTC
I think we could currently just drop the version check and just enable secureplt on all powerpc since there wasn't even a Rust support for 12.x.
Comment 4 Piotr Kubaj freebsd_committer 2023-11-22 13:40:57 UTC
Testing with 1.73.0, the whole files/powerpc directory may be safely removed. Both lang/rust in powerpc jail and lang/rust-bootstrap@powerpc build.
Comment 5 Mikael Urankar freebsd_committer 2023-11-22 14:39:46 UTC
(In reply to Piotr Kubaj from comment #4)
Ok, thanks. Can you commit the change please?