Created attachment 246455 [details] cdefs cleanup to get rid of stuff we did in the early 2000s we no longer need. This is a bigger rototilling of cdefs.h. My last one for the month. Just need an exp run to make sure that my high level analysis of "nobody will notice or care" is correct.
Exp-run looks fine
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=17a238a15fbed01477fbc54744d35cbccdb65871 commit 17a238a15fbed01477fbc54744d35cbccdb65871 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-11-20 23:34:22 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-11-27 05:24:02 +0000 cdefs: Remove __func__ define We require an ANSI-C compiler to build the base system. It's required that __func__ work. Remove this define since the only known problem compilers are ancient history (gcc 2.6 from 1994, almost pre-dating the project). 3rd party code that used this define will now need to provide it via some other means when using non-ansi-c compilers. PR: 275221 (exp-run) Sponsored by: Netflix sys/sys/cdefs.h | 40 ++------------------------------------ tests/sys/opencrypto/cryptodevh.py | 4 ---- 2 files changed, 2 insertions(+), 42 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=042f0f00c24b62dcd432a4ca2980467f2adef65e commit 042f0f00c24b62dcd432a4ca2980467f2adef65e Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-11-20 23:09:55 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-11-27 05:24:02 +0000 cdefs: Move GNUC_PREREQ to top of file It really should be closer to the the top of the file, so move it to the start of the compiler specific section. PR: 275221 (exp-run) Sponsored by: Netflix sys/sys/cdefs.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=9e555522084871b341e81269fa599c707133ae58 commit 9e555522084871b341e81269fa599c707133ae58 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-11-20 22:40:55 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-11-27 05:24:02 +0000 cdefs: Remove vararg related defines, they are unused. Remove __GNUCLIKE_BUILTIN_VARARGS, __GNUCLIKE_BUILTIN_STDARG, __GNUCLIKE_BUILTIN_VAALIST, __GNUC_VA_LIST_COMPATIBILITY: they are unused. Also remove them from the generated cryptodevh.py script. PR: 275221 (exp-run) Sponsored by: Netflix sys/sys/cdefs.h | 8 -------- tests/sys/opencrypto/cryptodevh.py | 4 ---- 2 files changed, 12 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=b88ca6ee167d079c965dfe123bbe296d3a945c0a commit b88ca6ee167d079c965dfe123bbe296d3a945c0a Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-11-20 22:40:55 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-11-27 05:24:02 +0000 cdefs: Remove CC_SUPPORTS macros, they are unused Remove __CC_SUPPORTS_INLINE, __CC_SUPPORTS___INLINE__, __CC_SUPPORTS___FUNC__, __CC_SUPPORTS_WARNING, __CC_SUPPORTS_VARADIC_XXX, __CC_SUPPORTS_DYNAMIC_ARRAY_INIT: they are unused. Also remove them from the generated cryptodevh.py script. Retain, for the moment, __CC_SUPPORTS___INLINE, since it's used in this file. PR: 275221 (exp-run) Sponsored by: Netflix sys/sys/cdefs.h | 10 ---------- tests/sys/opencrypto/cryptodevh.py | 7 ------- 2 files changed, 17 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=45aa39f884033997c87f513fe7175f465132e468 commit 45aa39f884033997c87f513fe7175f465132e468 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-11-20 22:39:45 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-11-27 05:24:01 +0000 cdefs: Remove __GNUCLIKE___SECTION, it's unused. __GNUCLIKE___SECTION is unused, remove it. Also remove it from the generated cryptodevh.py script. PR: 275221 (exp-run) Sponsored by: Netflix sys/sys/cdefs.h | 2 -- tests/sys/opencrypto/cryptodevh.py | 1 - 2 files changed, 3 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=d2ec42ca575132e5af70d8991c64157a291982e9 commit d2ec42ca575132e5af70d8991c64157a291982e9 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-11-20 22:40:55 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-11-27 05:24:02 +0000 cdefs: Remove __GNUCLIKE_CTOR_SECTION_HANDLING, it's unused __GNUCLIKE_CTOR_SECTION_HANDLING is unused, remove it. Also remove it from the generated cryptodevh.py script. PR: 275221 (exp-run) Sponsored by: Netflix sys/sys/cdefs.h | 2 -- tests/sys/opencrypto/cryptodevh.py | 1 - 2 files changed, 3 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=eaaa7ca0c38c014f2f2c0a06b82f83baa03b2d60 commit eaaa7ca0c38c014f2f2c0a06b82f83baa03b2d60 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-11-20 22:40:55 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-11-27 05:24:02 +0000 cdefs: Remove __GNUCLIKE_BUILTIN_CONSTANT_P, it's unused __GNUCLIKE_BUILTIN_CONSTANT_P is unused, remove it. Also remove it from the generated cryptodevh.py script. PR: 275221 (exp-run) Sponsored by: Netflix sys/sys/cdefs.h | 2 -- tests/sys/opencrypto/cryptodevh.py | 1 - 2 files changed, 3 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=a83d4fe9cbc51adcefb8a1070374186f3399fef4 commit a83d4fe9cbc51adcefb8a1070374186f3399fef4 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-11-20 22:40:55 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-11-27 05:24:02 +0000 cdefs: Remove some builtin defines, they are unused Remove __GNUCLIKE_BUILTIN_NEXT_ARG, __GNUCLIKE_MATH_BUILTIN_RELOPS, __GNUCLIKE_BUILTIN_MEMCPY: they are unused. Also remove them from the generated cryptodevh.py script. PR: 275221 (exp-run) Sponsored by: Netflix sys/sys/cdefs.h | 5 ----- tests/sys/opencrypto/cryptodevh.py | 2 -- 2 files changed, 7 deletions(-)