Bug 275317 - net/mpich: upgrade to 4.1.2
Summary: net/mpich: upgrade to 4.1.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thierry Thomas
URL: https://www.mpich.org/2023/06/08/mpic...
Keywords:
Depends on: 275431 275432 275485
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-24 20:17 UTC by Thierry Thomas
Modified: 2023-12-21 04:34 UTC (History)
2 users (show)

See Also:
antoine: exp-run+


Attachments
Upgrade to 4.1.2 (42.77 KB, patch)
2023-11-24 20:17 UTC, Thierry Thomas
no flags Details | Diff
Upgrade to 4.1.2 + install mpi_f08.mod (43.67 KB, patch)
2023-11-29 17:46 UTC, Thierry Thomas
thierry: maintainer-approval+
Details | Diff
Successful build-log (compressed) (132.53 KB, application/x-xz)
2023-12-18 18:26 UTC, Mikhail T.
no flags Details
mpich's config log (464.55 KB, text/plain)
2023-12-18 18:31 UTC, Mikhail T.
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2023-11-24 20:17:03 UTC
Created attachment 246552 [details]
Upgrade to 4.1.2

Release notes at <https://www.mpich.org/2023/06/08/mpich-4-1-2-released/>.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2023-11-24 20:19:01 UTC
Hello,
It seems OK for me, but I cannot test all the dependencies.
Could you please launch an exp-run?
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2023-11-29 17:46:04 UTC
Created attachment 246665 [details]
Upgrade to 4.1.2 + install mpi_f08.mod

This new patch installs mpi_f08.mod and some other interfaces, but this requires ISO_Fortran_binding.h to be found. This allows to solve the error on net/mpifx (with an upgrade).
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2023-12-06 06:05:24 UTC
Hello Antoine,
Could you please re-launch an exp-run, with the attached patch and the one in PR 275432 (for net/mpifx)?
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2023-12-09 21:14:33 UTC
Exp-run looks fine
Comment 6 Thierry Thomas freebsd_committer freebsd_triage 2023-12-10 10:23:29 UTC
Committed, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-12-10 10:24:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=81372858caaf3bccba99f2b851320f13620d7dad

commit 81372858caaf3bccba99f2b851320f13620d7dad
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2023-11-29 17:37:55 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2023-12-10 10:23:11 +0000

    net/mpich: upgrade to 4.1.2

    Upgrade to 4.1.2

    Release notes at <https://www.mpich.org/2023/06/08/mpich-4-1-2-released/>.

    It also installs mpi_f08.mod and some other interfaces, but this requires
    ISO_Fortran_binding.h to be found.

    PR:             275317
    Exp-run by:     antoine@

 net/mpich/Makefile                       |  18 +-
 net/mpich/distinfo                       |   6 +-
 net/mpich/files/patch-Makefile.in        |  30 +-
 net/mpich/files/patch-configure          |  91 +++---
 net/mpich/files/patch-l0-1.4.1 (gone)    |  60 ----
 net/mpich/files/patch-l0-fallback (gone) |  44 ---
 net/mpich/files/patch-test_mpi_configure |  36 +--
 net/mpich/pkg-descr                      |   2 +
 net/mpich/pkg-plist                      | 488 ++++++++++++++++++++++++++++++-
 9 files changed, 558 insertions(+), 217 deletions(-)
Comment 8 Mikhail T. 2023-12-18 17:50:56 UTC
I just tried building it here -- FreeBSD-14/amd64, gfortran12 -- and the packaging failed:

===>  Installing for mpich-4.1.2
===>  Checking if mpich is already installed
===>  Switching to root credentials for 'install' target
===>   Registering installation for mpich-4.1.2 as automatic
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface_cdesc.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface_glue.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface_nobuf.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface_types.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08_callbacks.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08_compile_constants.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08_link_constants.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08_types.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/pmpi_f08.mod:No such file or directory

The options are:
# Options for mpich-3.4.2_3
_OPTIONS_READ=mpich-3.4.2_3
_FILE_COMPLETE_OPTIONS_LIST=DOCS FORTRAN L0 DGFORKER DHYDRA GFORKER HYDRA
OPTIONS_FILE_UNSET+=DOCS
OPTIONS_FILE_SET+=FORTRAN
OPTIONS_FILE_SET+=L0
OPTIONS_FILE_UNSET+=DGFORKER
OPTIONS_FILE_SET+=DHYDRA
OPTIONS_FILE_SET+=GFORKER
OPTIONS_FILE_SET+=HYDRA
Comment 9 Thierry Thomas freebsd_committer freebsd_triage 2023-12-18 18:19:34 UTC
Hello,
It looks like you have not upgraded GCC to gcc-12.2.0_7, have you?
ISO_Fortran_binding.h is required to get these interfaces.
Comment 10 Mikhail T. 2023-12-18 18:21:39 UTC
(In reply to Thierry Thomas from comment #9)
> It looks like you have not upgraded GCC to gcc-12.2.0_7, have you?

I had gcc12 installed, but the DEFAULT_VERSIONS still listed version 11 as the default for gcc.

> ISO_Fortran_binding.h is required to get these interfaces.

In order to obtain a build-log for you, I just rebuilt the port from scratch -- and can no longer reproduce the problem. Sorry for the noise...
Comment 11 Mikhail T. 2023-12-18 18:26:15 UTC
Created attachment 247146 [details]
Successful build-log (compressed)

> and can no longer reproduce the problem. Sorry for the noise...

Spoke too soon :( Though the BUILD succeeds, the packaging continues to fail:

===>  Installing for mpich-4.1.2
===>  Checking if mpich is already installed
===>  Switching to root credentials for 'install' target
===>   Registering installation for mpich-4.1.2
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface_cdesc.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface_glue.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface_nobuf.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_c_interface_types.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08_callbacks.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08_compile_constants.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08_link_constants.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/mpi_f08_types.mod:No such file or directory
pkg-static: Unable to access file /n/home/ports/net/mpich/work/stage/opt/include/pmpi_f08.mod:No such file or directory
Comment 12 Mikhail T. 2023-12-18 18:31:50 UTC
Created attachment 247147 [details]
mpich's config log

The attached config.log mentions the missing .mod files, but there are no obvious errors...

There are four other .mod files installed Ok:

-rw-r--r--  1 mi wheel 49799 Dec 18 13:17 work/stage/opt/include/mpi.mod
-rw-r--r--  1 mi wheel 37375 Dec 18 13:17 work/stage/opt/include/mpi_base.mod
-rw-r--r--  1 mi wheel 10919 Dec 18 13:17 work/stage/opt/include/mpi_constants.mod
-rw-r--r--  1 mi wheel  1345 Dec 18 13:17 work/stage/opt/include/mpi_sizeofs.mod
Comment 13 Thierry Thomas freebsd_committer freebsd_triage 2023-12-18 19:13:23 UTC
1) Is it on a clean environment, with up-to-date dependencies?

2) Which version of FreeBSD?

3) Have you enabled some non-default options?
Comment 14 Mikhail T. 2023-12-18 19:15:49 UTC
(In reply to Thierry Thomas from comment #13)
> 1) Is it on a clean environment, with up-to-date dependencies?
> 2) Which version of FreeBSD?
> 3) Have you enabled some non-default options?

It is a FreeBSD-14 upgraded from source from FreeBSD-13 only a few weeks earlier. I included the versions-dump in the earlier comment #8.
Comment 15 Thierry Thomas freebsd_committer freebsd_triage 2023-12-18 20:33:56 UTC
(In reply to Mikhail T. from comment #14)
Sorry, I forgot about it!

And what about my first question?

I checked you log, and did not see anything strange...
Comment 16 Mikhail T. 2023-12-18 20:36:50 UTC
(In reply to Thierry Thomas from comment #15)
> And what about my first question?

I tried answering that with the "It is a FreeBSD-14 upgraded from source from FreeBSD-13 only a few weeks earlier" :)

That is, I rebuilt all of the ports to have arch:14 instead of 13 at the end of November... I'll kick off a portupgrade again now...
Comment 17 Thierry Thomas freebsd_committer freebsd_triage 2023-12-18 21:31:28 UTC
Remark: I have just committed an upgrade of Slurm, with a fix for MPICH, but nothing is related to your problem.
Comment 18 Mikhail T. 2023-12-21 04:34:21 UTC
(In reply to Thierry Thomas from comment #9)
> It looks like you have not upgraded GCC to gcc-12.2.0_7, have you?

Yep. This was it... I rebuilt everything on the 28th, you updated gcc on the 29th...

mpich just built:

===> No pkg-plist issues found (check-plist)

Thanks!