Bug 275401 - lang/erlang lang/erlang-runtime24 lang/erlang-runtime25: Fix CHUNKS option
Summary: lang/erlang lang/erlang-runtime24 lang/erlang-runtime25: Fix CHUNKS option
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-erlang (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-28 06:29 UTC by Stefan Grundmann
Modified: 2023-12-01 16:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (erlang)


Attachments
update lang/erlang, lang/erlang-runtime24 and lang/erlang-runtime25 (4.75 KB, patch)
2023-11-28 07:19 UTC, Stefan Grundmann
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Grundmann 2023-11-28 06:29:07 UTC

    
Comment 1 Stefan Grundmann 2023-11-28 07:19:26 UTC
Created attachment 246628 [details]
update lang/erlang, lang/erlang-runtime24 and lang/erlang-runtime25
Comment 2 Stefan Grundmann 2023-11-28 07:20:19 UTC
the CHUNKS option in lang/erlang lang/erlang-runtime24 and lang/erlang-runtime25 (default on) is not working as intended:
inline documentation is built but not staged and therefore not included in the
created package.

The reason is that the ports run
 
  'gmake all DOC_TARGETS=chunks docs'

to genereate the inline documentation (lib/*/doc/chunks/*.chunk) files
together with the usual build artifacts.

But the 'install' target does not handle these files and they never end up in the staging dir.

The attached patch does update lang/erlang, lang/erlang-runtime24 and lang/erlang-runtime26

For lang/erlang-runtime26 see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271541
Comment 3 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2023-11-30 15:57:04 UTC
Hi!

I submitted a patch for review to fix exactly that, but I didn't get approval yet:
https://reviews.freebsd.org/D40253

You and I took different approaches, I would love to get some feedback from the erlang@ team and other users of Erlang :-)
Comment 4 Stefan Grundmann 2023-12-01 16:05:49 UTC
(In reply to Jean-Sébastien Pédron from comment #3)

your approach removes the ability to disable chunks (increases build time and package size).

but since it also does generate documentation for corba (if enabled) it is better than my patch which missed this.