Bug 275634 - Mk/Uses/cargo.mk: cargo-extract fails with DIST_SUBDIR
Summary: Mk/Uses/cargo.mk: cargo-extract fails with DIST_SUBDIR
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joel Bodenmann
URL:
Keywords:
Depends on:
Blocks: 275922
  Show dependency tree / graph
 
Reported: 2023-12-08 13:46 UTC by Dmitry Wagin
Modified: 2024-01-07 15:58 UTC (History)
2 users (show)

See Also:

Attachments
cargo.mk.diff (644 bytes, patch)
2023-12-08 13:46 UTC, Dmitry Wagin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Wagin 2023-12-08 13:46:01 UTC 
Created attachment 246907 [details]
cargo.mk.diff

When DIST_SUBDIR is set in a port, extract target is failed.

Because the DESTDIR variable is used instead of _DESTDIR.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-01-07 15:16:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c2e360d6257f5c5ee9812fe996337d2da6150947

commit c2e360d6257f5c5ee9812fe996337d2da6150947
Author:     Dmitry Wagin <dmitry.wagin@ya.ru>
AuthorDate: 2023-12-31 17:58:41 +0000
Commit:     Joel Bodenmann <jbo@FreeBSD.org>
CommitDate: 2024-01-07 15:14:10 +0000

    Mk/Uses/cargo.mk: Fix cargo-extract target

    Fix an issue where the cargo-extract target fails when a port sets DIST_SUBDIR.

    PR:                     275634
    Approved by:            tcberner (mentor), rust (tobik)
    Differential Revision:  https://reviews.freebsd.org/D43259

 Mk/Uses/cargo.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Joel Bodenmann freebsd_committer freebsd_triage 2024-01-07 15:58:08 UTC 
Committed - Thanks!