Bug 275648 - 13.2-RELEASE-p7 does not contain openzfs 2.1.14's "Zpool can start allocating from metaslab before TRIMs have completed" patch
Summary: 13.2-RELEASE-p7 does not contain openzfs 2.1.14's "Zpool can start allocating...
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 13.2-RELEASE
Hardware: Any Any
: --- Affects Many People
Assignee: Security Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-09 02:08 UTC by Mark Millard
Modified: 2024-02-12 18:20 UTC (History)
7 users (show)

See Also:
philip: needs_errata+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Millard 2023-12-09 02:08:17 UTC
vendor/openzfs/zfs-2.1-release contains the patch:

https://cgit.freebsd.org/src/commit/?h=vendor/openzfs/zfs-2.1-release&id=1ca531971f176ae7b8ca440e836985ae1d7fa0ec
("Zpool can start allocating from metaslab before TRIMs have completed")

But it was not merged into releng/13.2 with the other patch from
vendor/openzfs/zfs-2.1-release .
Comment 1 Mark Millard 2023-12-09 20:10:40 UTC
I probably should have noted that, by contrast, stable/13 got both parts
of 2.1.14 (including what releng/13.0 is missing). See:

https://cgit.freebsd.org/src/commit/?h=stable/13&id=f5eac65412786da4c764f86eb1514817889e9764
Comment 2 Mark Millard 2024-01-19 08:58:48 UTC
This was a report against 13.2-RLEASE-p7, not 14.0.

So why: "Blocks: 14.0-erratas"?


Also, with with 13.3 soon to be branched, 13.3 should likely
contain openzfs 2.1.14's "Zpool can start allocating from
metaslab before TRIMs have completed" patch.
Comment 3 Philip Paeps freebsd_committer freebsd_triage 2024-02-03 04:28:56 UTC
14.0 is not affected by this issue.  The fix was merged as part of d5a6a30019e4732361e015b8bb27fb4dfd32c6fd, before 14.0 was released.

We do need to issue an erratum for 13.2, however.
Comment 4 Philip Paeps freebsd_committer freebsd_triage 2024-02-03 04:54:24 UTC
13.3 is not affected by this either.  The releng/13.3 branch was created after this was merged to stable/13 as part of f5eac65412786da4c764f86eb1514817889e9764.
Comment 5 Mark Johnston freebsd_committer freebsd_triage 2024-02-12 16:43:01 UTC
Do we have any reports of users hitting this bug?  I ask because 1) 13.3 is coming out soon and isn't affected, and 2) backporting ZFS changes without careful testing and searches for follow-up bug fixes is risky and has bitten us in the past.
Comment 6 Xin LI freebsd_committer freebsd_triage 2024-02-12 18:19:31 UTC
+mm@ for visibility
Comment 7 Xin LI freebsd_committer freebsd_triage 2024-02-12 18:20:49 UTC
(and mav@)