Bug 275686 - devel/gbump: update to 1.1.1
Summary: devel/gbump: update to 1.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2023-12-11 09:25 UTC by nbari
Modified: 2023-12-16 18:21 UTC (History)
2 users (show)

See Also:


Attachments
gbump 1.1.1 patch (18.79 KB, patch)
2023-12-11 09:25 UTC, nbari
nbari: maintainer-approval+
Details | Diff
removed PORTREVISION (18.74 KB, patch)
2023-12-11 17:30 UTC, nbari
nbari: maintainer-approval+
Details | Diff
gbump 1.1.2 patch (18.77 KB, patch)
2023-12-15 13:00 UTC, nbari
nbari: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nbari 2023-12-11 09:25:13 UTC
Created attachment 246969 [details]
gbump 1.1.1 patch

Fixes SSL problem
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-11 16:36:02 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

Q/A: PORTREVISION should be removed (No need to update a new patch).
Comment 2 nbari 2023-12-11 16:57:05 UTC
Hi Fernando I don't have a changelog for this project main difference is that recently I just found that by adding this:

openssl = { version = "0.10", features = ["vendored"] } 

(vendored) 

fixes the SSL problem, but thanks for the heads up, I will add it for the other projects
Comment 3 nbari 2023-12-11 17:30:08 UTC
Created attachment 246986 [details]
removed PORTREVISION
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-13 07:47:37 UTC
This doesn't build for me, could you have a look?

  running cd "/wrkdirs/usr/ports/devel/gbump/work/target/x86_64-unknown-freebsd/release/build/openssl-sys-bf4e0c964a1f0810/out/openssl-build/build/src" && env -u CROSS_COMPILE AR="ar" CC="cc" RANLIB="ranlib" "perl" "./Configure" "--prefix=/wrkdirs/usr/ports/devel/gbump/work/target/x86_64-unknown-freebsd/release/build/openssl-sys-bf4e0c964a1f0810/out/openssl-build/install" "--openssldir=/usr/local/ssl" "no-dso" "no-shared" "no-ssl3" "no-tests" "no-comp" "no-zlib" "no-zlib-dynamic" "--libdir=lib" "no-md2" "no-rc5" "no-weak-ssl-ciphers" "no-camellia" "no-idea" "no-seed" "BSD-x86_64" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-O2" "-pipe" "-fstack-protector-strong" "-isystem" "/usr/local/include" "-fno-strict-aliasing"

  --- stderr
  thread 'main' panicked at /wrkdirs/usr/ports/devel/gbump/work/gbump-1.1.1/cargo-crates/openssl-src-300.2.0+3.2.0/src/lib.rs:611:9:



  Error configuring OpenSSL build:
      Command: cd "/wrkdirs/usr/ports/devel/gbump/work/target/x86_64-unknown-freebsd/release/build/openssl-sys-bf4e0c964a1f0810/out/openssl-build/build/src" && env -u CROSS_COMPILE AR="ar" CC="cc" RANLIB="ranlib" "perl" "./Configure" "--prefix=/wrkdirs/usr/ports/devel/gbump/work/target/x86_64-unknown-freebsd/release/build/openssl-sys-bf4e0c964a1f0810/out/openssl-build/install" "--openssldir=/usr/local/ssl" "no-dso" "no-shared" "no-ssl3" "no-tests" "no-comp" "no-zlib" "no-zlib-dynamic" "--libdir=lib" "no-md2" "no-rc5" "no-weak-ssl-ciphers" "no-camellia" "no-idea" "no-seed" "BSD-x86_64" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-O2" "-pipe" "-fstack-protector-strong" "-isystem" "/usr/local/include" "-fno-strict-aliasing"
      Failed to execute: No such file or directory (os error 2)


      
  stack backtrace:
     0: rust_begin_unwind
     1: core::panicking::panic_fmt
     2: openssl_src::Build::run_command
     3: openssl_src::Build::build
     4: build_script_main::find_vendored::get_openssl
     5: build_script_main::find_openssl
     6: build_script_main::main
     7: core::ops::function::FnOnce::call_once
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
warning: build failed, waiting for other jobs to finish...
*** Error code 101
Comment 5 nbari 2023-12-13 13:19:30 UTC
Hi, many thanks for checking out, this is how I am testing (working on my setup but maybe I only cover FreeBSD 14):

I installed poudriere using:

poudriere jail -c -j 14amd64 -v 14.0-RELEASE -a amd64

then I cd /usr/local/poudriere/ports/default/devel/gbump

there I fetch the patch:

fetch "https://bz-attachments.freebsd.org/attachment.cgi?id=246986&action=diff&format=raw&headers=1" -o patch

I apply the patch with:

patch -p1 < patch

And then run make stage:

===>  Staging for gbump-1.1.1
===>   Generating temporary packing list
  Installing gbump v1.1.1 (/usr/local/poudriere/ports/default/devel/gbump/work/gbump-1.1.1)
       Fresh jobserver v0.1.27
       Fresh cc v1.0.83
       Fresh pkg-config v0.3.27
       Fresh vcpkg v0.2.15
       Fresh openssl-src v300.2.0+3.2.0
warning: field `bin_dir` is never read
  --> /usr/local/poudriere/ports/default/devel/gbump/work/gbump-1.1.1/cargo-crates/openssl-src-300.2.0+3.2.0/src/lib.rs:28:5
   |
25 | pub struct Artifacts {
   |            --------- field in this struct
...
28 |     bin_dir: PathBuf,
   |     ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: `openssl-src` (lib) generated 1 warning
       Fresh unicode-ident v1.0.12
       Fresh tinyvec_macros v0.1.1
       Fresh utf8parse v0.2.1
       Fresh libc v0.2.151
       Fresh tinyvec v1.6.0
       Fresh anstyle-parse v0.2.3
       Fresh anstyle v1.0.4
       Fresh openssl-sys v0.9.97
       Fresh proc-macro2 v1.0.70
       Fresh unicode-normalization v0.1.22
       Fresh libz-sys v1.1.12
       Fresh percent-encoding v2.3.1
       Fresh memchr v2.6.4
       Fresh unicode-bidi v0.3.14
       Fresh quote v1.0.33
       Fresh anstyle-query v1.0.2
       Fresh colorchoice v1.0.0
       Fresh libssh2-sys v0.3.0
       Fresh aho-corasick v1.1.2
       Fresh form_urlencoded v1.2.1
       Fresh idna v0.5.0
       Fresh anstream v0.6.5
       Fresh syn v2.0.40
       Fresh foreign-types-shared v0.1.1
       Fresh regex-syntax v0.8.2
       Fresh clap_lex v0.6.0
       Fresh strsim v0.10.0
       Fresh bitflags v2.4.1
       Fresh openssl-macros v0.1.1
       Fresh regex-automata v0.4.3
       Fresh clap_builder v4.4.11
       Fresh foreign-types v0.3.2
       Fresh url v2.5.0
       Fresh libgit2-sys v0.16.1+1.7.1
       Fresh once_cell v1.19.0
       Fresh log v0.4.20
       Fresh cfg-if v1.0.0
       Fresh openssl-probe v0.1.5
       Fresh regex v1.10.2
       Fresh clap v4.4.11
       Fresh git2 v0.18.1
       Fresh openssl v0.10.61
       Fresh gbump v1.1.1 (/usr/local/poudriere/ports/default/devel/gbump/work/gbump-1.1.1)
    Finished release [optimized] target(s) in 0.02s
  Installing /usr/local/poudriere/ports/default/devel/gbump/work/stage/usr/local/bin/gbump
   Installed package `gbump v1.1.1 (/usr/local/poudriere/ports/default/devel/gbump/work/gbump-1.1.1)` (executable `gbump`)
warning: be sure to add `/usr/local/poudriere/ports/default/devel/gbump/work/stage/usr/local/bin` to your PATH to be able to run the installed binaries
====> Compressing man pages (compress-man)

# make package
===>  Building package for gbump-1.1.1

# make install
===>  Installing for gbump-1.1.1
===>  Checking if gbump is already installed
===>   Registering installation for gbump-1.1.1
Installing gbump-1.1.1...

# gbump --version
gbump 1.1.1

# make deinstall
===>  Deinstalling for gbump
===>   Deinstalling gbump-1.1.1
Updating database digests format: 100%
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
        gbump: 1.1.1

Number of packages to be removed: 1

The operation will free 6 MiB.
[1/1] Deinstalling gbump-1.1.1...
[1/1] Deleting files for gbump-1.1.1: 100%
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-14 11:37:17 UTC
Yes, but you are not actually using poudriere at all.

Have a look here on how to use it: https://docs.freebsd.org/en/books/porters-handbook/book/#testing-poudriere

It involves an invocation like:

poudriere testport -p myportstree -j myjail devel/gbump

or similar.

Cheers.
Comment 7 nbari 2023-12-14 21:41:38 UTC
Many thanks for sharing (owe you a beer) now need to find out how to fix this :D
Comment 8 nbari 2023-12-15 13:00:18 UTC
Created attachment 247059 [details]
gbump 1.1.2 patch
Comment 9 nbari 2023-12-15 13:03:49 UTC
It is working now, please help me check, meanwhile will fix other ports that I submitted.

What I did was to add this to Cargo.toml:

openssl = { version = "0.10", optional = true, features = ["vendored"] }

The optional = true did the trick
Comment 10 Mikael Urankar freebsd_committer freebsd_triage 2023-12-15 16:18:50 UTC
You can remove files/patch-powerpc
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-16 18:21:05 UTC
Committed,

Thanks!
Comment 12 commit-hook freebsd_committer freebsd_triage 2023-12-16 18:21:16 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4086c017849e85f4b9fe77d311a7b780869813a0

commit 4086c017849e85f4b9fe77d311a7b780869813a0
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2023-12-15 18:34:28 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-12-16 18:20:10 +0000

    devel/gbump: update to 1.1.1

    Removed unneeded patch.

    PR:             275686
    Reported by:    nbari@tequila.io
    Reviewed by:    mikael@

 devel/gbump/Makefile                   | 108 +++++++++++----------
 devel/gbump/distinfo                   | 168 ++++++++++++++++++++-------------
 devel/gbump/files/patch-powerpc (gone) |  50 ----------
 3 files changed, 159 insertions(+), 167 deletions(-)