Bug 275792 - net-mgmt/netdata: Update to v1.47.0
Summary: net-mgmt/netdata: Update to v1.47.0
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-16 19:04 UTC by Namkhai B.
Modified: 2024-09-04 02:47 UTC (History)
3 users (show)

See Also:
diizzy: maintainer-feedback+


Attachments
net-mgmt/netdata: Update to v1.44.1 (16.99 KB, patch)
2023-12-16 19:04 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.44.2 (19.61 KB, patch)
2024-02-07 17:08 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.44.3 (19.61 KB, patch)
2024-02-12 19:40 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.45.5 (87.79 KB, patch)
2024-05-26 18:02 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.45.6 (87.87 KB, patch)
2024-06-19 00:31 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.46.1 (94.42 KB, patch)
2024-06-21 20:20 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.46.2 (94.50 KB, patch)
2024-07-15 18:36 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.46.2 (94.49 KB, patch)
2024-07-16 17:49 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.46.3 (94.49 KB, patch)
2024-07-25 17:08 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.47.0 (96.72 KB, patch)
2024-08-24 19:29 UTC, Namkhai B.
no flags Details | Diff
net-mgmt/netdata: Update to v1.47.0 (96.80 KB, patch)
2024-09-04 02:47 UTC, Namkhai B.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Namkhai B. 2024-02-07 17:08:20 UTC
Created attachment 248237 [details]
net-mgmt/netdata: Update to v1.44.2
Comment 2 Namkhai B. 2024-02-12 19:40:18 UTC
Created attachment 248402 [details]
net-mgmt/netdata: Update to v1.44.3
Comment 3 Namkhai B. 2024-03-27 17:44:35 UTC
Working on the CMake switch right now
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-03-29 13:59:44 UTC
Sounds great, thanks!
Comment 6 Mohamed Akram 2024-05-10 10:19:01 UTC
Any update on this?
Comment 7 Namkhai B. 2024-05-11 01:10:18 UTC
(In reply to Mohamed Akram from comment #6)

We are still working on final details, see also https://github.com/netdata/netdata/issues/17632
Comment 8 Mohamed Akram 2024-05-11 09:09:33 UTC
Per that issue looks like it's using c-rbuf and c_rhash through mqtt_websockets. I imagine passing -DENABLE_MQTTWEBSOCKETS=ON fixes it - https://github.com/netdata/netdata/blob/v1.45.4/CMakeLists.txt#L1625 (that's what happens when H2O or ACLK are enabled). Or maybe the rbuf/rhash files can be moved from `MQTT_WEBSOCKETS_FILES` to `ACLK_ALWAYS_BUILD` as a patch in CMakeLists.txt since that's why they're needed if enabling MQTT websockets is not an option.
Comment 9 Namkhai B. 2024-05-16 22:42:51 UTC
Waiting on https://github.com/netdata/netdata/pull/17673 now (and potentially a v1.45.5 release)
Comment 10 Namkhai B. 2024-05-26 18:02:13 UTC
Created attachment 250991 [details]
net-mgmt/netdata: Update to v1.45.5
Comment 11 Jordan Ostreff 2024-06-07 12:17:01 UTC
I have successful build of 1.45.5 on freebsd stable/14 with small patches of provided diff. 

now I have both go.d and god.d plugins running :( 

Anyway netdata works somehow.
Comment 12 Jordan Ostreff 2024-06-07 12:20:36 UTC
In my situation
14888  -  IN        0:12,70 /usr/local/sbin/netdata -P /var/db/netdata/netdata.pid
14890  -  IN        0:00,03 /usr/local/sbin/netdata --special-spawn-server
14936  -  IN        0:03,47 /usr/local/libexec/netdata/plugins.d/go.d.plugin 1
14938  -  SN        0:00,94 /usr/local/libexec/netdata/plugins.d/apps.plugin 1
14939  -  SN        0:01,35 /usr/local/bin/python3.11 /usr/local/libexec/netdata/plugins.d/pyt
14942  -  IN        0:01,38 /usr/local/libexec/netdata/plugins.d/god.plugin 1


# pkg which /usr/local/libexec/netdata/plugins.d/god.plugin
/usr/local/libexec/netdata/plugins.d/god.plugin was installed by package netdata-go-0.58.1_4

# pkg which /usr/local/libexec/netdata/plugins.d/go.d.plugin
/usr/local/libexec/netdata/plugins.d/go.d.plugin was installed by package netdata-1.45.5


maybe it's time to deinstall netdata-go-0.58.1_4?
Comment 13 Jordan Ostreff 2024-06-10 10:04:16 UTC
new defect of the port:

# /usr/local/libexec/netdata/plugins.d/alarm-notify.sh test

# SENDING TEST WARNING ALARM TO ROLE: sysadmin
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
# OK

# SENDING TEST CRITICAL ALARM TO ROLE: sysadmin
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
# OK

# SENDING TEST CLEAR ALARM TO ROLE: sysadmin
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
# OK
Comment 14 Namkhai B. 2024-06-19 00:31:38 UTC
Created attachment 251553 [details]
net-mgmt/netdata: Update to v1.45.6

Added back systemd-cat-native as it seems to be required by some modules.
Updated to v1.45.6, runtime looks OK
Comment 15 Namkhai B. 2024-06-21 20:20:22 UTC
Created attachment 251609 [details]
net-mgmt/netdata: Update to v1.46.1
Comment 16 Mohamed Akram 2024-07-15 14:00:21 UTC
Anything blocking this?
Comment 17 Namkhai B. 2024-07-15 18:36:24 UTC
Created attachment 252085 [details]
net-mgmt/netdata: Update to v1.46.2
Comment 18 Namkhai B. 2024-07-15 18:36:58 UTC
Waiting on a review from Daniel, but he is currently busy.
Comment 19 Jordan Ostreff 2024-07-16 10:17:07 UTC
(In reply to Namkhai B. from comment #17)
Hi,
I will be really grateful to your work. Can you suggest to me fastest way to test your proposed change inside my ports tree? 
Currently I'm running metadata 1.46.1 which was your previous patch, but with new version after git restore net-mgmt/netdata I can't apply with patch -p1 < {your-patch} correctly.
Comment 20 Namkhai B. 2024-07-16 17:49:04 UTC
Created attachment 252110 [details]
net-mgmt/netdata: Update to v1.46.2

Rebased patch over the latest ports tree
Comment 21 Jordan Ostreff 2024-07-17 09:12:30 UTC
(In reply to Namkhai B. from comment #20)
I confirm that provided patch was applied fine on main /usr/ports tree.
Comment 22 Jordan Ostreff 2024-07-17 09:12:48 UTC
(In reply to Namkhai B. from comment #20)
I confirm that provided patch was applied fine on main /usr/ports tree.
Comment 23 Namkhai B. 2024-07-25 17:08:10 UTC
Created attachment 252282 [details]
net-mgmt/netdata: Update to v1.46.3
Comment 24 Jordan Ostreff 2024-08-11 10:22:20 UTC
(In reply to Namkhai B. from comment #23)
I confirm that provided patch was applied fine on main /usr/ports tree.
Comment 25 Jordan Ostreff 2024-08-11 10:22:28 UTC
(In reply to Namkhai B. from comment #23)
I confirm that provided patch was applied fine on main /usr/ports tree.
Comment 26 Jordan Ostreff 2024-08-24 12:09:05 UTC
anything developed for 1.47.0?
Comment 27 Namkhai B. 2024-08-24 19:29:23 UTC
Created attachment 253063 [details]
net-mgmt/netdata: Update to v1.47.0

Preliminary v1.47.0 patch, runtime looks OK so far
Comment 28 Namkhai B. 2024-09-04 02:47:18 UTC
Created attachment 253314 [details]
net-mgmt/netdata: Update to v1.47.0

Added setuid bit needed by freeipmi.plugin