# mail root Subject: ^C ^CBus error
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=6c951b37170f1fb2ae8b4827070743e61b6eaed2 commit 6c951b37170f1fb2ae8b4827070743e61b6eaed2 Author: Lexi Winter <lexi@le-Fay.ORG> AuthorDate: 2024-01-04 22:34:58 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-01-05 02:40:53 +0000 mail: add volatile in grabh() setjmp() requires that any stack variables modified between the setjmp call and the longjmp() must be volatile. This means that 'saveint' in grabh() must be volatile, since it's modified after the setjmp(). Otherwise, the signal handler is not properly restored, resulting in a crash (SIGBUS) if ^C is typed twice while composing. PR: 276119 Reported by: Christopher Davidson <christopher.davidson@gmail.com> MFC after: 2 weeks Pull Request: https://github.com/freebsd/freebsd-src/pull/993 usr.bin/mail/tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
^Triage: assign to committer that resolved.
A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=f2ad8d3a1397660127f22ba9c0785ef4122a8ba5 commit f2ad8d3a1397660127f22ba9c0785ef4122a8ba5 Author: Lexi Winter <lexi@le-Fay.ORG> AuthorDate: 2024-01-04 22:34:58 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-01-19 14:25:05 +0000 mail: add volatile in grabh() setjmp() requires that any stack variables modified between the setjmp call and the longjmp() must be volatile. This means that 'saveint' in grabh() must be volatile, since it's modified after the setjmp(). Otherwise, the signal handler is not properly restored, resulting in a crash (SIGBUS) if ^C is typed twice while composing. PR: 276119 Reported by: Christopher Davidson <christopher.davidson@gmail.com> MFC after: 2 weeks Pull Request: https://github.com/freebsd/freebsd-src/pull/993 (cherry picked from commit 6c951b37170f1fb2ae8b4827070743e61b6eaed2) usr.bin/mail/tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=6d78f3a6310d0f873a8515541e6fbf62ef7237d6 commit 6d78f3a6310d0f873a8515541e6fbf62ef7237d6 Author: Lexi Winter <lexi@le-Fay.ORG> AuthorDate: 2024-01-04 22:34:58 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-01-19 14:26:53 +0000 mail: add volatile in grabh() setjmp() requires that any stack variables modified between the setjmp call and the longjmp() must be volatile. This means that 'saveint' in grabh() must be volatile, since it's modified after the setjmp(). Otherwise, the signal handler is not properly restored, resulting in a crash (SIGBUS) if ^C is typed twice while composing. PR: 276119 Reported by: Christopher Davidson <christopher.davidson@gmail.com> MFC after: 2 weeks Pull Request: https://github.com/freebsd/freebsd-src/pull/993 (cherry picked from commit 6c951b37170f1fb2ae8b4827070743e61b6eaed2) usr.bin/mail/tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the patch.