Bug 276259 - Mk/*: unconditionally use .MAKE.UID and .MAKE.GID
Summary: Mk/*: unconditionally use .MAKE.UID and .MAKE.GID
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-11 15:13 UTC by Christian Weisgerber
Modified: 2024-01-15 17:50 UTC (History)
3 users (show)

See Also:

Attachments
unconditionally use .MAKE.UID and .MAKE.GID (1.72 KB, patch)
2024-01-11 15:13 UTC, Christian Weisgerber 		arrowd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Weisgerber freebsd_committer freebsd_triage 2024-01-11 15:13:52 UTC 
Created attachment 247596 [details]
unconditionally use .MAKE.UID and .MAKE.GID

Since FreeBSD 12 has been EOLed, the built-in make(1) variables .MAKE.UID and .MAKE.GID are always available.
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2024-01-11 17:50:54 UTC 
The change looks OK.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-01-15 16:18:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fe3392ed8d428ccb922ea60097e4cac7c95ad07a

commit fe3392ed8d428ccb922ea60097e4cac7c95ad07a
Author:     Christian Weisgerber <naddy@FreeBSD.org>
AuthorDate: 2024-01-11 14:53:35 +0000
Commit:     Christian Weisgerber <naddy@FreeBSD.org>
CommitDate: 2024-01-15 16:17:05 +0000

    Mk/*: unconditionally use .MAKE.UID and .MAKE.GID

    Since FreeBSD 12 has been EOLed, the built-in make(1) variables
    .MAKE.UID and .MAKE.GID are always available.

    PR:             276259
    Approved by:    arrowd

 Mk/Uses/uidfix.mk     | 4 +---
 Mk/bsd.port.mk        | 8 +-------
 Mk/bsd.port.subdir.mk | 4 +---
 3 files changed, 3 insertions(+), 13 deletions(-)
Comment 3 Craig Leres freebsd_committer freebsd_triage 2024-01-15 17:50:49 UTC 
While this is a good change to make, poudriere sets UID in the environment:

zinc 201 # poudriere bulk -i -j 13release -p current ports-mgmt/pkg
[00:00:00] Creating the reference jail... done
[...]
[00:00:12] Entering interactive test mode. Type 'exit' when done.
nobody@zinc:/usr/ports/ports-mgmt/pkg % cd /usr/ports/ports-mgmt/pkg
nobody@zinc:/usr/ports/ports-mgmt/pkg % make -V UID
0
nobody@zinc:/usr/ports/ports-mgmt/pkg % make -V .MAKE.UID
65534