Bug 276736 - [NEW PORT] www/tomcat-native2
Summary: [NEW PORT] www/tomcat-native2
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Osipov
URL: https://reviews.freebsd.org/D44824
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-30 18:37 UTC by Jonathan Chen
Modified: 2024-04-18 04:35 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ale)

Attachments
1.2.38 -> 2.0.6 git-diff (1.55 KB, patch)
2024-01-30 18:37 UTC, Jonathan Chen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Chen 2024-01-30 18:37:54 UTC 
Created attachment 248082 [details]
1.2.38 -> 2.0.6 git-diff

Update to 2.0.6
Comment 1 Michael Osipov freebsd_committer freebsd_triage 2024-01-30 21:03:14 UTC 
No, this must be a separate port, not an upgrade. There is no technical benefit, but has one HUGE drawback: It does not contain the APR connector anymore and may break for people.

Please explain what you expect from version 2?

PS: I am a Tomcat committer
Comment 2 Jonathan Chen 2024-01-31 02:19:00 UTC 
Just one less warning from the Tomcat 10.1 console complaining about older versions, ie:

31-Jan-2024 07:24:24.963 INFO [main] org.apache.catalina.core.AprLifecycleListener.lifecycleEvent An older version [1.2.38] of the Apache Tomcat Native library is installed, while
Tomcat recommends a minimum version of [2.0.5]
Comment 3 Michael Osipov freebsd_committer freebsd_triage 2024-01-31 08:25:35 UTC 
(In reply to Jonathan Chen from comment #2)

That applies to any Tomcat Native version is is too old, not just 1 or 2.
Both shared libraries have distinct names and can be used side by side.
Comment 4 Michael Osipov freebsd_committer freebsd_triage 2024-01-31 12:01:00 UTC 
One needs to create a master port www/tomcat-native-common and www/tomcat-native and www/tomcat-native2 can point to it.
Comment 5 Michael Osipov freebsd_committer freebsd_triage 2024-02-06 12:26:39 UTC 
Attn: Tomcat Native 1.3.x will be resoved this month: https://lists.apache.org/thread/pxvnzoxvs0dwqvkhgnxv1w054q0tlmdp. It will supersede 1.2.x. for 9.0+ after 8.5.x has gone EOL.
Comment 6 John Roth 2024-04-17 04:36:09 UTC 
(In reply to Michael Osipov from comment #5)
Thank you for sharing the information about Tomcat Native 1.3.x. According to the provided URL, it appears that there is a discussion thread related to this topic on the Apache mailing list
Comment 7 John Roth 2024-04-17 04:40:56 UTC 
(In reply to Michael Osipov from comment #5 Attn: Tomcat Native 1.3.x will be resoved this month: https://lists.apache.org/thread/pxvnzoxvs0dwqvkhgnxv1w054q0tlmdp https://uno-online.io. It will supersede 1.2.x. for 9.0+ after 8.5.x has gone EOL.)

What are the key features or improvements in Tomcat Native 1.3.x compared to 1.2.x?
Comment 8 Michael Osipov freebsd_committer freebsd_triage 2024-04-17 06:41:43 UTC 
(In reply to John Roth from comment #7)

Except for the few fixes I have added it sports solely a raise in build requirements which do not apply for FreeBSD because we have the lastest APR/OpenSSL/LibreSSL, see https://github.com/apache/tomcat-native/compare/1.2.x...1.3.x#diff-67251169106d0b00b8d20d0706735551e276018519b89b6cb6214f3241181ce7
Comment 9 Michael Osipov freebsd_committer freebsd_triage 2024-04-17 07:35:56 UTC 
I wouldn't mind creating www/tomcat-native and be the maintainer since I truly maintain it with others unless ale@ wants to take ownership.
Comment 10 Alex Dupre freebsd_committer freebsd_triage 2024-04-17 07:55:34 UTC 
(In reply to Michael Osipov from comment #9)
You can take it, no objections.
Comment 11 Michael Osipov freebsd_committer freebsd_triage 2024-04-17 07:56:45 UTC 
(In reply to Alex Dupre from comment #10)

Should I also take over www/tomcat-native?
Comment 12 Alex Dupre freebsd_committer freebsd_triage 2024-04-17 07:58:10 UTC 
(In reply to Michael Osipov from comment #11)
If you like, yes, I don't actually use it anymore.
Comment 13 Michael Osipov freebsd_committer freebsd_triage 2024-04-17 07:59:49 UTC 
(In reply to Alex Dupre from comment #12)

Will do.
Comment 14 Michael Osipov freebsd_committer freebsd_triage 2024-04-17 10:20:47 UTC 
Working on the port, but will need some time because I need dynamically exclude OpenSSL 1.1.1 since it is not supported anymore.
Comment 15 Michael Osipov freebsd_committer freebsd_triage 2024-04-17 10:22:59 UTC 
Dev branch: https://github.com/michael-o/freebsd-ports/tree/pr-276736
Comment 16 Michael Osipov freebsd_committer freebsd_triage 2024-04-17 13:28:09 UTC 
Jon, please test the review in your setup: https://reviews.freebsd.org/D44824
Comment 17 Jonathan Chen 2024-04-18 04:35:02 UTC 
(In reply to Michael Osipov from comment #16)

Works for me.