Bug 276821 - devel/kf6-extra-cmake-modules: packaging fails with all options off
Summary: devel/kf6-extra-cmake-modules: packaging fails with all options off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
: 275595 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-02-04 11:39 UTC by Anton Saietskii
Modified: 2024-03-22 20:40 UTC (History)
3 users (show)

See Also:
arrowd: maintainer-feedback+


Attachments
poudriere packaging failure log (9.45 KB, application/x-xz)
2024-02-04 11:40 UTC, Anton Saietskii
no flags Details
v0 (23.61 KB, patch)
2024-02-04 11:52 UTC, Anton Saietskii
no flags Details | Diff
poudriere build log with patch applied (8.89 KB, application/x-xz)
2024-02-04 11:56 UTC, Anton Saietskii
no flags Details
v1 (apply via `git am`) (15.36 KB, patch)
2024-03-20 22:03 UTC, Anton Saietskii
no flags Details | Diff
poudriere testport log (all options ON) (11.46 KB, application/x-xz)
2024-03-20 22:06 UTC, Anton Saietskii
no flags Details
poudriere testport log (all options OFF) (5.76 KB, application/x-xz)
2024-03-20 22:07 UTC, Anton Saietskii
no flags Details
v2 (apply via `git am`) (15.36 KB, application/mbox)
2024-03-21 13:54 UTC, Anton Saietskii
vsasjason: maintainer-approval?
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2024-02-04 11:39:23 UTC
Snip:
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/kf6-extra-cmake-modules/work/stage/usr/local/share/doc/ECM/html/search.html:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/kf6-extra-cmake-modules/work/stage/usr/local/share/doc/ECM/html/searchindex.js:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/kf6-extra-cmake-modules/work/stage/usr/local/share/doc/ECM/html/toolchain/Android.html:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/kf6-extra-cmake-modules/work/stage/usr/local/share/man/man7/ecm-developer.7.gz:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/kf6-extra-cmake-modules/work/stage/usr/local/share/man/man7/ecm-find-modules.7.gz:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/kf6-extra-cmake-modules/work/stage/usr/local/share/man/man7/ecm-kde-modules.7.gz:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/kf6-extra-cmake-modules/work/stage/usr/local/share/man/man7/ecm-modules.7.gz:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/kf6-extra-cmake-modules/work/stage/usr/local/share/man/man7/ecm-toolchains.7.gz:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/kf6-extra-cmake-modules/work/stage/usr/local/share/man/man7/ecm.7.gz:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/kf6-extra-cmake-modules

Looks like we need conditionals in plist.
Comment 1 Anton Saietskii 2024-02-04 11:40:06 UTC
Created attachment 248177 [details]
poudriere packaging failure log
Comment 2 Anton Saietskii 2024-02-04 11:52:49 UTC
Created attachment 248178 [details]
v0

Moved:
* share/man/... to %%MANPAGES%%
* share/doc/... to %%DOCS%%
 
Unsure what files are being generated by HELP option though, this is why patch is ugly.
Comment 3 Anton Saietskii 2024-02-04 11:56:01 UTC
Created attachment 248179 [details]
poudriere build log with patch applied

With patch from file #248178 and all options still disabled, packaging succeeds.

Additionally, I noticed couple of warnings:
====> Running Q/A tests (stage-qa)
Warning: you might not need LIB_DEPENDS on libQt6Core.so

===>   Registering installation for kf6-extra-cmake-modules-5.248.0_1
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:13:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?
Comment 4 Anton Saietskii 2024-03-20 22:03:24 UTC
Created attachment 249350 [details]
v1 (apply via `git am`)

I was bored and thought -- why not fix it myself? So, here's updated patch with lots of issues fixed (I'm not sure if this everything, but at least no linters complain now).

Adriaan, your prompt attention to committing this patch would be highly valued.
Comment 5 Anton Saietskii 2024-03-20 22:06:12 UTC
Created attachment 249351 [details]
poudriere testport log (all options ON)
Comment 6 Anton Saietskii 2024-03-20 22:07:59 UTC
Created attachment 249352 [details]
poudriere testport log (all options OFF)
Comment 7 Anton Saietskii 2024-03-21 13:54:18 UTC
Created attachment 249373 [details]
v2 (apply via `git am`)

Removed USE_QT=base, it's not needed.
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-03-22 20:21:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4ae57550eff8ceec265401f37a1fa738d0b73bc1

commit 4ae57550eff8ceec265401f37a1fa738d0b73bc1
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2024-03-22 20:17:51 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-03-22 20:19:26 +0000

    devel/kf6-extra-cmake-modules: Multiple fixes

    - Add LICENSE
    - Fix packaging with different OPTIONS
    - Add testing

    PR:             276821
    Based on patch from:    Anton Saietskii <vsasjason@gmail.com>

 devel/kf6-extra-cmake-modules/Makefile  |  29 +++--
 devel/kf6-extra-cmake-modules/pkg-plist | 208 ++------------------------------
 2 files changed, 26 insertions(+), 211 deletions(-)
Comment 9 Gleb Popov freebsd_committer freebsd_triage 2024-03-22 20:21:58 UTC
Hi Anton, thanks for the patch. I fixed these issues on my own and a bit differently, but your patch was nevertheless useful and I mined a lot of knowledge from it.
Comment 10 Gleb Popov freebsd_committer freebsd_triage 2024-03-22 20:40:59 UTC
*** Bug 275595 has been marked as a duplicate of this bug. ***