Created attachment 248433 [details] d43861 ocaml 4.14.1 tree wide update, rebased on main Hello, I'd like to request an exp-run of the tree-wide patch to bring ocaml to 4.14.1 from D43861 . I got in touch with madpilot who suggested to request an exp run. I've reached to other maintainers on already open bugs, and invited them to review the phabricator revision. The attached patch is in all aspect identical to https://reviews.freebsd.org/D43861 only rebased on main as of a couple minutes ago to avoid the chance of a merge conflict to the category level Makefile, as a couple of new ports are added by the patch. Please let me know if any more information is warranted. I'm for sure very curious to see how it turns out :) On my builder, it does for sure seem to work solid, but it is certainly possible that I have overloooked something as I only build the 93 packages (and their dependencies) that I've identified as possibly affected. Or that I've missed an OPTIONS, who knows? Thanks, Benjamin
Exp-run can't start: Error: Duplicated origin for ocaml-4.14.1: lang/ocaml-nox11 AND lang/ocaml.
Created attachment 248477 [details] d43861 ocaml 4.14.1 tree wide update, rebased on main + pkgnamesuffix fix Fixed patch. I had already removed "PKGNAMESUFFIX= ${SFX}" from lang/ocaml in anticipation of the removal of lang/ocaml-nox11 (as lang/ocaml doesn't depend on x11 anymore), however the removal lang/ocaml-x11 is not part of that revision, it will be best handled separately and subsequently. Fixed by re-adding PKGNAMESUFFIX= ${SFX} to the master port. Is it possible to have a new try with the updated patch?
Created attachment 248669 [details] D43861 rebased Patch refreshed and rebased, based on latest review version.
Created attachment 248676 [details] D43861 patch updated for lablgtk2 regression
Please hold on, I will post a rebased patch including another regression fix ASAP.
Created attachment 248844 [details] D43861.diff
(In reply to Benjamin Jacobs from comment #6) SETENVI should be used instead of SETENV in the new USES=dune Ports using custom do-build or do-install should respect MAKE_ENV too
(In reply to Antoine Brodin from comment #7) You are right on both issues. I'll post a new patch addressing those later today. I don't expect it to change the exp-run result. Thanks!
Created attachment 248847 [details] D43861.diff (In reply to Antoine Brodin from comment #7) Revision updated addressing those issues.
Created attachment 248874 [details] D43861.diff Fixed one build and one plist issue, patch synced to review. It should hopefully be golden this time...
Exp-run seems fine.
Patch committed. Thanks all!