Bug 277226 - net/miniupnpd: duplicate mappings, corrupted replies to clients
Summary: net/miniupnpd: duplicate mappings, corrupted replies to clients
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-22 20:50 UTC by Serge
Modified: 2024-05-06 07:15 UTC (History)
10 users (show)

See Also:
bugzilla: maintainer-feedback? (squat)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Serge 2024-02-22 20:50:01 UTC 
Originally discovered in OPNSense: https://github.com/opnsense/plugins/issues/3831.
See also https://forum.opnsense.org/index.php?topic=38732.0.

OPNsense 24.1.2_1-amd64
FreeBSD 13.2-RELEASE-p10
OpenSSL 3.0.13
miniupnpd 2.3.3

Over time, duplicate mappings like this are created:

```
62852	tcp	10.0.0.87	6690	upnpclient:6690
62852	tcp	10.0.0.87	6690	upnpclient:6690
62852	tcp	10.0.0.87	6690	upnpclient:6690
```

If you try to get the mapping list using miniupnpc, it returns corrupted results:

```
i protocol exPort->inAddr:inPort description remoteHost leaseTime
 0 UDP     0->10.0.0.87:0     '' '34.26.0.0' 0
 1 UDP     0->10.0.0.87:0     '' '34.26.0.0' 0
 2 UDP     0->10.0.0.87:0     '' '34.26.0.0' 0
```
Comment 1 roylaprattep 2024-02-22 22:38:55 UTC 
+1 here.
Comment 2 Franco Fichtner 2024-02-23 08:31:44 UTC 
There is definitely breakage here since https://github.com/freebsd/freebsd-ports/commit/81e8bb9834
Comment 3 boian_valentinov 2024-03-12 09:21:00 UTC 
+1 here
Comment 4 udingmyride 2024-03-15 21:27:59 UTC 
+1 here
Comment 5 xpendable 2024-04-15 15:13:03 UTC 
This issue has been resolved upstream: https://github.com/miniupnp/miniupnp/issues/719

Please update this FreeBSD port to the latest version in order to resolve this issue.

Also just a thought/question... shouldn't this be a part of a CI/CD process so that when the source gets updated the FreeBSD port also gets updated automatically?
Comment 6 AhnHEL 2024-04-20 17:54:12 UTC 
Bumping +1 please.
Comment 7 AlpAne 2024-05-06 07:15:47 UTC 
Another bump, +1! Please fix this one as soon as possible since it would improve quality of life for all users of UPNP.

Thanks in advance!