Bug 277329 - SA-24:02.tty causes kernel panic
Summary: SA-24:02.tty causes kernel panic
Status: Closed DUPLICATE of bug 277240
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: --- Affects Some People
Assignee: Ed Maste
URL:
Keywords: crash
Depends on:
Blocks:
 
Reported: 2024-02-26 12:39 UTC by Lars Herschke
Modified: 2024-03-28 05:08 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Herschke 2024-02-26 12:39:34 UTC
The error does not occur with the default /etc/ttys. However, I have set ttyv0 to off. Then you can provoke the crash in a stable way by calling sysctl -A

<kern.crit> dsspkg kernel
<kern.crit> dsspkg syslogd last message repeated 1 times
<kern.crit> dsspkg kernel Fatal trap 12: page fault while in kernel mode
<kern.crit> dsspkg kernel cpuid = 39; apic id = 39
<kern.crit> dsspkg kernel fault virtual address = 0x140
<kern.crit> dsspkg kernel fault code            = supervisor write data, page not present
<kern.crit> dsspkg kernel instruction pointer   = 0x20:0xffffffff80be7401
<kern.crit> dsspkg kernel stack pointer         = 0x28:0xfffffe05d11d5b90
<kern.crit> dsspkg kernel frame pointer         = 0x28:0xfffffe05d11d5bd0
<kern.crit> dsspkg kernel code segment          = base rx0, limit 0xfffff, type 0x1b
<kern.crit> dsspkg kernel                       = DPL 0, pres 1, long 1, def32 0, gran 1
<kern.crit> dsspkg kernel processor eflags      = interrupt enabled, resume, IOPL = 0
<kern.crit> dsspkg kernel current process               = 86235 (sysctl)
<kern.crit> dsspkg kernel rdi: fffff801070bcc00 rsi: fffff8035ca9fc00 rdx: 0000000000000000
Comment 1 Ed Maste freebsd_committer freebsd_triage 2024-02-26 16:04:50 UTC

*** This bug has been marked as a duplicate of bug 277240 ***
Comment 2 Ed Maste freebsd_committer freebsd_triage 2024-02-26 16:17:04 UTC
Thank you for the /etc/ttys info - this crash was also reported in PR277240 but I wasn't able to reproduce it without the detail you provided. I have a fix in review at https://reviews.freebsd.org/D44086 - if it's convenient for you please give that a test.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-02-26 20:14:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=975d7730828a8bde28c2a0092b6e95c4c4e22f34

commit 975d7730828a8bde28c2a0092b6e95c4c4e22f34
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-02-26 15:38:45 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-02-26 20:11:27 +0000

    kern: fix panic with disabled ttys

    PR: 277240, 277329
    Reviewed by: kib (earlier version)
    Fixes: f1d0a0cbecf2 ("jail: Fix information leak.")
    MFC after: 3 days
    Sponsored by: The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D44086

 sys/kern/tty.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 4 Lars Herschke 2024-02-27 13:02:23 UTC
I have no more crashes with a new kernel that contains the patch.
Comment 5 Ed Maste freebsd_committer freebsd_triage 2024-02-27 14:29:44 UTC
(In reply to Lars Herschke from comment #4)
Great, thanks again.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-02-29 00:30:47 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=8d22744f5be165a2a82a2a204789e44bbdc5a2ee

commit 8d22744f5be165a2a82a2a204789e44bbdc5a2ee
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-02-26 15:38:45 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-02-29 00:29:13 +0000

    kern: fix panic with disabled ttys

    PR: 277240, 277329
    Reviewed by: kib (earlier version)
    Fixes: f1d0a0cbecf2 ("jail: Fix information leak.")
    MFC after: 3 days
    Sponsored by: The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D44086

    (cherry picked from commit 975d7730828a8bde28c2a0092b6e95c4c4e22f34)

 sys/kern/tty.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-02-29 00:31:48 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a60220bbb5511469fe53fd4290713ba891f8f48a

commit a60220bbb5511469fe53fd4290713ba891f8f48a
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-02-26 15:38:45 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-02-29 00:30:12 +0000

    kern: fix panic with disabled ttys

    PR: 277240, 277329
    Reviewed by: kib (earlier version)
    Fixes: f1d0a0cbecf2 ("jail: Fix information leak.")
    MFC after: 3 days
    Sponsored by: The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D44086

    (cherry picked from commit 975d7730828a8bde28c2a0092b6e95c4c4e22f34)
    (cherry picked from commit 8d22744f5be165a2a82a2a204789e44bbdc5a2ee)

 sys/kern/tty.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-02-29 13:18:15 UTC
A commit in branch releng/13.3 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=814761540eb9d1e52d6210bf0468d379a9459be9

commit 814761540eb9d1e52d6210bf0468d379a9459be9
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-02-26 15:38:45 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-02-29 13:16:47 +0000

    kern: fix panic with disabled ttys

    PR: 277240, 277329
    Reviewed by: kib (earlier version)
    Fixes: f1d0a0cbecf2 ("jail: Fix information leak.")
    MFC after: 3 days
    Sponsored by: The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D44086

    (cherry picked from commit 975d7730828a8bde28c2a0092b6e95c4c4e22f34)
    (cherry picked from commit 8d22744f5be165a2a82a2a204789e44bbdc5a2ee)
    (cherry picked from commit a60220bbb5511469fe53fd4290713ba891f8f48a)

    Approved by:    re (cperciva)

 sys/kern/tty.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-03-28 05:07:25 UTC
A commit in branch releng/14.0 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a3ec3054762f0e7bf2381a7939e62c5e43fde935

commit a3ec3054762f0e7bf2381a7939e62c5e43fde935
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-02-26 15:38:45 +0000
Commit:     Gordon Tetlow <gordon@FreeBSD.org>
CommitDate: 2024-03-28 03:12:16 +0000

    kern: fix panic with disabled ttys

    PR: 277240, 277329
    Reviewed by: kib (earlier version)
    Fixes: f1d0a0cbecf2 ("jail: Fix information leak.")
    MFC after: 3 days
    Sponsored by: The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D44086
    Approved by:    so
    Security:       FreeBSD-EN-24:05.tty

    (cherry picked from commit 975d7730828a8bde28c2a0092b6e95c4c4e22f34)
    (cherry picked from commit 8d22744f5be165a2a82a2a204789e44bbdc5a2ee)

 sys/kern/tty.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-03-28 05:08:33 UTC
A commit in branch releng/13.2 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=f3195cc08ccc99365ec00900a3c1abc59ceefc9c

commit f3195cc08ccc99365ec00900a3c1abc59ceefc9c
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-02-26 15:38:45 +0000
Commit:     Gordon Tetlow <gordon@FreeBSD.org>
CommitDate: 2024-03-28 03:05:12 +0000

    kern: fix panic with disabled ttys

    PR: 277240, 277329
    Reviewed by: kib (earlier version)
    Fixes: f1d0a0cbecf2 ("jail: Fix information leak.")
    MFC after: 3 days
    Sponsored by: The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D44086
    Approved by:    so
    Security:       FreeBSD-EN-24:05.tty

    (cherry picked from commit 975d7730828a8bde28c2a0092b6e95c4c4e22f34)
    (cherry picked from commit 8d22744f5be165a2a82a2a204789e44bbdc5a2ee)
    (cherry picked from commit a60220bbb5511469fe53fd4290713ba891f8f48a)

 sys/kern/tty.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)