Created attachment 248787 [details] port upgrade The port for the current version (1.07) points to the upstream which no longer exists. Also the port has no maintainer. The attached patch points to my own github fork and adds me as a port maintainer.
Created attachment 248788 [details] port upgrade new version of the patch, uses DISTVERSION not PORTVERSION
Hi and thanks for your contribution! First I have a question: Did you attempt to contact the original upstream maintainer? If not, could you please do so? I think it's important because otherwise, it's unclear whether "wmctrl-1.09" would refer to your fork or maybe to some other fork. If the original upstream maintainer isn't available, or unwilling to pass upstream maintainership, I'd very much prefer a different name (maybe just adding some prefix or suffix) to avoid any confusion. Or maybe as another option, host the original distfile somewhere along with a patch to make it work (and then of course keep the version at 1.07). This aside, you probably want to clean your github fork from all GNU autotools generated files. To avoid having to use USES=autoreconf, the best option is to generate an actual disfile (IIRC GNU autotools supports "make dist" for that) and upload it to a release on github ... thus also avoiding the need for USE_GITHUB=yes. Finally, at a first glance, please don't add to variables when not needed, like here: USE_XORG= x11 xmu xext xt USE_XORG+= ice USE_XORG+= sm The correct way would be USE_XORG= ice sm x11 xext xmu xt (alphabetically sorted)
I did not try to contact the original upstream author. I have sent an email now, let's see what is the result.
Ok, I got a rejection from postmaster@. I will try to find the author, though.
(In reply to Alexey Vyskubov from comment #4) Thanks for the effort. In the case the author disappeared, I think starting your own fork is indeed the best thing to do for keeping it alive. Just as I said, please do something with the name in that case to avoid any possible confusion. The port can then be renamed as well with an appropriate entry in MOVED.
Hello again, I have tried to reach the upstream author using different channels, but failed. I attach the new patch which hopefully takes your comments into account. Please have a look.
Created attachment 250790 [details] New patch for ports tree.
(In reply to Alexey Vyskubov from comment #7) testbuilds@work
(In reply to Kurt Jaeger from comment #8) testbuilds look fine.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f4eb5cbd9c5087eed36da918f15ba04702004352 commit f4eb5cbd9c5087eed36da918f15ba04702004352 Author: Alexey Vyskubov <alexey@pentode.fi> AuthorDate: 2024-06-18 19:30:16 +0000 Commit: Kurt Jaeger <pi@FreeBSD.org> CommitDate: 2024-06-18 19:30:16 +0000 x11/wmctrl: upstream no longer exists - submitter provided fork with updates - MOVED points to new version PR: 277348 Reviewed: zirias MOVED | 1 + x11/wmctrl-fork/Makefile (new) | 21 ++++++++++++ x11/wmctrl-fork/distinfo (new) | 3 ++ x11/{wmctrl => wmctrl-fork}/pkg-descr | 0 x11/wmctrl/Makefile (gone) | 21 ------------ x11/wmctrl/distinfo (gone) | 2 -- x11/wmctrl/files/patch-main.c (gone) | 61 ----------------------------------- 7 files changed, 25 insertions(+), 84 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cf73e220c56a4987321c99f609c176cf41f07389 commit cf73e220c56a4987321c99f609c176cf41f07389 Author: Alexey Vyskubov <alexey@pentode.fi> AuthorDate: 2024-06-19 04:25:41 +0000 Commit: Kurt Jaeger <pi@FreeBSD.org> CommitDate: 2024-06-19 04:25:41 +0000 x11/Makefile: fix for x11/wmctrl-fork PR: 277348 x11/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thank you!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4d3446077ac2b54838733932d73a8fc2233dd42f commit 4d3446077ac2b54838733932d73a8fc2233dd42f Author: Alexey Vyskubov <alexey@pentode.fi> AuthorDate: 2024-06-19 13:59:08 +0000 Commit: Kurt Jaeger <pi@FreeBSD.org> CommitDate: 2024-06-19 13:59:08 +0000 x11/wmctrl-fork: fix depends PR: 277348 multimedia/lives/Makefile | 2 +- sysutils/inxi/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)