Bug 277708 - net/cloud-init: new release: 24.1.1
Summary: net/cloud-init: new release: 24.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
: 277662 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-03-14 23:37 UTC by Mina Galić
Modified: 2024-05-05 09:48 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (andrey)


Attachments
net/cloud-init: new release: 24.1.1 (1.93 KB, patch)
2024-03-14 23:37 UTC, Mina Galić
no flags Details | Diff
net/cloud-init*: Bump to newest release: 24.1.3 (4.74 KB, patch)
2024-04-02 22:48 UTC, Mina Galić
no flags Details | Diff
net/cloud-init: Bump to newest release: 24.1.4 (2.84 KB, patch)
2024-04-06 16:43 UTC, Mina Galić
no flags Details | Diff
net/cloud-init-devel: Bump to latest main after 24.1 release (2.28 KB, patch)
2024-04-06 16:44 UTC, Mina Galić
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mina Galić freebsd_triage 2024-03-14 23:37:44 UTC
Created attachment 249174 [details]
net/cloud-init: new release: 24.1.1

Changelog: https://github.com/canonical/cloud-init/releases/tag/24.1.1
Changelog: https://github.com/canonical/cloud-init/releases/tag/24.1

Sponsored by: The FreeBSD Foundation
Comment 1 Mina Galić freebsd_triage 2024-03-14 23:39:55 UTC
n.b.: we might actually wanna wait for https://github.com/canonical/cloud-init/pull/4820 & https://github.com/canonical/cloud-init/pull/5061 to be merged & released, or add them as patches.
Comment 2 Dave Cottlehuber freebsd_committer freebsd_triage 2024-03-21 13:17:19 UTC
can we please have this committed before end of March? The current
net/cloud-init is broken, but fixed in the newer net/cloud-init-devel
(thanks Mina!) and it would be good to have a working one in the
2024Q2 quarterly branch which will be forked in early April.
Comment 3 Mina Galić freebsd_triage 2024-03-28 21:27:40 UTC
I'm going to update my patch to bump the release to 24.1.3, and include at least the homedir patch.
As for the rundir patch, i guess I can include that as soon as it's merged?
Comment 4 Mina Galić freebsd_triage 2024-03-28 22:16:02 UTC
(In reply to Mina Galić from comment #3)
as soon as rust rebuilds…
Comment 6 Mina Galić freebsd_triage 2024-04-03 08:48:00 UTC
poudriere testport on aarch64 14.0
tested on AWS (arm64)
Comment 8 Mina Galić freebsd_triage 2024-04-06 16:44:58 UTC
Created attachment 249765 [details]
net/cloud-init-devel: Bump to latest main after 24.1  release

please note that due to an error in the release process, there's no 24.1
tag on main, that's why the version number is still based on 23.4

Same workaround as net/cloud-init for python.mk autoplist bug described
in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205056.

Sponsored by: The FreeBSD Foundation
Comment 9 Joseph Mingrone freebsd_committer freebsd_triage 2024-04-07 15:13:40 UTC
Thanks Mina.

A few tweaks are required.

For the net/cloud-init changes:
1. You need TABS (not spaces) after `=` in PATCH_SITES= and PATCHFILES+=.
2. PATCH_SITES= and PATCHFILES+= should come before the MAINTAINER= group.  portclippy from ports-mgmt/portfmt is a helpful linter for things like this.
3. The build fails because the two patches you submitted upstream are already included in 24.1.4.

So, in the end, we have to remove the PATCH_SITES= and PATCHFILES+= lines.

net/cloud-init-devel looks good to me.

For the commit logs, we should:
1. Include a reference to this PR
2. Use a TAB after 'Sponsored by:'
3. Include 'Approved by:' for the net/cloud-init update since someone else maintains the port.  In this case, since two weeks have passed, we should use Approved by:    andrey@bsdnir.info (maintainer, timeout).

You can install the commit message template hook to make writing commit logs easier.  See https://docs.freebsd.org/en/articles/committers-guide/#git-mini-primer-getting-started.
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-04-07 15:15:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=371b34c860765dbfabe3cbce2635a43a975851e2

commit 371b34c860765dbfabe3cbce2635a43a975851e2
Author:     Mina Galić <me+git@igalic.co>
AuthorDate: 2024-04-06 16:37:32 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2024-04-07 15:04:42 +0000

    net/cloud-init-devel: Bump to latest main after 24.1 release

    please note that due to an error in the release process, there's no 24.1
    tag on main, that's why the version number is still based on 23.4

    Same workaround as net/cloud-init for python.mk autoplist bug described
    in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205056.

    PR:             277708
    Sponsored by:   The FreeBSD Foundation

 net/cloud-init-devel/Makefile | 8 +++++---
 net/cloud-init-devel/distinfo | 6 +++---
 2 files changed, 8 insertions(+), 6 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-04-07 15:15:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f5c6e5909d89660d61b329407b6ce7fb9eaa8fff

commit f5c6e5909d89660d61b329407b6ce7fb9eaa8fff
Author:     Mina Galić <me+git@igalic.co>
AuthorDate: 2024-04-06 16:36:41 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2024-04-07 15:01:38 +0000

    net/cloud-init: Bump to newest release: 24.1.4

    add homedir patch: https://github.com/canonical/cloud-init/pull/5061

    Also work around python.mk autoplist bug described in
    https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205056.

    Changelogs:

    - https://github.com/canonical/cloud-init/releases/tag/24.1
    - https://github.com/canonical/cloud-init/releases/tag/24.1.1
    - https://github.com/canonical/cloud-init/releases/tag/24.1.2
    - https://github.com/canonical/cloud-init/releases/tag/24.1.3
    - https://github.com/canonical/cloud-init/releases/tag/24.1.4

    PR:             277708
    Approved by:    andrey@bsdnir.info (maintainer, timeout)
    Sponsored by:   The FreeBSD Foundation

 net/cloud-init/Makefile | 6 ++++--
 net/cloud-init/distinfo | 8 +++++---
 2 files changed, 9 insertions(+), 5 deletions(-)
Comment 12 Dave Cottlehuber freebsd_committer freebsd_triage 2024-05-05 09:48:25 UTC
*** Bug 277662 has been marked as a duplicate of this bug. ***