Bug 277895 - www/py-horizon: Update to 23.4.0
Summary: www/py-horizon: Update to 23.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://github.com/openstack/horizon/...
Keywords:
Depends on: 277894
Blocks: 276319
  Show dependency treegraph
 
Reported: 2024-03-22 16:06 UTC by Kai Knoblich
Modified: 2024-03-24 18:02 UTC (History)
1 user (show)

See Also:
sunpoet: maintainer-feedback+


Attachments
py-horizon-23.4.0.patch (6.01 KB, patch)
2024-03-22 16:06 UTC, Kai Knoblich
no flags Details | Diff
py-horizon-23.4.0-v.2.patch (5.48 KB, patch)
2024-03-23 17:28 UTC, Kai Knoblich
kai: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2024-03-22 16:06:14 UTC
Created attachment 249412 [details]
py-horizon-23.4.0.patch

Hi Sunpoet,

attached is a patch that updates www/py-horizon to 23.4.0.

QA:
~~~
- poudriere -> OK (13.2-RELEASE amd64, py38 - py311)
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-03-23 16:27:35 UTC
(In reply to Kai Knoblich from comment #0)

I did not commit py-horizon update due to py-scss.
Since you have committed py-scss 1.4.0 update, py-horizon update is ready to go.

Comparing your patch and mine, I do not understand why these RUN_DEPENDS lines are removed?

-           ${PYTHON_PKGNAMEPREFIX}xstatic-angular-fileupload>=12.0.4.0:devel/py-xstatic-angular-fileupload@${PY_FLAVOR} \
-           ${PYTHON_PKGNAMEPREFIX}xstatic-angular-gettext>=2.3.8.0:devel/py-xstatic-angular-gettext@${PY_FLAVOR} \
-           ${PYTHON_PKGNAMEPREFIX}xstatic-angular-schema-form>=0.8.13.0:devel/py-xstatic-angular-schema-form@${PY_FLAVOR} \
-           ${PYTHON_PKGNAMEPREFIX}xstatic-bootstrap-datepicker>=1.3.1.0:devel/py-xstatic-bootstrap-datepicker@${PY_FLAVOR} \
-           ${PYTHON_PKGNAMEPREFIX}xstatic-d3>=3.5.17.0:devel/py-xstatic-d3@${PY_FLAVOR} \

They are listed in requirements.txt.
Could you please give a hint?
Thanks.
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2024-03-23 17:28:04 UTC
Created attachment 249434 [details]
py-horizon-23.4.0-v.2.patch

(In reply to Po-Chuan Hsieh from comment #1)

Good catch and my bad, when comparing/updating all the dependencies I still had a few unstaged changes before I created the first version of the patch.

Attached is an updated version of the patch.
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-03-24 12:53:26 UTC
(In reply to Kai Knoblich from comment #2)

Our Makefiles are identical now. :)
Please go ahead so that we could continue the transition from Django 3.2 to 4.2.
Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-03-24 18:00:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef89e979e2573d88ae708e576dcfc953c6d20efb

commit ef89e979e2573d88ae708e576dcfc953c6d20efb
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2024-03-24 17:56:01 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2024-03-24 17:56:01 +0000

    www/py-horizon: Update to 23.4.0

    Changelog since 22.1.0:

    https://github.com/openstack/horizon/compare/22.1.0...23.4.0

    PR:             277895
    Approved by:    sunpoet (maintainer)

 www/py-horizon/Makefile                            | 16 ++++++++--------
 www/py-horizon/distinfo                            |  6 +++---
 www/py-horizon/files/patch-requirements.txt (gone) | 11 -----------
 3 files changed, 11 insertions(+), 22 deletions(-)
Comment 5 Kai Knoblich freebsd_committer freebsd_triage 2024-03-24 18:01:40 UTC
Comment on attachment 249434 [details]
py-horizon-23.4.0-v.2.patch

^Triage: Set maintainer-approval flag to '+' as the approval was given via comment #3.
Comment 6 Kai Knoblich freebsd_committer freebsd_triage 2024-03-24 18:02:20 UTC
(In reply to Po-Chuan Hsieh from comment #3)

Committed, thanks for your review and feedback!