Bug 278037 - security/py-notus-scanner, security/py-ospd-openvas: missing mqtt.CallbackAPIVersion.VERSION1 when initializing net/py-paho-mqtt 2.0.0
Summary: security/py-notus-scanner, security/py-ospd-openvas: missing mqtt.CallbackAPI...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-29 19:55 UTC by Trond Endrestøl
Modified: 2024-04-24 22:38 UTC (History)
2 users (show)

See Also:


Attachments
Patch for notus/scanner/messaging/mqtt.py adding mqtt.CallbackAPIVersion.VERSION1 (466 bytes, patch)
2024-03-29 19:56 UTC, Trond Endrestøl
no flags Details | Diff
Patch for ospd_openvas/messaging/mqtt.py adding mqtt.CallbackAPIVersion.VERSION1 (464 bytes, patch)
2024-03-29 19:56 UTC, Trond Endrestøl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2024-03-29 19:55:35 UTC
Upgrading to the latest ports version causes grief for security/openvas and friends, notably security/py-notus-scanner and security/py-ospd-openvas.

Starting notus_scanner.
Traceback (most recent call last):
  File "/usr/local/bin/notus-scanner", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/notus/scanner/daemon.py", line 130, in main
    run_daemon(
  File "/usr/local/lib/python3.9/site-packages/notus/scanner/daemon.py", line 86, in run_daemon
    client = MQTTClient(
  File "/usr/local/lib/python3.9/site-packages/notus/scanner/messaging/mqtt.py", line 35, in __init__
    super().__init__(client_id=client_id, protocol=mqtt.MQTTv5)
TypeError: __init__() missing 1 required positional argument: 'callback_api_version'
Exception ignored in: <function Client.__del__ at 0x8760a9a60>
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/paho/mqtt/client.py", line 874, in __del__
    self._reset_sockets()
  File "/usr/local/lib/python3.9/site-packages/paho/mqtt/client.py", line 1133, in _reset_sockets
    self._sock_close()
  File "/usr/local/lib/python3.9/site-packages/paho/mqtt/client.py", line 1119, in _sock_close
    if not self._sock:
AttributeError: 'MQTTClient' object has no attribute '_sock'
Starting gvmd.
Starting ospd_openvas.
Warning: using insecure memory!
Warning: using insecure memory!
Warning: using insecure memory!
Traceback (most recent call last):
  File "/usr/local/bin/ospd-openvas", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/ospd_openvas/daemon.py", line 1245, in main
    daemon_main('OSPD - openvas', OSPDopenvas, NotusParser())
  File "/usr/local/lib/python3.9/site-packages/ospd/main.py", line 152, in main
    daemon.init(server)
  File "/usr/local/lib/python3.9/site-packages/ospd_openvas/daemon.py", line 501, in init
    client = MQTTClient(
  File "/usr/local/lib/python3.9/site-packages/ospd_openvas/messaging/mqtt.py", line 39, in __init__
    super().__init__(client_id=client_id, protocol=mqtt.MQTTv5)
TypeError: __init__() missing 1 required positional argument: 'callback_api_version'
Exception ignored in: <function Client.__del__ at 0x890990550>
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/paho/mqtt/client.py", line 874, in __del__
    self._reset_sockets()
  File "/usr/local/lib/python3.9/site-packages/paho/mqtt/client.py", line 1133, in _reset_sockets
    self._sock_close()
  File "/usr/local/lib/python3.9/site-packages/paho/mqtt/client.py", line 1119, in _sock_close
    if not self._sock:
AttributeError: 'MQTTClient' object has no attribute '_sock'
Starting gsad.
Comment 1 Trond Endrestøl 2024-03-29 19:56:21 UTC
Created attachment 249564 [details]
Patch for notus/scanner/messaging/mqtt.py adding mqtt.CallbackAPIVersion.VERSION1
Comment 2 Trond Endrestøl 2024-03-29 19:56:59 UTC
Created attachment 249565 [details]
Patch for ospd_openvas/messaging/mqtt.py adding mqtt.CallbackAPIVersion.VERSION1
Comment 3 Trond Endrestøl 2024-03-29 19:57:55 UTC
Also, see https://github.com/eclipse/paho.mqtt.python/issues/814
Comment 4 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-04-24 22:38:49 UTC
Hello, I have updated gvm ports to latest versions. Take a look at:

https://cgit.freebsd.org/ports/commit/?id=fde0b606556b9deb1dd043cdd07d45145d33720b

If I'm not mistaken new versions include support for py-paho-mqtt 1.x and 2.x. Feel free to open this PR if it is not fixed.