Bug 278263 - net-im/tdlib-purple: add more "community" patches
Summary: net-im/tdlib-purple: add more "community" patches
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-08 17:47 UTC by Mikhail T.
Modified: 2025-11-01 17:44 UTC (History)
3 users (show)

See Also:
freebsd-2026: maintainer-feedback+


Attachments
the patch (4.85 KB, patch)
2024-04-08 17:47 UTC, Mikhail T.
no flags Details | Diff
the patch (6.70 KB, patch)
2024-04-08 17:49 UTC, Mikhail T.
no flags Details | Diff
Updated patch (7.59 KB, patch)
2024-05-18 18:12 UTC, Mikhail T.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2024-04-08 17:47:19 UTC
Created attachment 249838 [details]
the patch

The update provides the following:
 . Option to display self-destructing messages anyway -- despite the inability to
   destroy them later, for which libpurple does not provide. (https://github.com/ars3niy/tdlib-purple/pull/159)
 . Protection against spam -- (https://github.com/ars3niy/tdlib-purple/pull/163)
 . configurable API ID and hash (https://github.com/ars3niy/tdlib-purple/pull/129)
Comment 1 Mikhail T. 2024-04-08 17:49:11 UTC
Created attachment 249839 [details]
the patch
Comment 2 Mikhail T. 2024-05-18 18:12:05 UTC
Created attachment 250796 [details]
Updated patch

Use a custom DIST_SUBDIR for DISTFILES and PATCHFILES.

Add a patch to quiet a run-time warning.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2025-05-13 02:16:18 UTC
net-im/tdlib-purple is broken with the latest revision of net-im/tdlib
It also appears to be dead upstream with the last commit 4 years ago.
Comment 4 Mikhail T. 2025-05-13 02:18:15 UTC
(In reply to Yuri Victorovich from comment #3)
> net-im/tdlib-purple is broken with the latest revision of net-im/tdlib

I thought, you fixed that problem, no?

> It also appears to be dead upstream with the last commit 4 years ago.

It is "community-maintained". Indeed, the patches I'm adding are from other users' pull-requests.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2025-05-13 02:29:38 UTC
(In reply to Mikhail T. from comment #4)

> I thought, you fixed that problem, no?

I fixed the problems in tdlib with shared libs, missing headers, and with net-im/telegram-desktop build failure.

But net-im/tdlib-purple is now breaking because it expects some symbols that were renamed in tdlib. net-im/tdlib-purple needs to be patched.
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-11-01 17:01:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eb4b9b42b549e19acdb77a57563d734ccbc5dd09

commit eb4b9b42b549e19acdb77a57563d734ccbc5dd09
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2025-11-01 13:12:05 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2025-11-01 16:40:43 +0000

    net-im/tdlib-purple: Remove port

    Marked broken in May 2025 and dead upstream

    PR:             278263

 MOVED                                              |  1 +
 net-im/Makefile                                    |  1 -
 net-im/tdlib-purple/Makefile (gone)                | 51 ----------------------
 net-im/tdlib-purple/distinfo (gone)                |  5 ---
 .../tdlib-purple/files/patch-CMakeLists.txt (gone) | 17 --------
 net-im/tdlib-purple/files/patch-format.cpp (gone)  |  8 ----
 .../files/patch-test-CMakeLists.txt (gone)         |  9 ----
 net-im/tdlib-purple/pkg-descr (gone)               |  3 --
 net-im/tdlib-purple/pkg-plist (gone)               |  9 ----
 9 files changed, 1 insertion(+), 103 deletions(-)
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2025-11-01 17:02:31 UTC
Attached patch fails to build
Comment 8 Mikhail Teterin freebsd_committer freebsd_triage 2025-11-01 17:44:09 UTC
(In reply to Daniel Engberg from comment #7)
> Attached patch fails to build

For the record, the patch built Ok at the time this PR was opened...

But then the net-im/tdlib was unceremoniously upgraded -- with surprising disregard for the dependents -- which broke this port.

If the upstream ever wakes up, I'll try to resurrect it...