Bug 278538 - audio/audacity: update to 3.5.0
Summary: audio/audacity: update to 3.5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://github.com/audacity/audacity/...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-22 22:46 UTC by Vladimir Druzenko
Modified: 2024-04-24 00:25 UTC (History)
1 user (show)

See Also:
xxjack12xx: maintainer-feedback+
xxjack12xx: maintainer-feedback+


Attachments
Update to 3.5.0 (12.03 KB, patch)
2024-04-24 00:02 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Jack 2024-04-23 02:01:24 UTC
Having some build dependency issues locally, will take another look soon.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-04-23 09:52:32 UTC
(In reply to Jack from comment #1)
Removed unused LIB_DEPENDS:
Warning: you might not need LIB_DEPENDS on libasound.so
Warning: you might not need LIB_DEPENDS on libcurl.so
Warning: you might not need LIB_DEPENDS on libopenjp2.so
Warning: you might not need LIB_DEPENDS on libpng.so
Warning: you might not need LIB_DEPENDS on libturbojpeg.so

And pet portclippy.

Maybe we need to sort out with CMAKE options (CMAKE_ON/CMAKE_OFF).

Updated patch at https://reviews.freebsd.org/D44909
Comment 3 Jack 2024-04-23 22:48:24 UTC
Those dependencies were needed by other dependent libs so I think we are ok. Just tested the patch and looks good.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-04-23 22:57:16 UTC
(In reply to Jack from comment #3)
For example curl required for network-manager module - turned off in CMAKE_OFF.
I tried search where other libs used and didn't find.
Only ffmpeg (libav*.so) used via dlopen in one module.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-04-24 00:02:22 UTC
Created attachment 250192 [details]
Update to 3.5.0

Upstream committed our patches to 3.5.1 branch - replaced audio/audacity/files/patch-* with patch from this commit.
https://github.com/audacity/audacity/commit/4191cfb8376d19d044cadaf31214182375a9af55
Comment 6 Jack 2024-04-24 00:15:57 UTC
Comment on attachment 250192 [details]
Update to 3.5.0

Trying to set + on the maintainer-approval but doesn't seem to be changing. Trying with a comment in addition to changing.
Comment 7 Jack 2024-04-24 00:16:27 UTC
I can't seem to + the attachment but it looks fine.
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-04-24 00:24:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0839e30cb3a7acd883eb945b0fe3af77a8d1d5cc

commit 0839e30cb3a7acd883eb945b0fe3af77a8d1d5cc
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-04-24 00:20:41 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-04-24 00:23:57 +0000

    audio/audacity: update to 3.5.0

    Changelog:
    https://github.com/audacity/audacity/releases/tag/Audacity-3.5.0

    PR:                     278538
    Approved by:            xxjack12xx@gmail.com (maintainer), arrowd (mentor, implicit)
    Differential Revision:  https://reviews.freebsd.org/D44909

 audio/audacity/Makefile                            | 48 +++++++++++-----------
 audio/audacity/distinfo                            |  8 ++--
 ...ch-lib-src_libnyquist_nyquist_cmt_cext.h (gone) | 11 -----
 ...lib-src_libnyquist_nyquist_xlisp_xlisp.h (gone) | 18 --------
 ...patch-libraries_lib-basic-ui_BasicUI.cpp (gone) | 10 -----
 .../files/patch-src_AboutDialog.cpp (gone)         | 11 -----
 .../files/patch-src_ListNavigationPanel.h (gone)   | 11 -----
 audio/audacity/files/patch-src_MIDIPlay.cpp (gone) | 11 -----
 audio/audacity/pkg-plist                           | 11 ++++-
 9 files changed, 37 insertions(+), 102 deletions(-)