Bug 278914 - multimedia/gstreamer1: Update to 1.24.8
Summary: multimedia/gstreamer1: Update to 1.24.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-multimedia (Nobody)
URL: https://gstreamer.freedesktop.org/rel...
Keywords:
Depends on:
Blocks: 278705
  Show dependency treegraph
 
Reported: 2024-05-11 12:24 UTC by Vladimir Druzenko
Modified: 2024-09-27 17:02 UTC (History)
4 users (show)

See Also:
jhale: maintainer-feedback+


Attachments
stopped in /usr/ports/graphics/gstreamer1-plugins-opencv (51.60 KB, application/octet-stream)
2024-09-24 19:14 UTC, Chad Jacob Milios
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-11 12:24:58 UTC
"The latest bug-fix release in the stable 1.24 series is 1.24.3 and was released on 30 April 2024."

This update required for update multimedia/ffmpeg to version 7.x: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278705

After update it still require patch from upstream issue: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3534
Comment 1 Yokomichi 2024-06-30 13:50:02 UTC
I also suggest an exp-run, since multiple vulnerabilities have been found in multimedia/gstreamer1 and multimedia/gstreamer1-plugins-bad. 1.22.10 and earlier versions are vulnerable, 1.22.11 and later are safe. 

References
[ 1 ] CVE-2023-40474
      https://nvd.nist.gov/vuln/detail/CVE-2023-40474
[ 2 ] CVE-2023-40475
      https://nvd.nist.gov/vuln/detail/CVE-2023-40475
[ 3 ] CVE-2023-40476
      https://nvd.nist.gov/vuln/detail/CVE-2023-40476
[ 4 ] CVE-2023-44429
      https://nvd.nist.gov/vuln/detail/CVE-2023-44429
[ 5 ] CVE-2023-44446
      https://nvd.nist.gov/vuln/detail/CVE-2023-44446
[ 6 ] ZDI-CAN-21660
[ 7 ] ZDI-CAN-21661
[ 8 ] ZDI-CAN-21768
[ 9 ] ZDI-CAN-22226
[ 10 ] ZDI-CAN-22299
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2024-09-18 10:05:09 UTC
I'm working on updating the gstreamer1 ports to 1.24.7. I have the "big ports" (gstreamer1, gstreamer1-plugins (base plugins), gstreamer1-plugins-{good|bad|ugly}) successfully building and am currently doing QA for the rest of the stack.

The "gst-ptp-helper" support program from multimedia/gstreamer1 has since been ported to Rust, so I've added a PTP option to that port to handle platforms where Rust is not supported.

I've also split out the sctp and webrtc plugins from gstreamer1-plugins-bad since webrtc requires sctp and the already split-out dtls and srtp plugins. Sctp's only consumer in the tree is webrtc, so this didn't require much extra patching. This also eliminates a few extra deps from the main port.

The only problem is I don't know if any ports currently depending on "bad" really need the webrtc plugin since that problem would likely only manifest itself at runtime. I'll probably add a CHANGES entry to suggest adding USE_GSTREAMER+=webrtc to individual ports in case runtime breaks since it isn't practical to run test everything and I doubt a CFT will generate any responses.
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2024-09-20 01:27:04 UTC
GStreamer 1.24.8 was released today which threw a tiny wrench in the gears, but I now have the entire stack building successfully. Just working on adding the x11-toolkits/gstreamer1-plugins-qt6 plugin and doing QA for consumers.

On the webrtc front, multimedia/gstreamer1-plugins-rust, does need the webrtc plugin and I've updated it accordingly.

I should have it ready to push soon.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-09-22 10:40:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c1efc578d6f6e5fc6371bf22d3983675f636b44

commit 8c1efc578d6f6e5fc6371bf22d3983675f636b44
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-09-22 08:31:12 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-09-22 10:35:56 +0000

    multimedia/gstreamer1: Update to 1.24.8

    Mk/Uses/gstreamer.mk:
    - Sort, fix whitespace issues and typos
    - Promote several common variables to improve maintainer QOL
    *   There's now no need to set manually set PORTVERSION nor
        SOVERSION in several Makefiles
    *   This will help to prevent not updating some components
    *   A note has been added, however, to remind maintainers
        to remake distinfo for certain ports
    - Improve documentation

    multimedia/gstreamer1-plugins-webrtc:
    - New port split from multimedia/gstreamer1-plugins-bad
    - multimedia/gstreamer1-plugins-rust has been updated
      to reflect this change

    net/gstreamer1-plugins-sctp:
    - New port split from multimedia/gstreamer1-plugins-bad

    x11-toolkits/gstreamer1-plugins-qt5:
    - Moved here from graphics/gstreamer1-plugins-qt to
      align with its new Qt6 counterpart

    x11-toolkits/gstreamer1-plugins-qt6:
    - New port: GStreamer Qt6 QML videosink plugin

    */*:
    - Improve Makefile order and formatting
    - Sorry for the repo churn, but not fixing this would just lead to more
      poorly formatted gstreamer ports in the future via copypasta

    https://gstreamer.freedesktop.org/releases/1.24/#1.24.8

    PR:             278914
    Reported by:    vvd

 MOVED                                              |   1 +
 Mk/Uses/gstreamer.mk                               | 172 +++++++++++++--------
 audio/gstreamer1-plugins-a52dec/Makefile           |  12 +-
 audio/gstreamer1-plugins-amrnb/Makefile            |  12 +-
 audio/gstreamer1-plugins-amrwbdec/Makefile         |  13 +-
 audio/gstreamer1-plugins-bs2b/Makefile             |  13 +-
 audio/gstreamer1-plugins-cdparanoia/Makefile       |  10 +-
 audio/gstreamer1-plugins-chromaprint/Makefile      |  10 +-
 audio/gstreamer1-plugins-faac/Makefile             |  10 +-
 audio/gstreamer1-plugins-faad/Makefile             |  12 +-
 audio/gstreamer1-plugins-flac/Makefile             |  10 +-
 audio/gstreamer1-plugins-flite/Makefile            |  10 +-
 audio/gstreamer1-plugins-gme/Makefile              |  12 +-
 audio/gstreamer1-plugins-gsm/Makefile              |  10 +-
 audio/gstreamer1-plugins-jack/Makefile             |  10 +-
 audio/gstreamer1-plugins-ladspa/Makefile           |  13 +-
 audio/gstreamer1-plugins-lame/Makefile             |  10 +-
 audio/gstreamer1-plugins-lv2/Makefile              |  20 ++-
 audio/gstreamer1-plugins-modplug/Makefile          |  10 +-
 audio/gstreamer1-plugins-mpg123/Makefile           |  10 +-
 audio/gstreamer1-plugins-ogg/Makefile              |  10 +-
 audio/gstreamer1-plugins-openmpt/Makefile          |  10 +-
 audio/gstreamer1-plugins-opus/Makefile             |  10 +-
 audio/gstreamer1-plugins-pulse/Makefile            |  12 +-
 audio/gstreamer1-plugins-shout2/Makefile           |  10 +-
 audio/gstreamer1-plugins-sidplay/Makefile          |  12 +-
 audio/gstreamer1-plugins-sndfile/Makefile          |  10 +-
 audio/gstreamer1-plugins-soundtouch/Makefile       |  11 +-
 audio/gstreamer1-plugins-speex/Makefile            |  10 +-
 audio/gstreamer1-plugins-taglib/Makefile           |  16 +-
 audio/gstreamer1-plugins-twolame/Makefile          |  10 +-
 audio/gstreamer1-plugins-vorbis/Makefile           |  13 +-
 audio/gstreamer1-plugins-wavpack/Makefile          |  10 +-
 audio/gstreamer1-plugins-webrtcdsp/Makefile        |  10 +-
 comms/gstreamer1-plugins-spandsp/Makefile          |  10 +-
 devel/gstreamer1-plugins-soup/Makefile             |  10 +-
 ftp/gstreamer1-plugins-curl/Makefile               |  12 +-
 graphics/Makefile                                  |   1 -
 graphics/gstreamer1-plugins-aalib/Makefile         |  12 +-
 graphics/gstreamer1-plugins-cairo/Makefile         |  10 +-
 graphics/gstreamer1-plugins-gdkpixbuf/Makefile     |  10 +-
 graphics/gstreamer1-plugins-gl/Makefile            |  45 +++---
 graphics/gstreamer1-plugins-gl/pkg-plist           |   2 +
 graphics/gstreamer1-plugins-jpeg/Makefile          |  12 +-
 graphics/gstreamer1-plugins-kms/Makefile           |  10 +-
 graphics/gstreamer1-plugins-libcaca/Makefile       |  10 +-
 graphics/gstreamer1-plugins-libvisual/Makefile     |  10 +-
 graphics/gstreamer1-plugins-opencv/Makefile        |  15 +-
 graphics/gstreamer1-plugins-openexr/Makefile       |  15 +-
 graphics/gstreamer1-plugins-openjpeg/Makefile      |  10 +-
 graphics/gstreamer1-plugins-png/Makefile           |  10 +-
 graphics/gstreamer1-plugins-qt/Makefile (gone)     |  19 ---
 graphics/gstreamer1-plugins-rsvg/Makefile          |  10 +-
 graphics/gstreamer1-plugins-vulkan/Makefile        |  30 ++--
 graphics/gstreamer1-plugins-vulkan/pkg-plist       |   8 +
 graphics/gstreamer1-plugins-webp/Makefile          |  10 +-
 graphics/gstreamer1-plugins-zbar/Makefile          |  10 +-
 multimedia/Makefile                                |   1 +
 multimedia/gstreamer1-editing-services/Makefile    |  13 +-
 multimedia/gstreamer1-editing-services/distinfo    |   6 +-
 multimedia/gstreamer1-editing-services/pkg-plist   |   6 +-
 multimedia/gstreamer1-libav/Makefile               |   8 +-
 multimedia/gstreamer1-libav/distinfo               |   6 +-
 multimedia/gstreamer1-plugins-all/Makefile         |   2 +-
 multimedia/gstreamer1-plugins-aom/Makefile         |  10 +-
 multimedia/gstreamer1-plugins-assrender/Makefile   |  13 +-
 multimedia/gstreamer1-plugins-bad/Makefile         |  40 +++--
 .../files/patch-ext_dtls_meson.build (new)         |  11 ++
 .../files/patch-ext_sctp_meson.build (new)         |  11 ++
 .../files/patch-ext_srtp_meson.build (new)         |  11 ++
 .../files/patch-ext_vulkan_meson.build (new)       |  11 ++
 .../files/patch-ext_webrtc_meson.build             |  27 +++-
 .../files/patch-ext_webrtcdsp_meson.build          |  10 +-
 .../patch-gst-libs_gst_analytics_meson.build (new) |  12 ++
 .../files/patch-gst-libs_gst_audio_meson.build     |   4 +-
 ...patch-gst-libs_gst_basecamerabinsrc_meson.build |   4 +-
 .../patch-gst-libs_gst_codecparsers_meson.build    |   4 +-
 .../files/patch-gst-libs_gst_codecs_meson.build    |  23 ++-
 .../patch-gst-libs_gst_dxva_meson.build (new)      |  12 ++
 .../files/patch-gst-libs_gst_insertbin_meson.build |   4 +-
 .../files/patch-gst-libs_gst_mpegts_meson.build    |   4 +-
 .../files/patch-gst-libs_gst_mse_meson.build (new) |  12 ++
 .../files/patch-gst-libs_gst_play_meson.build      |   4 +-
 .../files/patch-gst-libs_gst_player_meson.build    |   4 +-
 .../patch-gst-libs_gst_transcoder_meson.build      |   4 +-
 .../files/patch-gst-libs_gst_va_meson.build        |  25 ++-
 .../files/patch-gst-libs_gst_webrtc_meson.build    |   9 +-
 .../gstreamer1-plugins-bad/files/patch-meson.build |   6 +-
 .../files/patch-meson__options.txt                 |  10 +-
 .../files/patch-sys_kms_meson.build                |  10 +-
 .../files/patch-sys_msdk_meson.build               |   6 +-
 .../files/patch-tests_examples_meson.build         |  16 +-
 .../files/patch-tests_meson.build (new)            |  13 ++
 .../files/patch-tools_meson.build                  |  28 ++--
 multimedia/gstreamer1-plugins-bad/pkg-plist        |  76 ++++-----
 multimedia/gstreamer1-plugins-core/Makefile        |  28 ++--
 multimedia/gstreamer1-plugins-dash/Makefile        |  10 +-
 multimedia/gstreamer1-plugins-dts/Makefile         |  12 +-
 multimedia/gstreamer1-plugins-dv/Makefile          |  10 +-
 multimedia/gstreamer1-plugins-dvdread/Makefile     |  14 +-
 multimedia/gstreamer1-plugins-good/Makefile        |  13 +-
 .../files/patch-ext_qt6_meson.build (new)          |  11 ++
 .../files/patch-ext_qt_meson.build (new)           |  11 ++
 .../files/patch-sys_v4l2_gstv4l2object.c (new)     |  12 ++
 .../files/patch-sys_v4l2_v4l2__calls.c             |   4 +-
 multimedia/gstreamer1-plugins-hls/Makefile         |  10 +-
 multimedia/gstreamer1-plugins-libde265/Makefile    |  10 +-
 multimedia/gstreamer1-plugins-mpeg2dec/Makefile    |  14 +-
 multimedia/gstreamer1-plugins-mpeg2enc/Makefile    |  16 +-
 multimedia/gstreamer1-plugins-mplex/Makefile       |  18 +--
 multimedia/gstreamer1-plugins-msdk/Makefile        |  20 +--
 multimedia/gstreamer1-plugins-openh264/Makefile    |  10 +-
 multimedia/gstreamer1-plugins-resindvd/Makefile    |  16 +-
 multimedia/gstreamer1-plugins-rust/Makefile        |   4 +-
 .../gstreamer1-plugins-smoothstreaming/Makefile    |  12 +-
 multimedia/gstreamer1-plugins-theora/Makefile      |  12 +-
 multimedia/gstreamer1-plugins-ttml/Makefile        |  10 +-
 multimedia/gstreamer1-plugins-ugly/Makefile        |  11 +-
 multimedia/gstreamer1-plugins-v4l2/Makefile        |  15 +-
 multimedia/gstreamer1-plugins-vpx/Makefile         |  12 +-
 .../gstreamer1-plugins-webrtc/Makefile (new)       |  17 ++
 .../gstreamer1-plugins-webrtc/pkg-plist (new)      |  28 ++++
 multimedia/gstreamer1-plugins-x264/Makefile        |  14 +-
 multimedia/gstreamer1-plugins-x265/Makefile        |  16 +-
 multimedia/gstreamer1-plugins/Makefile             |  91 ++++++-----
 multimedia/gstreamer1-plugins/Makefile.common      |  66 +++++++-
 multimedia/gstreamer1-plugins/distinfo             |  18 +--
 .../files/patch-ext_cdparanoia_gstcdparanoiasrc.c  |   8 +-
 .../files/patch-ext_cdparanoia_meson.build         |   4 +-
 .../files/patch-ext_gl_meson.build                 |   6 +-
 .../patch-gst-libs_gst_allocators_meson.build      |   4 +-
 .../files/patch-gst-libs_gst_app_meson.build       |   6 +-
 .../files/patch-gst-libs_gst_audio_meson.build     |   4 +-
 .../files/patch-gst-libs_gst_gl_meson.build        |  20 +--
 .../files/patch-gst-libs_gst_pbutils_meson.build   |   9 +-
 .../files/patch-gst-libs_gst_rtp_meson.build       |   4 +-
 .../files/patch-gst-libs_gst_rtsp_meson.build      |   4 +-
 .../files/patch-gst-libs_gst_sdp_meson.build       |   4 +-
 .../files/patch-gst-libs_gst_tag_meson.build       |   4 +-
 .../files/patch-gst-libs_gst_video_meson.build     |   4 +-
 .../gstreamer1-plugins/files/patch-meson.build     |   8 +-
 .../files/patch-tools_meson.build                  |   4 +-
 multimedia/gstreamer1-plugins/pkg-plist            |  13 +-
 multimedia/gstreamer1-rtsp-server/Makefile         |  10 +-
 multimedia/gstreamer1-rtsp-server/distinfo         |   6 +-
 multimedia/gstreamer1-vaapi/Makefile               |   5 +-
 multimedia/gstreamer1-vaapi/distinfo               |   6 +-
 multimedia/gstreamer1/Makefile                     |  59 ++++---
 multimedia/gstreamer1/distinfo                     |   6 +-
 multimedia/gstreamer1/pkg-plist                    |   4 +-
 net/Makefile                                       |   1 +
 net/gstreamer1-plugins-sctp/Makefile (new)         |  13 ++
 net/gstreamer1-plugins-sctp/pkg-plist (new)        |   8 +
 net/gstreamer1-plugins-srtp/Makefile               |  10 +-
 security/gstreamer1-plugins-dtls/Makefile          |  10 +-
 sysutils/gstreamer1-plugins-cdio/Makefile          |  14 +-
 textproc/gstreamer1-plugins-zxing/Makefile         |   8 +-
 textproc/gstreamer1-plugins-zxing/distinfo (gone)  |   5 -
 www/gstreamer1-plugins-neon/Makefile               |  12 +-
 www/gstreamer1-plugins-srt/Makefile                |  10 +-
 x11-toolkits/Makefile                              |   2 +
 x11-toolkits/gstreamer1-plugins-gtk/Makefile       |  18 +--
 x11-toolkits/gstreamer1-plugins-pango/Makefile     |  14 +-
 x11-toolkits/gstreamer1-plugins-qt5/Makefile (new) |  27 ++++
 .../gstreamer1-plugins-qt5}/pkg-plist              |   0
 x11-toolkits/gstreamer1-plugins-qt6/Makefile (new) |  26 ++++
 .../gstreamer1-plugins-qt6/pkg-plist (new)         |   1 +
 x11/gstreamer1-plugins-x/Makefile                  |  20 +--
 x11/gstreamer1-plugins-ximagesrc/Makefile          |  21 ++-
 169 files changed, 1356 insertions(+), 932 deletions(-)
Comment 5 Jason E. Hale freebsd_committer freebsd_triage 2024-09-22 10:42:54 UTC
Fun times. :)
Comment 6 Chad Jacob Milios 2024-09-24 19:14:39 UTC
Created attachment 253800 [details]
stopped in /usr/ports/graphics/gstreamer1-plugins-opencv

any idea why on 13.3/amd64 i now get?:

ld: error: unable to find library -lopencv_ovis
c++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/gstreamer1-plugins-opencv
Comment 7 Jason E. Hale freebsd_committer freebsd_triage 2024-09-27 04:05:44 UTC
(In reply to Chad Jacob Milios from comment #6)

> ld: error: unable to find library -lopencv_ovis

I suspect this is a problem stemming from graphics/opencv. If graphics/ogre3d is also installed, the ovis module will be built. The port doesn't account for this, so the module is built, but not installed. An entry for the module is still added to the pkgconfig file, however.

I'm working on fixing the opencv port, but in the mean time, you can safely remove -lopencv_ovis from the Libs section of ${LOCALBASE}/libdata/pkgconfig/opencv4.pc. That should get graphics/gstreamer1-plugins-opencv building for you.
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-09-27 15:01:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37f9d06df180a835d9f278584ad5245f6f3938f7

commit 37f9d06df180a835d9f278584ad5245f6f3938f7
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-09-27 14:40:55 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-09-27 15:00:42 +0000

    graphics/opencv: Add OGRE3D option

    If graphics/ogre3d was installed on the system, the ovis module was
    being built, but not installed. The module was still added to the
    pkgconfig file, though, which is problematic for consumers of opencv
    using pkgconf such as graphics/gstreamer1-plugins-opencv. [1]

    Move gflags/glog deps to EIGEN option. Fix plist if ceres-solver is
    installed on the system.

    Elevate USES=gnome, so it that works for the two options that need it.

    PR:             278914 [1]
    Reported by:    Chad Jacob Milios <milios@ccsys.com> [1]

 graphics/opencv/Makefile  | 16 ++++++++++------
 graphics/opencv/pkg-plist |  5 +++++
 2 files changed, 15 insertions(+), 6 deletions(-)
Comment 9 Jason E. Hale freebsd_committer freebsd_triage 2024-09-27 15:03:59 UTC
(In reply to Chad Jacob Milios from comment #6)

That issue should be fixed now. Please update your ports tree and reinstall graphics/opencv.
Comment 10 Chad Jacob Milios 2024-09-27 17:02:49 UTC
(In reply to Jason E. Hale from comment #9)

Thank you for the prompt fix and all the fine work you do. Yup now it's all looking great!