Bug 278916 - multimedia/vlc: prevent silent grab several libs, add dependency from devel/abseil to CHROMECAST, make portclippy happy
Summary: multimedia/vlc: prevent silent grab several libs, add dependency from devel/a...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-11 16:17 UTC by Vladimir Druzenko
Modified: 2024-05-25 18:13 UTC (History)
2 users (show)

See Also:
vvd: maintainer-feedback? (multimedia)


Attachments
sort out Makefile v1 (12.86 KB, patch)
2024-05-11 16:17 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-11 16:17:49 UTC
Created attachment 250585 [details]
sort out Makefile v1

"make stage-qa" on live system:
Error: /usr/local/lib/vlc/plugins/access/libaccess_srt_plugin.so is linked to /usr/local/lib/libsrt.so.1.5 from www/srt but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libsrt.so:www/srt
Error: /usr/local/lib/vlc/plugins/codec/libaribsub_plugin.so is linked to /usr/local/lib/libaribb24.so.0 from multimedia/aribb24 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libaribb24.so:multimedia/aribb24
Error: /usr/local/lib/vlc/plugins/stream_out/libstream_out_chromecast_plugin.so is linked to /usr/local/lib/libabsl_log_internal_check_op.so.2301.0.0 from devel/abseil but it is not declared as a dependency
... cut many lines about devel/abseil ...
Error: /usr/local/lib/vlc/plugins/stream_out/libstream_out_chromecast_plugin.so is linked to /usr/local/lib/libabsl_log_severity.so.2301.0.0 from devel/abseil but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libabsl_log_severity.so:devel/abseil

1. Add options ARIBSUB and SRT.
2. Add libabsl_base.so:devel/abseil to CHROMECAST_LIB_DEPENDS.
3. Sort options to make portclippy happy.
4. Remove GNU_CONFIGURE_MANPREFIX.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-18 14:17:18 UTC
I'll commit this patch 25th of May with "maintainer timeout 2 weeks".
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-25 18:12:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=668f0b73043f23658b72de8d2e1272e62c87213c

commit 668f0b73043f23658b72de8d2e1272e62c87213c
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-05-25 18:06:43 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-05-25 18:11:39 +0000

    multimedia/vlc: prevent silent grab several libs, add dependency from devel/abseil to CHROMECAST, make portclippy happy

    1. Add options ARIBSUB and SRT.
    2. Add libabsl_base.so:devel/abseil to CHROMECAST_LIB_DEPENDS.
    3. Sort options to make portclippy happy.
    4. Remove GNU_CONFIGURE_MANPREFIX.
    5. Prevent silent grab aribb25.

    PR:             278916
    Approved by:    multimedia (maintainer, timeout 2 weeks)

 multimedia/vlc/Makefile | 201 ++++++++++++++++++++++++------------------------
 1 file changed, 101 insertions(+), 100 deletions(-)