Bug 279315 - editors/vscode fails build in 2024Q2 branch
Summary: editors/vscode fails build in 2024Q2 branch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-26 07:54 UTC by bas
Modified: 2024-05-31 09:25 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (tagattie)

Attachments
Build log from Poudriere (157.49 KB, text/plain)
2024-05-26 07:54 UTC, bas 		no flags Details
Patch (733 bytes, patch)
2024-05-28 21:49 UTC, Hiroki Tagato 		no flags Details | Diff
Build log from the patched port. (157.61 KB, text/plain)
2024-05-30 11:18 UTC, bas 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description bas 2024-05-26 07:54:29 UTC 
Created attachment 250975 [details]
Build log from Poudriere

The build fails, seems to be due to a missing Kerberos dependency. See attached build log.
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2024-05-28 21:49:16 UTC 
Created attachment 251048 [details]
Patch

The build error is due to the recent update of www/node18 on 2024Q2 branch.

Can you try with this patch to see how it goes?
Comment 2 bas 2024-05-30 11:18:15 UTC 
Unfortunately, no. I applied the patch but build still fails. I attached another build log from the patched port's build process.
Comment 3 bas 2024-05-30 11:18:44 UTC 
Created attachment 251084 [details]
Build log from the patched port.
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2024-05-31 07:08:59 UTC 
(In reply to bas from comment #2)

Build of the kerberos node module is successful with the patch on my local machine. Can you make it sure that the patch is really applied?
Comment 5 bas 2024-05-31 08:14:45 UTC 
Indeed, I botched the patch myself. The build now works correctly and I have a functioning package.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-05-31 09:24:29 UTC 
A commit in branch 2024Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0872856aa5c8f91039122351a478b568818651ff

commit 0872856aa5c8f91039122351a478b568818651ff
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2024-05-31 09:14:15 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-05-31 09:23:02 +0000

    editors/vscode: fix build with node 18.20.0 or later

    www/node18 on 2024Q2 branch has been updated to 18.20.2 and it causes
    an error while building the kerberos node module.

    This is a direct commit to 2024Q2 to fix the build error.

    PR:             279315
    Reported by:    bas@area536.com
    Tested by:      bas@area536.com

 .../patch-remote_node__modules_kerberos_src_kerberos.h (new)   | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 7 Hiroki Tagato freebsd_committer freebsd_triage 2024-05-31 09:25:54 UTC 
The patch has been committed to 2024Q2 branch. Thanks for reporting and testing.