Comment 1 Charlie Li 2024-06-15 07:45:40 UTC

Comment on attachment 251457 [details]
Patch for libxslt

Switching to cmake and removal of gtk-docs are not approved.

Comment 2 Daniel Engberg 2024-06-15 10:02:54 UTC

Created attachment 251471 [details]
Patch for libxsl v2

Various fixes, not final version (pending patches and a few other things)

Comment 3 Daniel Engberg 2024-06-16 06:51:06 UTC

Created attachment 251492 [details]
Patch for libxsl v3

Backport upstream commit f7ada2f8e2f58aa105e165e4db58eb8c2d89362d

Reference:
https://gitlab.gnome.org/GNOME/libxslt/-/commit/f7ada2f8e2f58aa105e165e4db58eb8c2d89362d

Comment 4 Daniel Engberg 2024-06-16 06:59:10 UTC

Initial run:
https://pdr2.bofh.network/build.html?mastername=132-diizzy&build=2024-06-15_15h31m17s

Note that fallouts from PR 279705 are also in here

Comment 5 Daniel Engberg 2024-06-23 12:38:47 UTC

Created attachment 251645 [details]
Patch for libxslt v4

Backport upstream commit cd923ff30cd305d379526202612e063a6b170efc

Reference:
https://gitlab.gnome.org/GNOME/libxslt/-/commit/cd923ff30cd305d379526202612e063a6b170efc

Comment 6 Daniel Engberg 2024-06-23 16:05:19 UTC

Created attachment 251649 [details]
Patch for libxslt v5

Fix plist for GCRYPT option

Comment 7 Daniel Engberg 2024-07-05 17:21:27 UTC

Created attachment 251886 [details]
Patch for libxslt v6

Comment 8 Charlie Li 2024-07-14 04:00:26 UTC

If this and textproc/libxml2 are to be committed separately, this has to go first despite being a consumer. Newer libxslt can build (excepting tests due to incompatible function pointer types or undeclared functions) with older libxml2 but not the other way around.

Comment 9 Charlie Li 2024-07-14 04:03:10 UTC

Created attachment 252031 [details]
v7 (using autotools)

This stays on autotools (libxml2 to return there as well), documentation is also preserved.

Comment 10 Daniel Engberg 2024-07-14 05:39:20 UTC

Not synching these will cause breakage and not something desirable

Comment 11 Daniel Engberg 2024-07-20 11:47:16 UTC

Documentation is also not removed, see "PORTDOCS=	*"

Comment 12 Charlie Li 2025-03-03 05:05:02 UTC

Created attachment 258239 [details]
v8

Add an upstream commit fixing runtest build with older libxml2. One test will fail but upstream acknowledged this is expected; it should not affect consumer builds.

gtk-doc stays, it is built unconditionally so it remains in the resulting package unconditionally. PORTDOCS doesn't apply as gtk-doc doesn't operate in DOCSDIR, and is better to explicitly list each file anyway.

Comment 13 Charlie Li 2025-03-03 05:08:36 UTC

exp-run requested (attachment name: v8) to check for any consumer build failures purely on libxslt rather than both libxml2 + libxslt.

Comment 14 Antoine Brodin 2025-03-06 09:41:55 UTC

Exp-run looks fine

Comment 15 Daniel Engberg 2025-03-06 18:19:14 UTC

This combination is however not well tested at least as far as upstream goes as upstream tests against libxml2 master/main branch so it likely an unnecessary risk to not update both libraries at the same time.
https://gitlab.gnome.org/GNOME/libxslt/-/blob/d994c6132be66760cea85cc55304296d5b621bb8/.gitlab-ci.yml#L177

Comment 16 Charlie Li 2025-03-06 18:24:17 UTC

(In reply to Daniel Engberg from comment #15)
Correct, however only one test fails in our context, and is insignificant to actual usage. The test in question refers to a libxml2 symbol only made public in 2.13. Other operating systems have rolled with this with the same concern over the one failed test but otherwise don't have runtime issues.

This will be committed shortly.

Comment 17 commit-hook 2025-03-06 18:38:19 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=53b8e4525065be37f4e80e478b15366960951327

commit 53b8e4525065be37f4e80e478b15366960951327
Author:     Charlie Li <vishwin@FreeBSD.org>
AuthorDate: 2025-03-06 18:35:03 +0000
Commit:     Charlie Li <vishwin@FreeBSD.org>
CommitDate: 2025-03-06 18:35:03 +0000

    textproc/libxslt: update to 1.1.42

    Changelog: https://gitlab.gnome.org/GNOME/libxslt/-/blob/v1.1.42/NEWS

    PR: 279741
    Reported by: diizzy
    exp-run by: antoine

 textproc/libxslt/Makefile  | 20 ++++++--------------
 textproc/libxslt/distinfo  |  8 +++++---
 textproc/libxslt/pkg-plist | 11 +++++------
 3 files changed, 16 insertions(+), 23 deletions(-)

Comment 18 Daniel Engberg 2025-03-06 18:53:31 UTC

You've missed at least one backport because of your stunt which you would've caught if you would've reviewed commit history and/or other distros.