https://pdr2.bofh.network/data/140-diizzy/libxml2-libxslt/logs/errors/libpki-0.9.2_5.log
Created attachment 252702 [details] patch for libpki
This should fix compilation against libxml2 >= 2.12
Created attachment 252703 [details] Patch (git diff) against ports tree Patch for security/libpki against current ports tree - bumps PORTSVERSION to 6 - adds a small patch to allow compiling with libxml2 > 2.12
Patch submitted upstream : https://github.com/openca/libpki/pull/90
Created attachment 252750 [details] Patch against current ports tree Well it seems my last version of the port ended up incomplete... I guess no one really tried to use it on FreeBSD 14. Here is a new version which should : - really fix the segfault which PORTREVISION 5 was supposed to fix (complementing the final incomplete patch with fixes to src/pki_x509.c which were discarded in the final version) - allowing build against libxml2-2.12+ (patching src/pki_config.c) Sorry for the mess...
Hi, So this should work on all supported versions incl 13.3? Thanks for having a look at this! Best regards, Daniel
..also, can you update upstream PR so we can pull it from there? Best regards, Daniel
Created attachment 252754 [details] Patch against current ports tree Hello, Unfortunately I haven't the setup to check that it runs properly on 13.3 but it should... the changes introduced to adapt to openssl3 are only activated if version matches, and the previous versions did work on 13.2. As for referring to an upstream PR, it would be tricky as a lot of changes have occurred in master since v0.9.2. The patch is in deed a modified cherry-pick from an upstream commit applied to a significantly modified master. Also I reviewed my patch and corrected it, new version attached. Tell me if you can figure a better way forward... Thanks Bruno
I checked that it does build and work om¨n 13.3, both with libxml2-2.11 and libxml2-2.13
Ok, thanks! Can you also update your PR on GitHub?
What do you mean ? As I explained above, I don't know how to craft a PR for the cherry-picked backported parts...
Ahh sorry, I'll have a look at this early next week. Thanks again!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=db203a9d7a6ddbf29c75006f6126e5e6274e85fa commit db203a9d7a6ddbf29c75006f6126e5e6274e85fa Author: Bruno Damour <bruno@ruomad.net> AuthorDate: 2024-08-25 13:13:07 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 13:13:22 +0000 security/libpki: Fix build with libxml2 2.13 Backports from upstream repo and adapted to current release PR: 279954 security/libpki/Makefile | 2 +- .../libpki/files/patch-src_pki__config.c (new) | 22 +++ security/libpki/files/patch-src_pki__x509.c (new) | 181 +++++++++++++++++++++ 3 files changed, 204 insertions(+), 1 deletion(-)
Committed, thanks!