Bug 279960 - deskutils/recoll: Fails to build with libxml2 2.13.1 and libxslt 1.1.41
Summary: deskutils/recoll: Fails to build with libxml2 2.13.1 and libxslt 1.1.41
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-24 18:06 UTC by Daniel Engberg
Modified: 2025-07-17 11:02 UTC (History)
3 users (show)

See Also:
mandree: maintainer-feedback-
mandree: merge-quarterly+


Attachments
Patch to add a couple of "const" qualifiers (1.08 KB, patch)
2025-06-07 20:36 UTC, George Mitchell
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-06-29 07:38:40 UTC
Outdated, like fixed upstream
It's now located at https://www.recoll.org/
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-06-29 07:39:04 UTC
typo, likely
Comment 3 George Mitchell 2025-06-07 20:36:54 UTC
Created attachment 261072 [details]
Patch to add a couple of "const" qualifiers

A couple of "xmlError *" declarations needed to be "const xmlError *" declarations.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2025-06-07 21:01:13 UTC
Upstream changes a few more bits but that's a newer codebase...
https://framagit.org/medoc92/recoll/-/commit/cf3cd5c830dfcb6e09073b56f827a2f9e094ea2e
Comment 5 Matthias Andree freebsd_committer freebsd_triage 2025-07-15 18:54:59 UTC
Invoking maintainer timeout, 38d.

This is what I was referring to in the other PR,  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279961
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-07-15 19:31:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=91f735e583b75db9061cc4b9bdba855c8bfd8b3a

commit 91f735e583b75db9061cc4b9bdba855c8bfd8b3a
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2025-07-15 19:26:09 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2025-07-15 19:31:01 +0000

    deskutils/recoll: fix largefile support in miniz.

    recoll ships with a utils/miniz component that doesn't know we
    have large file support on FreeBSD.  Use the apple code path for us,
    too, so it would use fseeko()/ftello() instead of printing this
    warning:

    Using fopen, ftello, fseeko, stat() etc. path for file I/O
    - this path may not support large files.

    Bump PORTREVISION.

    loosely related to
    PR:             279960
    Approved by:    portmgr@ (just-fix-it blanket approval)
    MFH:            2025Q3

 deskutils/recoll/Makefile                          |  6 +++---
 deskutils/recoll/files/patch-utils_miniz.cpp (new) | 15 +++++++++++++++
 2 files changed, 18 insertions(+), 3 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-07-15 19:31:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bf9552bffcb829ef3dc744be527f2b579251e419

commit bf9552bffcb829ef3dc744be527f2b579251e419
Author:     George Mitchell <george@m5p.com>
AuthorDate: 2025-06-07 20:33:00 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2025-07-15 19:31:01 +0000

    deskutils/recoll: unbreak with new libxml2 API

    which broke because the newer libxml2 error reporting callbacks
    now want functions that take const-qualified pointers.

    PR:             279960
    Approved by:    danfe@ (maintainer timeout, 38 days)
    Approved by:    portmgr@ (just-fix-it blanket approval)
    MFH:            2025Q3

    Not bumping PORTREVISION this only fixes the build,
    and we have one more fix coming up.

 .../recoll/files/patch-internfile_mh__xslt.cpp (new) | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-07-15 20:48:37 UTC
A commit in branch 2025Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=edb227697be5c91cf14f80d3abe11fb6ed1a4d4a

commit edb227697be5c91cf14f80d3abe11fb6ed1a4d4a
Author:     George Mitchell <george@m5p.com>
AuthorDate: 2025-06-07 20:33:00 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2025-07-15 19:32:00 +0000

    deskutils/recoll: unbreak with new libxml2 API

    which broke because the newer libxml2 error reporting callbacks
    now want functions that take const-qualified pointers.

    PR:             279960
    Approved by:    danfe@ (maintainer timeout, 38 days)
    Approved by:    portmgr@ (just-fix-it blanket approval)
    MFH:            2025Q3

    Not bumping PORTREVISION this only fixes the build,
    and we have one more fix coming up.

    (cherry picked from commit bf9552bffcb829ef3dc744be527f2b579251e419)

 .../recoll/files/patch-internfile_mh__xslt.cpp (new) | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
Comment 9 commit-hook freebsd_committer freebsd_triage 2025-07-15 20:48:38 UTC
A commit in branch 2025Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a1a0a460ba88875f44e7931a8a51c2191adc5e55

commit a1a0a460ba88875f44e7931a8a51c2191adc5e55
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2025-07-15 19:26:09 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2025-07-15 19:32:00 +0000

    deskutils/recoll: fix largefile support in miniz.

    recoll ships with a utils/miniz component that doesn't know we
    have large file support on FreeBSD.  Use the apple code path for us,
    too, so it would use fseeko()/ftello() instead of printing this
    warning:

    Using fopen, ftello, fseeko, stat() etc. path for file I/O
    - this path may not support large files.

    Bump PORTREVISION.

    loosely related to
    PR:             279960
    Approved by:    portmgr@ (just-fix-it blanket approval)
    MFH:            2025Q3

    (cherry picked from commit 91f735e583b75db9061cc4b9bdba855c8bfd8b3a)

 deskutils/recoll/Makefile                          |  6 +++---
 deskutils/recoll/files/patch-utils_miniz.cpp (new) | 15 +++++++++++++++
 2 files changed, 18 insertions(+), 3 deletions(-)
Comment 10 Matthias Andree freebsd_committer freebsd_triage 2025-07-15 20:49:48 UTC
Note that Recoll generally could so with an update, this version is almost three years old.
Comment 11 Matthias Andree freebsd_committer freebsd_triage 2025-07-15 21:11:22 UTC
Alexey, would you review the recoll upstream release notes and see if we should update after three years?
Comment 12 Alexey Dokuchaev freebsd_committer freebsd_triage 2025-07-17 11:02:00 UTC
(In reply to Matthias Andree from comment #11)

Yeah I have several updates planned since last August but never committed them, I'll pace myself now.