Bug 280510 - net/samba419: Fix building without bundled dependencies
Summary: net/samba419: Fix building without bundled dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on: tdb_1.4.9 devel/talloc→2.4.1 devel/tevent→0.15.0
Blocks: unbundled_samba419_by_default
  Show dependency treegraph
 
Reported: 2024-07-30 12:49 UTC by Mateusz Piotrowski
Modified: 2024-08-16 10:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mikael)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2024-07-30 12:49:24 UTC
Currently, the build of Samba 4.19 without the bundled libs does not work. It seems to be required, however, if we want to keep ports like security/sssd2 working.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-07-31 09:04:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1aa6d61564e1ebb6057b9fef14b5e0321f1516fc

commit 1aa6d61564e1ebb6057b9fef14b5e0321f1516fc
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-07-29 14:21:45 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-07-31 08:59:42 +0000

    databases/ldb28: Add a new version of ldb

    This port is based on ldb25. The changes are:

    - Fix checks for Python support

      The bsd.port.pre.mk was included too early and USES=python wasn't
      processed as expected. As a result, the checks for Python support were
      broken.

    - Switch from waf to configure and make.

      Upstream wants us to do it this way. Otherwise, the build system
      produces the following error message:

      > ===>  Configuring for ldb28-2.8.1
      > PYTHONHASHSEED=1 missing! Don't use waf directly, use ./configure and make!

      So, set HAS_CONFIGURE and BINARY_ALIAS to make the port build without
      waf.

    - Clean up the makefile (sort variables and fix indentation)

    - Drop the NO_PYTHON variable. It complicates the makefile
      unnecessarily. It is still possible to disable Python support by
      configuring the PYTHON3 option.

    - Use WITH_DEBUG instead of option DEBUG.

    - Enable PYTHON3 by default.

      The PYTHON3 option is required by net/samba419 to build without the
      bundled dependencies. The primary purpose of databases/ldb28 is to
      make it possible, so enable Python support by default.

    PR:             280510
    Sponsored by:   Klara, Inc.

 databases/Makefile                                 |   1 +
 databases/ldb28/Makefile (new)                     | 146 +++++++
 databases/ldb28/distinfo (new)                     |   3 +
 databases/ldb28/files/man/ldb.3 (new)              | 427 +++++++++++++++++++++
 databases/ldb28/files/man/ldbadd.1 (new)           |  78 ++++
 databases/ldb28/files/man/ldbdel.1 (new)           |  80 ++++
 databases/ldb28/files/man/ldbedit.1 (new)          | 111 ++++++
 databases/ldb28/files/man/ldbmodify.1 (new)        |  73 ++++
 databases/ldb28/files/man/ldbrename.1 (new)        |  81 ++++
 databases/ldb28/files/man/ldbsearch.1 (new)        |  91 +++++
 ...ch-buildtools_wafsamba_samba__autoconf.py (new) |  50 +++
 ...tch-buildtools_wafsamba_samba__install.py (new) |  11 +
 .../files/patch-buildtools_wafsamba_wscript (new)  |  22 ++
 .../ldb28/files/patch-include_ldb__module.h (new)  |  15 +
 .../patch-ldb_key_value__ldb_kv_cache.c (new)      |  13 +
 .../ldb28/files/patch-lib_replace_replace.c (new)  |  20 +
 .../ldb28/files/patch-lib_replace_wscript (new)    |  11 +
 databases/ldb28/files/patch-wscript (new)          |  40 ++
 databases/ldb28/pkg-descr (new)                    |   7 +
 19 files changed, 1280 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-07-31 09:04:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb7abac7e10aa0312303fd298eba7e92d6d7b4d8

commit fb7abac7e10aa0312303fd298eba7e92d6d7b4d8
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-07-30 12:23:51 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-07-31 09:00:41 +0000

    net/samba419: Update version requirements for talloc

    The configure step fails with the following message:

    > Checking for system talloc (>=2.4.1) : not found
    > ERROR: System library talloc of version 2.4.1 not found, and bundling disabled
    > ===>  Script "configure" failed unexpectedly.

    Update the required talloc version accordingly in the makefile.

    PR:             280510, 280509
    Sponsored by:   Klara, Inc.
    Approved by:    portmgr blanket

 net/samba419/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-07-31 09:04:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7378f1a62fae23ce1817085992e2823a572c162c

commit 7378f1a62fae23ce1817085992e2823a572c162c
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-07-30 12:50:53 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-07-31 09:01:54 +0000

    net/samba419: Update required version for tevent

    The configure step fails with:

    > Checking for system tevent (>=0.15.0) : not found
    > ERROR: System library tevent of version 0.15.0 not found, and bundling disabled
    > ===>  Script "configure" failed unexpectedly.

    PR:             280510, 280511
    Approved by:    portmgr blanket
    Sponsored by:   Klara, Inc.

 net/samba419/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-07-31 09:04:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cdfadb1eccd6af77b53cd92c8e6caf31c4174267

commit cdfadb1eccd6af77b53cd92c8e6caf31c4174267
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-07-30 16:30:09 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-07-31 09:02:36 +0000

    net/samba419: Update version checks for ldb; switch to ldb28

    Samba 4.19 requires ldb 2.8.1 or newer to build without bundled
    dependencies.

    PR:             280510
    Approved by:    portmgr blanket
    Sponsored by:   Klara, Inc.

 net/samba419/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 5 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-16 10:19:40 UTC
Samba 4.19 now builds with external, unbundled dependencies.