With clang 19, if a port uses simdjson.h, it leads to compile errors: In file included from /wrkdirs/usr/ports/sysutils/intel-pcm/work/pcm-202405/src/pcm-raw.cpp:31: /usr/local/include/simdjson.h:6156:13: error: no member named 'print_newline' in 'base_formatter<formatter>' 6156 | this->print_newline(); | ~~~~ ^ /usr/local/include/simdjson.h:6160:13: error: no member named 'print_indents' in 'base_formatter<formatter>' 6160 | this->print_indents(depth); | ~~~~ ^ /usr/local/include/simdjson.h:6164:13: error: no member named 'print_space' in 'base_formatter<formatter>' 6164 | this->print_space(); | ~~~~ ^ Upstream <https://github.com/simdjson/simdjson/commit/5d35e7ca> fixes this, but it does not directly add the change to the generated single header version of simdjson.h. So apply the fix to both the individual header and the amalgamated version.
Created attachment 252478 [details] devel/simdjson: fix build with clang 19
Looks good to me, please commit.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8c86705f8b3cead5d81271a071c331b619da4b8b commit 8c86705f8b3cead5d81271a071c331b619da4b8b Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-08-03 13:58:40 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-08-16 15:33:49 +0000 devel/simdjson: fix build with clang 19 With clang 19, if a port uses simdjson.h, it leads to compile errors: In file included from /wrkdirs/usr/ports/sysutils/intel-pcm/work/pcm-202405/src/pcm-raw.cpp:31: /usr/local/include/simdjson.h:6156:13: error: no member named 'print_newline' in 'base_formatter<formatter>' 6156 | this->print_newline(); | ~~~~ ^ /usr/local/include/simdjson.h:6160:13: error: no member named 'print_indents' in 'base_formatter<formatter>' 6160 | this->print_indents(depth); | ~~~~ ^ /usr/local/include/simdjson.h:6164:13: error: no member named 'print_space' in 'base_formatter<formatter>' 6164 | this->print_space(); | ~~~~ ^ Upstream <https://github.com/simdjson/simdjson/commit/5d35e7ca> fixes this, but it does not directly add the change to the generated single header version of simdjson.h. So apply the fix to both the individual header and the amalgamated version. PR: 280590 Approved by: olevole@olevole.ru (maintainer) MFH: 2024Q3 devel/simdjson/Makefile | 1 + ...patch-include_simdjson_dom_serialization.h (new) | 21 +++++++++++++++++++++ .../files/patch-singleheader_simdjson.h (new) | 21 +++++++++++++++++++++ 3 files changed, 43 insertions(+)
A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=52a101b577a5d2987dd7d8010cdfd20fac687d1d commit 52a101b577a5d2987dd7d8010cdfd20fac687d1d Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-08-03 13:58:40 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-08-16 15:43:50 +0000 devel/simdjson: fix build with clang 19 With clang 19, if a port uses simdjson.h, it leads to compile errors: In file included from /wrkdirs/usr/ports/sysutils/intel-pcm/work/pcm-202405/src/pcm-raw.cpp:31: /usr/local/include/simdjson.h:6156:13: error: no member named 'print_newline' in 'base_formatter<formatter>' 6156 | this->print_newline(); | ~~~~ ^ /usr/local/include/simdjson.h:6160:13: error: no member named 'print_indents' in 'base_formatter<formatter>' 6160 | this->print_indents(depth); | ~~~~ ^ /usr/local/include/simdjson.h:6164:13: error: no member named 'print_space' in 'base_formatter<formatter>' 6164 | this->print_space(); | ~~~~ ^ Upstream <https://github.com/simdjson/simdjson/commit/5d35e7ca> fixes this, but it does not directly add the change to the generated single header version of simdjson.h. So apply the fix to both the individual header and the amalgamated version. PR: 280590 Approved by: olevole@olevole.ru (maintainer) MFH: 2024Q3 (cherry picked from commit 8c86705f8b3cead5d81271a071c331b619da4b8b) devel/simdjson/Makefile | 1 + ...patch-include_simdjson_dom_serialization.h (new) | 21 +++++++++++++++++++++ .../files/patch-singleheader_simdjson.h (new) | 21 +++++++++++++++++++++ 3 files changed, 43 insertions(+)