Bug 280677 - audio/openal-soft: fix build with clang 19
Summary: audio/openal-soft: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks: 280562
  Show dependency treegraph
 
Reported: 2024-08-07 18:44 UTC by Dimitry Andric
Modified: 2024-08-22 19:34 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (multimedia)


Attachments
audio/openal-soft: fix build with clang 19 (2.12 KB, patch)
2024-08-07 18:44 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-08-07 18:44:16 UTC
With clang 19 and gcc 15, audio/openal-soft fails to compile, with an
error similar to:

    /wrkdirs/usr/ports/audio/openal-soft/work/openal-soft-1.21.1/common/aloptional.h:119:48: error: no member named 'mValue' in 'optional<T>'; did you mean 'value'?
      119 |     const T& operator*() const& { return this->mValue; }
          |                                                ^~~~~~
          |                                                value
    /wrkdirs/usr/ports/audio/openal-soft/work/openal-soft-1.21.1/common/aloptional.h:127:8: note: 'value' declared here
      127 |     T& value() & { return mStore.mValue; }
          |        ^

Upstream commit <https://github.com/kcat/openal-soft/440b5970> fixes
this this, so add it as a PATCHFILES entry in the Makefile, until a
newer version of openal-soft is imported.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-08-07 18:44:39 UTC
Created attachment 252597 [details]
audio/openal-soft: fix build with clang 19
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-08-22 19:11:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6832814ba1f9a7dfa39fcc1cba8781ecfea6d568

commit 6832814ba1f9a7dfa39fcc1cba8781ecfea6d568
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-07 18:43:03 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-22 19:10:18 +0000

    audio/openal-soft: fix build with clang 19

    With clang 19 and gcc 15, audio/openal-soft fails to compile, with an
    error similar to:

        /wrkdirs/usr/ports/audio/openal-soft/work/openal-soft-1.21.1/common/aloptional.h:119:48: error: no member named 'mValue' in 'optional<T>'; did you mean 'value'?
          119 |     const T& operator*() const& { return this->mValue; }
              |                                                ^~~~~~
              |                                                value
        /wrkdirs/usr/ports/audio/openal-soft/work/openal-soft-1.21.1/common/aloptional.h:127:8: note: 'value' declared here
          127 |     T& value() & { return mStore.mValue; }
              |        ^

    Upstream commit <https://github.com/kcat/openal-soft/440b5970> fixes
    this this, so add it as a PATCHFILES entry in the Makefile, until a
    newer version of openal-soft is imported.

    PR:             280677
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q3

 audio/openal-soft/Makefile | 3 +++
 audio/openal-soft/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-22 19:12:33 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=11e3f2db8fdf988339de1272aa9ea66235b2c44b

commit 11e3f2db8fdf988339de1272aa9ea66235b2c44b
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-07 18:43:03 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-22 19:11:40 +0000

    audio/openal-soft: fix build with clang 19

    With clang 19 and gcc 15, audio/openal-soft fails to compile, with an
    error similar to:

        /wrkdirs/usr/ports/audio/openal-soft/work/openal-soft-1.21.1/common/aloptional.h:119:48: error: no member named 'mValue' in 'optional<T>'; did you mean 'value'?
          119 |     const T& operator*() const& { return this->mValue; }
              |                                                ^~~~~~
              |                                                value
        /wrkdirs/usr/ports/audio/openal-soft/work/openal-soft-1.21.1/common/aloptional.h:127:8: note: 'value' declared here
          127 |     T& value() & { return mStore.mValue; }
              |        ^

    Upstream commit <https://github.com/kcat/openal-soft/440b5970> fixes
    this this, so add it as a PATCHFILES entry in the Makefile, until a
    newer version of openal-soft is imported.

    PR:             280677
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q3

    (cherry picked from commit 6832814ba1f9a7dfa39fcc1cba8781ecfea6d568)

 audio/openal-soft/Makefile | 3 +++
 audio/openal-soft/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)