Bug 280769 (DEFAULT_VERSIONS=samba=4.19) - net/samba419: Switch the default version of Samba to 4.19
Summary: net/samba419: Switch the default version of Samba to 4.19
Status: In Progress
Alias: DEFAULT_VERSIONS=samba=4.19
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Samba Team
URL:
Keywords:
: 276261 (view as bug list)
Depends on: net/samba419_time_machine_posix_rename samba_4.19.8_1_broken_replication
Blocks: deprecate_samba416 281718 276261
  Show dependency treegraph
 
Reported: 2024-08-12 12:03 UTC by Mateusz Piotrowski
Modified: 2024-10-27 15:57 UTC (History)
6 users (show)

See Also:
0mp: maintainer-feedback+
antoine: exp-run+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-12 12:03:36 UTC
4.16 is no longer supported. It is time to move to Samba 4.19 or newer.
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-16 20:04:48 UTC
*** Bug 276261 has been marked as a duplicate of this bug. ***
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-16 20:36:32 UTC
I don't see any reasons not to move to version 4.19 soon, e.g., next week. Version 4.16 is built with bundled dependencies by default at the moment so it conflicts with all kinds of other ports anyway. Any reason not to switch next soon, e.g., next week?
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-09-06 09:26:07 UTC
Hello portmgr@!

We would like to request an exp-run before the switch of the default Samba to 4.19.
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-09-06 10:54:40 UTC
For reference, here's a commit of the previous version switch:

https://cgit.freebsd.org/ports/commit/?id=fabf8b5d116512e2c0339c1a17340370d753e271
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2024-09-10 11:37:04 UTC
Exp-run looks fine
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-09-10 11:40:31 UTC
Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-09-10 11:44:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0d1aba712a301ddb1e8b7ccbf3acc721dc3c90e8

commit 0d1aba712a301ddb1e8b7ccbf3acc721dc3c90e8
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-09-10 11:39:07 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-09-10 11:43:35 +0000

    Mk/bsd.default-versions.mk: Switch SAMBA default to 4.19

    PR:             280769
    Exp-run by:     antoine
    Approved by:    portmgr (exp-run), samba (0mp)
    Sponsored by:   Klara, Inc.

 Mk/bsd.default-versions.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 David Chisnall freebsd_committer freebsd_triage 2024-09-10 13:36:38 UTC
Does https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281360 not block this?
Comment 9 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-09-10 13:49:20 UTC
(In reply to David Chisnall from comment #8)

I'm looking for resources to address that bug.

In the meantime, we needed to move to 4.19 anyway as 4.16 is deprecated upstream and not receiving security updates anymore.
Comment 10 David Chisnall freebsd_committer freebsd_triage 2024-09-10 14:08:02 UTC
(In reply to Mateusz Piotrowski from comment #9)

Please can you at least make sure that there's an UPDATING message that says that the new one is completely broken for any users of Time Machine and they should revert to samba416 or suffer data loss?
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-09-10 15:09:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=550e0299804acaa7d73f6744c14b0e0f1a598d9c

commit 550e0299804acaa7d73f6744c14b0e0f1a598d9c
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-09-10 15:01:20 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-09-10 15:07:16 +0000

    Mk/bsd.default-versions.mk: Revert the SAMBA default from 4.19 back to 4.16

    This reverts commit 0d1aba712a301ddb1e8b7ccbf3acc721dc3c90e8.

    A recently reported bug 281360 might suggests that Samba 4.19 does not
    work with Time Machine and might result in data loss.

    Let's revert the default version bump for now until we have more time to
    plan how we are going to deal with issue. A potential solution would be
    to disable Time Machine support in 4.19 for now.

    PR:             280769 281360
    Reported by:    theraven
    Approved by:    samba (0mp)

 Mk/bsd.default-versions.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 12 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-09-10 15:15:25 UTC
(In reply to David Chisnall from comment #10)
Hello David,

Thank you for making clear how serious 281360 is. I've reverted the version change.

We'll need to think of a different update plan. We either fix 281360 or disable the Time Machine support, which is obviously a poor solution moving forward.

I'm assigning this issue back to the Samba Team. And marking 281360 as a blocker back again.