After updating Nginx to version 1.26.1, I encountered a critical startup issue. The error message indicates a failure to load the 'resty.core' module, as outlined below: nginx: [alert] failed to load the 'resty.core' module (https://github.com/openresty/lua-resty-core); ensure you are using an OpenResty release from https://openresty.org/en/download.html (reason: /usr/local/share/lua/5.1/resty/core/base.lua:24: ngx_http_lua_module 0.10.26 required) in /usr/local/etc/nginx/nginx.conf:1060
Created attachment 252847 [details] Patch to update lua-resty-core
(In reply to Christos Chatzaras from comment #1) Maintainer is zi@ Waiting for his feedbak
(In reply to Jochen Neumeister from comment #2) I apologize for mistakenly opening the PR under www/nginx.
Seriously, again? I just ran into this again. How hard can it be to understand that neither this line in www/*nginx* LUA_GH_TUPLE= openresty:lua-nginx-module:v0.10.26:lua nor www/lua-resty-core can be updated on its own. They always need to be kept in sync. There was even a reminder in 280740 which pointed to 280739 that www/lua-resty-core also needs an update. And it was explained in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277145 the last time it happened. With all that, it's kind of "funny" to put the blame on zi@ I'll wait for zi@ to chime in. Someone needs to put a big fat comment in the nginx and www/lua-resty-core ports to not update one without the other. Whoever needs an immediate fix, what I did was "pkg delete -f nginx" and pkg add of the previous version I had in /var/cache/pkg/. e.g. "pkg add nginx-1.26.1,3.pkg"
You both have my approval to bump the version on this port whenever is required. I'm happy to commit a comment in the Makefile for lua-resty-core if there are any concerns about the ongoing approval. If updating this port at the same time as nginx is not feasible, an email to me would at least help me get the ball rolling. Approved.
joneum, In PR #277145, I asked for approval to update the nginx module: > Can I have future approval for updates to the ngx_http_lua_module to ensure these are always in sync? It seems like this would make sense and that whoever is going to update it NEEDS to update both at the same time.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8cec524d37fdb2d7dfef5c1ba0c94990192731b4 commit 8cec524d37fdb2d7dfef5c1ba0c94990192731b4 Author: Ryan Steinmetz <zi@FreeBSD.org> AuthorDate: 2024-08-18 14:40:16 +0000 Commit: Ryan Steinmetz <zi@FreeBSD.org> CommitDate: 2024-08-18 14:40:16 +0000 www/lua-resty-core: Update to 0.1.29 PR: 280882 Submitted by: chris@cretaforce.gr www/lua-resty-core/Makefile | 2 +- www/lua-resty-core/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
(In reply to Ryan Steinmetz from comment #6) Yes, feel free, to Update this for all me nginx ports in the future :-)
How do we ensure that someone does not update the lua module in nginx without updating lua-resty-core?
Adding a comment in all the Makefiles saying so like the line before the version that needs updating.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d08dcf215d0bae3642cb0837f3272070188908f2 commit d08dcf215d0bae3642cb0837f3272070188908f2 Author: Ryan Steinmetz <zi@FreeBSD.org> AuthorDate: 2024-08-20 13:50:13 +0000 Commit: Ryan Steinmetz <zi@FreeBSD.org> CommitDate: 2024-08-20 13:53:15 +0000 www/(nginx|nginx-devel|lua-resty-core): Document lua module dependencies/alternate maintainers PR: 280882, 277145 www/lua-resty-core/Makefile | 2 ++ www/nginx-devel/Makefile.extmod | 1 + www/nginx/Makefile.extmod | 1 + 3 files changed, 4 insertions(+)
(In reply to Mathieu Arnold from comment #10) Great idea! I've added notes to www/(nginx|nginx-devel)/Makefile.extmod for this and I've also added a comment to www/lua-resty-core noting that flo/joneum/osa all have automatic approval for updating that port as well. Hopefully this ensures that things stay in sync and we don't break any of our users again!