Bug 281224 - cad/graywolf: Fails to build with GCC 14: error: implicit declaration of function 'get_global_pos' [-Wimplicit-function-declaration]
Summary: cad/graywolf: Fails to build with GCC 14: error: implicit declaration of func...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://pkg-status.freebsd.org/gohan0...
Keywords:
Depends on:
Blocks: 281091
  Show dependency treegraph
 
Reported: 2024-09-03 12:42 UTC by Lorenzo Salvadore
Modified: 2024-09-05 19:57 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Fix graywolf with GCC 14 (846 bytes, patch)
2024-09-05 10:06 UTC, Lorenzo Salvadore
salvadore: maintainer-approval? (yuri)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2024-09-03 12:42:56 UTC
Build fails with GCC 14. This blocks GCC_DEFAULT update to GCC 14.

FAILED: src/twmc/CMakeFiles/TimberWolfMC.dir/graphics.c.o 
/usr/local/bin/gcc14 -DSIZEOF_VOID_P="64 -Wno-implicit-function-declaration" -I/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/include -I/wrkdirs/usr/ports/cad/graywolf/work/.build/include -I/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/. -O2 -pipe  -fcommon -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc14 -fno-strict-aliasing -O2 -pipe  -fcommon -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc14 -fno-strict-aliasing  -DNDEBUG -MD -MT src/twmc/CMakeFiles/TimberWolfMC.dir/graphics.c.o -MF src/twmc/CMakeFiles/TimberWolfMC.dir/graphics.c.o.d -o src/twmc/CMakeFiles/TimberWolfMC.dir/graphics.c.o -c /wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c: In function 'process_graphics':
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:450:17: error: implicit declaration of function 'get_global_pos' [-Wimplicit-function-declaration]
  450 |                 get_global_pos( selectCellS, &x1, &y1, &x2, &y2 ) ;
      |                 ^~~~~~~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c: In function 'draw_the_data':
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:745:9: error: implicit declaration of function 'Ymst_init' [-Wimplicit-function-declaration]
  745 |         Ymst_init( get_max_pin() ) ;
      |         ^~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:745:20: error: implicit declaration of function 'get_max_pin' [-Wimplicit-function-declaration]
  745 |         Ymst_init( get_max_pin() ) ;
      |                    ^~~~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:751:13: error: implicit declaration of function 'Ymst_clear' [-Wimplicit-function-declaration]
  751 |             Ymst_clear() ;
      |             ^~~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:753:17: error: implicit declaration of function 'Ymst_addpt' [-Wimplicit-function-declaration]
  753 |                 Ymst_addpt( curPin->xpos, curPin->ypos ) ;
      |                 ^~~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:755:13: error: implicit declaration of function 'Ymst_draw' [-Wimplicit-function-declaration]
  755 |             Ymst_draw() ;
      |             ^~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:757:9: error: implicit declaration of function 'Ymst_free' [-Wimplicit-function-declaration]
  757 |         Ymst_free() ;
      |         ^~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:825:9: error: implicit declaration of function 'Ygrid_getx' [-Wimplicit-function-declaration]
  825 |         Ygrid_getx( &grid, &offset ) ;
      |         ^~~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:828:9: error: implicit declaration of function 'Ygridx' [-Wimplicit-function-declaration]
  828 |         Ygridx ( &max ) ;
      |         ^~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:835:9: error: implicit declaration of function 'Ygrid_gety' [-Wimplicit-function-declaration]
  835 |         Ygrid_gety( &grid, &offset ) ;
      |         ^~~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:837:9: error: implicit declaration of function 'Ygridy' [-Wimplicit-function-declaration]
  837 |         Ygridy ( &max ) ;
      |         ^~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c: In function 'twmc_draw_a_cell':
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:962:21: error: implicit declaration of function 'wireestxy2' [-Wimplicit-function-declaration]
  962 |                     wireestxy2( pos,xc,yc ) ;
      |                     ^~~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:964:21: error: implicit declaration of function 'wireestxy' [-Wimplicit-function-declaration]
  964 |                     wireestxy( pos,xc,yc ) ;
      |                     ^~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c: In function 'edit_cell':
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:1233:18: error: implicit declaration of function 'check_valid_orient' [-Wimplicit-function-declaration]
 1233 |         status = check_valid_orient( ptr ) ;
      |                  ^~~~~~~~~~~~~~~~~~
/wrkdirs/usr/ports/cad/graywolf/work/graywolf-0.1.6-4-gf47937b/src/twmc/graphics.c:1260:17: error: implicit declaration of function 'delete_fix_constraint' [-Wimplicit-function-declaration]
 1260 |                 delete_fix_constraint( cell ) ;
      |                 ^~~~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.
*** Error code 1

Stop.
make: stopped in /usr/ports/cad/graywolf

Full log: https://pkg-status.freebsd.org/gohan04/data/140amd64-default-foo/2024-08-29_19h57m48s/logs/errors/graywolf-0.1.6.4_4.log

Useful link: https://gcc.gnu.org/gcc-14/porting_to.html
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2024-09-05 10:06:09 UTC
Created attachment 253346 [details]
Fix graywolf with GCC 14

This patch should fix the issue. Tested with poudriere.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2024-09-05 19:56:37 UTC
Fixed.
Thanks for the patch!
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-05 19:57:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6bc0a3cd18347249dddc4b92a272b5904f88c885

commit 6bc0a3cd18347249dddc4b92a272b5904f88c885
Author:     Lorenzo Salvadore <salvadore@freebsd.org>
AuthorDate: 2024-09-05 19:55:42 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-09-05 19:56:41 +0000

    cad/graywolf: Fix build with gcc14

    PR:             281224

 cad/graywolf/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)