Bug 281447 - databases/libiodbc: Use release tarball and improve port
Summary: databases/libiodbc: Use release tarball and improve port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-11 21:27 UTC by Daniel Engberg
Modified: 2024-10-09 19:50 UTC (History)
2 users (show)

See Also:
makc: maintainer-feedback+

Attachments
Patch for libiodbc (3.11 KB, patch)
2024-09-11 21:27 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-09-11 21:27:35 UTC 
Created attachment 253505 [details]
Patch for libiodbc

* Switch to using upstream release tarball
* Adjust port Makefile layout

Compile tested on FreeBSD 14.1-RELEASE (amd64) (make, make check-plist)

Poudriere testport OK 13.3-RELEASE (amd64)
Poudriere testport OK 14.0-RELEASE (i386)
Poudriere testport OK 14.0-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)
Comment 1 Max Brazhnikov freebsd_committer freebsd_triage 2024-09-13 17:00:22 UTC 
Looks fine. Btw this port is no longer used by Qt/KDE, I'd pass the maintainership to someone interested or to ports@.
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2024-09-14 05:58:04 UTC 
I'm sorry, but your gratuitous whitespace changes in the LICENSE block of the Makefile don't contribute to code beautification in any way and, quite frankly, make it look remarkably uglier than it already is with 3 variations of spacing instead of the previous two. Either align the spacing in the block to make it more readable or just leave it as is to avoid unnecessary churn. Simply eliminating the tab in LICENSE_FILE_BSD3CLAUS would be enough to satisfy our linting tools and most human pedantry.

Otherwise, I'm in full agreement with makc. This port no longer plays any role in the KDE universe and would probably be better serviced by a maintainer of one of its current consumers.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-09 19:44:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7a74a53771bc568f90e14cbbadc528eed3a81fe9

commit 7a74a53771bc568f90e14cbbadc528eed3a81fe9
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-10-09 19:33:07 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-10-09 19:43:26 +0000

    databases/libiodbc: Use release tarball, improve port and return to pool

    * Switch to using upstream release tarball
    * Adjust port Makefile layout
    * Return to pool

    PR:             281447
    Approved by:    kde (makc and jhale)

 databases/libiodbc/Makefile                       | 16 +++++++---------
 databases/libiodbc/distinfo                       |  6 +++---
 databases/libiodbc/files/patch-Makefile.am (gone) | 11 -----------
 databases/libiodbc/files/patch-Makefile.in (new)  | 11 +++++++++++
 4 files changed, 21 insertions(+), 23 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-10-09 19:50:21 UTC 
Commmited with changes as suggested, thanks!