Created attachment 254258 [details] [PATCH] print/rtf2latex2e: update 2.2.2 → 2.2.3 Release 2-2-3 adds the option to delimit LaTeX equations by \(...\) instead of $...$ and \[...\] instead of $$...$$
Martin, do you approve this patch?
Where is the OK button?
(In reply to martin.dieringer from comment #2) You approved at 2024-10-15 15:42:39 CEST but remove the flag at 2024-10-21 06:36:17 CEST. So the removing was a mistake and the patch is accepted.
I got an email after I approved.
(In reply to martin.dieringer from comment #4) Okay, no problem. I test it...
The 'make test' fails: 4545717175756161747469696f6f6e6e2e2e444453534d4d545433333636000 000000000000000000180000d0cf11e0gmake[1]: *** [Makefile:86: multiline.tex] Abort trap (core dumped) gmake[1]: Leaving directory '/wrkdirs/usr/ports/print/rtf2latex2e/work/rtf2latex2e-2-2-3/test' Could you please check?
Sure, I'll check it.
Thanks for pointing to this. I've checked both 2.2.2 from ports and my proposed 2.2.3 and found 2.2.2 to also fail the same test, with message mentioning the same code line: Processing multiline.rtf gmake[1]: *** [Makefile:86: multiline.tex] Abort trap (core dumped) gmake[1]: Leaving directory '/usr/ports/default/print/rtf2latex2e/work/rtf2latex2e-2-2-2/test' gmake: *** [Makefile:151: test] Error 2 *** Error code 1 So it was already broken. The only reason it appeared now and not before was me adding TEST_TARGET=test line to Makefile, making tests actually run. I think it still may be updated, possibly even with TEST_TARGET added, as nothing bad actually happened: the situation hadn't become any worse than it already was. And what do you think?
Yes, ignore the test, or remove the port altogether (the source is of 2016)?
(In reply to Älven from comment #8) Could you patch the source to skip this test? Or can use TESTING_UNSAFE (https://cgit.freebsd.org/ports/tree/Mk/Features/testing.mk#n7).
(In reply to Zsolt Udvari from comment #10) > Or can use TESTING_UNSAFE Thank you for the advice! :) I'll do this exactly. Glad to know it's possible and how to do it should I need it for some other ports too.
Created attachment 254542 [details] [PATCH] print/rtf2latex2e: update 2.2.2 → 2.2.3 + Skip failing test
Created attachment 254552 [details] remove multiline.tex from test I'd suggest remove multiline.tex from tests. Now it runs fine.
Comment on attachment 254552 [details] remove multiline.tex from test Better skip than forge the test
(In reply to martin.dieringer from comment #14) A partial test is better than no test (document why we skip). The 2.2.2 fails on this file too.
(In reply to martin.dieringer from comment #14) Martin, what do you think? Do you want skip the whole test?