Bug 282139 - security/step-certificates: rcorder requirement incorrect (GitHub pull request for fix included)
Summary: security/step-certificates: rcorder requirement incorrect (GitHub pull reques...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-16 14:08 UTC by Robert William Vesterman
Modified: 2025-04-15 11:40 UTC (History)
4 users (show)

See Also:
mw: maintainer-feedback+


Attachments
patch file (1.96 KB, patch)
2024-10-16 19:12 UTC, Robert William Vesterman
jbo: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert William Vesterman 2024-10-16 14:08:22 UTC
Hi,

When I run rcorder, I get the following warning:

# rcorder /usr/local/etc/rc.d/* /etc/rc.d/* >/dev/null
rcorder: requirement `networking' in file `/usr/local/etc/rc.d/step-ca' has no providers.

I believe that the correct requirement is "NETWORKING", not "networking". I made that change, and the problem went away.

I have made a pull request on GitHub with this change:

https://github.com/freebsd/freebsd-ports/pull/311

Please let me know if there is anything else I should do regarding this, or if I've screwed up somehow (I'm pretty new to both making changes to the ports system and to using GitHub to do anything more than commenting and whatnot). Thanks.
Comment 1 Joel Bodenmann freebsd_committer freebsd_triage 2024-10-16 18:23:07 UTC
While we wait for maintainer feedback: Can you please attach the patch here? Also, you should bump PORTREVISION.
Comment 2 Robert William Vesterman 2024-10-16 19:12:12 UTC
Created attachment 254292 [details]
patch file

Patch file for this change. Not sure if it's the format expected here -- I just asked GitHub to create it for me, and then manually modified it to replace the emoji smiley face I had put in a commit message with a :P after Bugzilla rejected it due to that.

Like I said, I'm new to all this, so if it should be in some other format or I've screwed it up in some other way, please let me know. Thanks.
Comment 3 Robert William Vesterman 2024-10-16 19:12:53 UTC
(In reply to Joel Bodenmann from comment #1)

Thanks!
Comment 4 Robert William Vesterman 2024-10-16 19:17:06 UTC
(In reply to Joel Bodenmann from comment #1)

Oh no, and I just noticed I got your name wrong ("Bondenmann") in that commit message. Sorry!
Comment 5 Markus Wipp 2024-10-16 19:19:57 UTC
Comment on attachment 254292 [details]
patch file

Just gave my approval. The change is ok from my side
Comment 6 Siva Mahadevan freebsd_triage 2025-04-02 18:10:04 UTC
Any updates on merging this? It seems like maintainer approval has been given for the patch.
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-04-15 11:38:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a25053963a9f3df3dca02457244823dc45dd9e7b

commit a25053963a9f3df3dca02457244823dc45dd9e7b
Author:     Robert William Vesterman <bob@vesterman.com>
AuthorDate: 2024-10-16 13:54:55 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2025-04-15 11:37:37 +0000

    security/step-certificates: Fix REQUIRE in the rc script

    PR:             282139
    Approved by:    Markus Wipp <mw@wipp.bayern> (maintainer)
    Pull Request:   https://github.com/freebsd/freebsd-ports/pull/311

 security/step-certificates/Makefile         | 2 +-
 security/step-certificates/files/step_ca.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)