As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes archivers/pbzip2 to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ ./BZ2StreamScanner.h:128:25: note: in instantiation of template class 'std::basic_string<unsigned char>' requested here 128 | basic_string<CharType> _bz2Header; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ This can be fixed by defining `_bz2Header` and `_bz2HeaderZero` as `std::vector<CharType>` instead of `std::basic_string<CharType>`. It requieres a few other changes, such as replacing `operator=` with `assign`, and `compare` with `equal`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
Created attachment 254923 [details] archivers/pbzip2: fix build with libc++ 19
Thanks for submitting the patch. I will review and test this later. Has this also been submitted upstream?
(In reply to Babak Farrokhi from comment #2) No, I'm fixing a lot of ports and going after all these upstreams is too much. :)
Ah, see https://bugs.launchpad.net/pbzip2/+bug/2081588
Judging from the launchpad page, the last commits on trunk were in 2011, so it seems rather dead...
Fair enough. Thanks for doing the work. I will commit this later today.
approved. please feel free to commit.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=29c80f114ea6cc60be39502339572af8c35ac440 commit 29c80f114ea6cc60be39502339572af8c35ac440 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-11-03 23:24:58 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-11-07 17:42:48 +0000 archivers/pbzip2: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes archivers/pbzip2 to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ ./BZ2StreamScanner.h:128:25: note: in instantiation of template class 'std::basic_string<unsigned char>' requested here 128 | basic_string<CharType> _bz2Header; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ This can be fixed by defining `_bz2Header` and `_bz2HeaderZero` as `std::vector<CharType>` instead of `std::basic_string<CharType>`. It requieres a few other changes, such as replacing `operator=` with `assign`, and `compare` with `equal`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 282528 Approved by: farrokhi (maintainer) MFH: 2024Q4 .../pbzip2/files/patch-BZ2StreamScanner.cpp (new) | 49 ++++++++++++++++++++++ .../pbzip2/files/patch-BZ2StreamScanner.h (new) | 22 ++++++++++ 2 files changed, 71 insertions(+)
A commit in branch 2024Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=04c6d15b6efeae4660e29027bd7a0368255f18f5 commit 04c6d15b6efeae4660e29027bd7a0368255f18f5 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-11-03 23:24:58 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-11-07 17:44:18 +0000 archivers/pbzip2: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes archivers/pbzip2 to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ ./BZ2StreamScanner.h:128:25: note: in instantiation of template class 'std::basic_string<unsigned char>' requested here 128 | basic_string<CharType> _bz2Header; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ This can be fixed by defining `_bz2Header` and `_bz2HeaderZero` as `std::vector<CharType>` instead of `std::basic_string<CharType>`. It requieres a few other changes, such as replacing `operator=` with `assign`, and `compare` with `equal`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 282528 Approved by: farrokhi (maintainer) MFH: 2024Q4 (cherry picked from commit 29c80f114ea6cc60be39502339572af8c35ac440) .../pbzip2/files/patch-BZ2StreamScanner.cpp (new) | 49 ++++++++++++++++++++++ .../pbzip2/files/patch-BZ2StreamScanner.h (new) | 22 ++++++++++ 2 files changed, 71 insertions(+)