Created attachment 255452 [details] Patch for fastfetch * Link libs instead of relying on dlopen * Disable LTO (increases binary size) * Use helpers when possible * Sort menu items in Makefile * Add IMPLIES for a few options where they pull in matching deps Poudriere testport OK, 13.4-RELEASE (amd64), 14.1-RELEASE (amd64)
Do not add all the dependencies to LIB_DEPENDS. This will bring a lot of library dependencies to users. Project's intention is to use dlopen and let users install whatever they want. This is why all the dependencies are only build-time. Adding -lelf to LDFLAGS is ok, since it's in base.
We don't track build deps which may result in (silent) breakage due to library API/ABI mismatches and that also seem to be of concern in some other repos. A tradeoff would be using flavours such as lite/light and full. Best regards, Daniel
In that case, PORTREVISION should be bumped, when libraries are upgraded. Adding all the libraries to LIB_DEPENDS is not a valid solution, it will bring a lot of unnecessary dependencies. Just recently, I found an old PR (still open), that I closed, where a user reported he was running a headless system and didn't want graphics dependencies. Another thing, fastfetch is has new versions quite often and in case there are some breakages due to upgraded libraries, new version will be rebuilt with the current libraries anyway.
^Triage: in the past 18 months, the ports tree has changed enough where these patches no longer apply. As bugmeister, I am going to declare this as OBE because the maintainer is not interested in changing the port in this way.