Bug 283175 - [NEW PORT] graphics/materialx: MaterialX is an open standard for the exchange of rich material.
Summary: [NEW PORT] graphics/materialx: MaterialX is an open standard for the exchang...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Juraj Lutter
URL: https://github.com/AcademySoftwareFou...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-07 07:18 UTC by Martin Filla
Modified: 2025-12-02 20:47 UTC (History)
2 users (show)

See Also:


Attachments
0001-materialx-new-port.patch (58.73 KB, patch)
2024-12-07 07:18 UTC, Martin Filla
no flags Details | Diff
0001-materialx-new-port.patch (38.02 KB, patch)
2024-12-08 09:41 UTC, Martin Filla
no flags Details | Diff
materialx.tar.xz (5.38 KB, application/x-xz)
2024-12-22 19:18 UTC, Martin Filla
no flags Details
0001-materialx-new-port.patch (59.36 KB, patch)
2025-03-10 19:50 UTC, Martin Filla
no flags Details | Diff
/0001-materialx-new-port.patch (61.82 KB, patch)
2025-11-24 18:49 UTC, Martin Filla
freebsd: maintainer-approval+
Details | Diff
0001-materialx-new-port.patch (61.86 KB, patch)
2025-11-24 19:52 UTC, Martin Filla
freebsd: maintainer-approval+
Details | Diff
0001-materialx-new-port.patch (62.77 KB, patch)
2025-11-25 22:29 UTC, Martin Filla
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Filla 2024-12-07 07:18:16 UTC
Created attachment 255680 [details]
0001-materialx-new-port.patch

Hi,
this is new port materialx. MaterialX is an open standard for the exchange
of rich material and look-development content across applications and renderers.
The port is for the gaffer.I tested in poudriere.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-12-07 18:28:20 UTC
Outdated patch?
https://github.com/AcademySoftwareFoundation/MaterialX/releases

Is there a reason to why we can't upstream release archive?
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

Explain reasoning behind DISTVERSIONSUFFIX

Why port locked to Python 3.11?

GH_TUPLE+= should be GH_TUPLE= (see Porters Handbook) if needed because of the above

CMAKE_ARGS+= should be CMAKE_ARGS and you can probably use CMAKE_ON/OFF instead

Why is CMAKE_INSTALL_PREFIX defined?

Sort Makefile entries, why is USE_GL= USE_XORG= placed at the end?

${CP} shouldn't be used in do-install, see Porters Handbook

Overall I'd say no to adding more ports for you to maintain given that you a bunch outdated without patches already.
https://portscout.freebsd.org/freebsd@sysctl.cz.html
Comment 2 Martin Filla 2024-12-07 20:52:53 UTC
(In reply to Daniel Engberg from comment #1)
Port maintenance: I do actively maintain my ports, but I’ve been having issues with Portfallout emails not reaching me. This makes it harder to address issues promptly. I’ll look into resolving this to ensure I stay on top of any problems.

Waterfox: I acknowledge that the current state of the Waterfox port on FreeBSD isn’t ideal. The issue is tied to Python and the latest Waterfox version, and I’m working on a fix. However, it’s proving to be more complex than expected and requires additional time or changes.

Sorting Makefile entries: I’ve used both portlint and portclippy to sort the Makefile entries, as recommended. However, I’ve received conflicting advice from others on which tool to use. It would be helpful if the community could agree on a standard approach.

Standardization: I’d really appreciate clearer, unified rules and tools that the community agrees on. The current inconsistency makes the process more challenging and time-consuming.
Comment 3 Martin Filla 2024-12-08 04:49:13 UTC
(In reply to Daniel Engberg from comment #1)
Why is CMAKE_INSTALL_PREFIX defined?
Because CMake bad detects working folder and must be defined.
I need ${CP} because ${INSTALL_DATA} failed for .mtlx formats.
Comment 4 Martin Filla 2024-12-08 09:41:44 UTC
Created attachment 255701 [details]
0001-materialx-new-port.patch
Comment 5 Martin Filla 2024-12-22 19:18:43 UTC
Created attachment 256051 [details]
materialx.tar.xz
Comment 6 Martin Filla 2025-03-10 19:50:21 UTC
Created attachment 258542 [details]
0001-materialx-new-port.patch
Comment 7 Martin Filla 2025-11-24 18:49:15 UTC
Created attachment 265624 [details]
/0001-materialx-new-port.patch

Hi,
This is an update materialx to 1.39.4.
Enable editor, viewer, Support oiio, tests.
Comment 8 Martin Filla 2025-11-24 19:52:55 UTC
Created attachment 265626 [details]
0001-materialx-new-port.patch
Comment 9 Martin Filla 2025-11-25 22:29:07 UTC
Created attachment 265652 [details]
0001-materialx-new-port.patch
Comment 10 commit-hook freebsd_committer freebsd_triage 2025-12-02 20:46:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=043bbb10f2f403277bf468b484e509fc0a53bb5c

commit 043bbb10f2f403277bf468b484e509fc0a53bb5c
Author:     Martin Filla <freebsd@sysctl.cz>
AuthorDate: 2025-12-02 20:43:22 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2025-12-02 20:44:38 +0000

    graphics/materialx: Add new port

    MaterialX is an open standard for representing rich material and
    look-development content in computer graphics, enabling its
    platform-independent description and exchange across applications and
    renderers.

    PR:             283175

 graphics/Makefile                                  |   1 +
 graphics/materialx/Makefile (new)                  |  53 ++
 graphics/materialx/distinfo (new)                  |  17 +
 .../files/patch-python_CMakeLists.txt (new)        |  11 +
 .../patch-source_MaterialXFormat_File.cpp (new)    |  49 ++
 ...urce_MaterialXView_NanoGUI_CMakeLists.txt (new) |  14 +
 graphics/materialx/pkg-descr (new)                 |   2 +
 graphics/materialx/pkg-plist (new)                 | 786 +++++++++++++++++++++
 8 files changed, 933 insertions(+)
Comment 11 Juraj Lutter freebsd_committer freebsd_triage 2025-12-02 20:47:18 UTC
Committed, thanks.