Created attachment 255791 [details] patch for sys I ran an old semantic patch with coccinelle and came up with some places that should be using NULL instead of 0 to improve readability. This was tested by building Universe (only ARM v7 appears broken due to an unrelated issue, also seen in Jenkins).
(I am not a committer anymore so assign to someone that might be interested).
At a glance, a bunch of these are in contrib or drivers we don't maintain and shouldn't be done locally. For stuff we own (including sys/contrib/libnv) we this seems good.
Would you kindly attach a git format patch that can be applied directly (so that it will preserve author metadata). Also if you don't mind it would be useful to attach the coccinelle file. I think it would be good to have as an example.
The semantic patch is here: https://people.freebsd.org/~pfg/patches/cocci/bad_zero.cocci I keep that directory for reference.
Created attachment 255848 [details] update diff (git)
^Triage: unfortunately, this patch no longer applies. This is a common problem with tree-wide patches; the src tree simply changes too fast for any reasonable kind of sweep to be useful. I'm going to take it on myself to close this as OBE, not because I'm judging whether it's a good or bad idea, but because of simple practicality.