Bug 283534 - Mk/bsd.commands.mk: Use absolute path to define GMAKE
Summary: Mk/bsd.commands.mk: Use absolute path to define GMAKE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-23 23:08 UTC by Tijl Coosemans
Modified: 2024-12-29 12:59 UTC (History)
1 user (show)

See Also:
tijl: exp-run?

Attachments
patch (7.38 KB, patch)
2024-12-23 23:08 UTC, Tijl Coosemans 		no flags Details | Diff
patch2 (15.86 KB, patch)
2024-12-28 19:41 UTC, Tijl Coosemans 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2024-12-23 23:08:56 UTC 
Created attachment 256085 [details]
patch

Mk/bsd.commands.mk: Use absolute path to define GMAKE
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2024-12-28 19:41:05 UTC 
Created attachment 256232 [details]
patch2

- devel/rcs57: Regenerate configure with newer autoconf so it can deal with MAKE set to an absolute path.  While here fix issues with (un)escaping double quotes.  The warnings about this were in WRKSRC/src/conf.err.
- lang/gnu-cobol: Patch configure.ac and regenerate configure so it can deal with MAKE set to an absolute path.  Remove post-patch patching of configure.  It appears to have been fixed upstream.
- math/unuran: Remove post-patch, fixed upstream.
- net-mgmt/kismet: Fix post-patch.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2024-12-28 19:44:37 UTC 
(In reply to Tijl Coosemans from comment #2)
If you tested those 4 ports, no need for another exp-run
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-12-29 11:40:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=624b8729fc49aa22cca173aa1a6b69b65fa96f5a

commit 624b8729fc49aa22cca173aa1a6b69b65fa96f5a
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2024-03-06 14:48:41 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2024-12-29 11:34:56 +0000

    Mk/bsd.commands.mk: Use absolute path to define GMAKE

    Same as BSDMAKE variable.  It is needed by some ports.

    Some ports needed fixes:
    - devel/rcs57: Regenerate configure with newer autoconf so it can deal
      with MAKE set to an absolute path.  While here fix issues with
      (un)escaping double quotes.  The warnings about this were in
      WRKSRC/src/conf.err.
    - lang/gnu-cobol: Patch configure.ac so the MAKE environment variable
      can contain an absolute path, and define MAKE before it is used in
      AM_INIT_AUTOMAKE.  Remove post-patch patching of configure.  It appears
      to have been fixed upstream.
    - math/unuran: Remove post-patch, fixed upstream.
    - net-mgmt/kismet: Fix post-patch.

    PR:             283534
    Exp-run by:     antoine

 Mk/Uses/gmake.mk                              |  4 +--
 Mk/bsd.commands.mk                            |  2 +-
 audio/linux-c7-alsa-plugins-oss/Makefile      | 16 ++++------
 biology/abyss/Makefile                        |  2 +-
 devel/coccinelle/Makefile                     |  2 +-
 devel/rcs57/Makefile                          |  5 +--
 devel/rcs57/files/patch-configure.in (new)    | 12 ++++++++
 devel/rcs57/files/patch-src-conf.sh           | 24 +++++++++++++--
 devel/rcs57/files/patch-src_Makefile.in (new) | 44 +++++++++++++++++++++++++++
 lang/gnu-cobol/Makefile                       |  8 ++---
 lang/gnu-cobol/files/patch-configure.ac (new) | 34 +++++++++++++++++++++
 math/atlas/Makefile                           |  3 +-
 math/unuran/Makefile                          |  5 ---
 net-mgmt/kismet/Makefile                      |  3 +-
 security/klee/Makefile                        |  2 +-
 shells/bash-completion/Makefile               |  7 +----
 sysutils/edk2/Makefile                        |  2 +-
 textproc/ibus-typing-booster/Makefile         |  2 +-
 18 files changed, 133 insertions(+), 44 deletions(-)