Bug 284764 - [NEW PORT] lang/go124
Summary: [NEW PORT] lang/go124
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Golang Team (Nobody)
URL: https://go.dev/doc/go1.24
Keywords:
Depends on:
Blocks: 284267
  Show dependency treegraph
 
Reported: 2025-02-12 18:36 UTC by Denis Shaposhnikov
Modified: 2025-03-07 01:13 UTC (History)
9 users (show)

See Also:


Attachments
go124.patch (5.81 KB, patch)
2025-02-12 18:36 UTC, Denis Shaposhnikov
no flags Details | Diff
go124.patch (6.15 KB, patch)
2025-02-24 15:36 UTC, Denis Shaposhnikov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Shaposhnikov 2025-02-12 18:36:54 UTC
Created attachment 257445 [details]
go124.patch

https://go.dev/doc/go1.24
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2025-02-13 11:25:29 UTC
^Triage: assign to the correct team.
Comment 2 Jordan Ostreff 2025-02-22 18:55:51 UTC
/root/go124.patch:109: space before tab in indent.
                        asmArgs = append(asmArgs, "-D", "GOPPC64_power8")
/root/go124.patch:110: space before tab in indent.
                }
/root/go124.patch:111: space before tab in indent.
        }
/root/go124.patch:126: space before tab in indent.
        goasmh := pathf("%s/go_asm.h", workdir)
/root/go124.patch:127: trailing whitespace.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2025-02-23 02:06:03 UTC
(In reply to Jordan Ostreff from comment #2)

Please disregard these warnings.  They are not indicative of a problem.
Comment 4 Jordan Ostreff 2025-02-23 12:26:38 UTC
(In reply to Robert Clausecker from comment #3)
yep, i know this, because i already have go124 on my system. 

Only problem to made it default in make.conf is that caddy doesn't build with it. I've tested that Netdata builds. Doesn't tried with other go applications like owncloud infinitescale ocis.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2025-02-23 18:46:42 UTC
(In reply to Jordan Ostreff from comment #4)

It is possible that caddy just doesn't build with Go 1.24 in general.  Do you have an error message or ideally a full build log?
Comment 6 Jordan Ostreff 2025-02-24 07:30:53 UTC
(In reply to Robert Clausecker from comment #5)
Actually the port build stops on "Vendoring dependencies" phase.
Comment 7 Mikael Urankar freebsd_committer freebsd_triage 2025-02-24 08:36:40 UTC
Can you also update lang/Makefile please
Comment 8 Denis Shaposhnikov 2025-02-24 15:36:45 UTC
Created attachment 257844 [details]
go124.patch

Added go124 into lang/Makefile
Comment 9 Yonas Yanfa 2025-03-02 21:54:58 UTC
The zns DNS utility depends on Go 1.24 (https://github.com/znscli/zns/pull/41)
Comment 10 Adam Weinberger freebsd_committer freebsd_triage 2025-03-05 15:34:52 UTC
caddy breaks on every go minor release. I can't fix it until go124 hits the tree, however, so please don't block this PR on caddy.

The important thing is getting 1.24 into the ports tree. It's not a default version, so ports needing work to support 1.24 shouldn't really be blockers.
Comment 11 Adam Weinberger freebsd_committer freebsd_triage 2025-03-05 15:37:46 UTC
+GO_VALID_VERSIONS=	1.20 1.21 1.22 1.23 1.24 1.24-devel

Shouldn't that be 1.25-devel?
Comment 12 Mikael Urankar freebsd_committer freebsd_triage 2025-03-05 15:41:48 UTC
(In reply to Adam Weinberger from comment #11)
I was wondering the same.

Who is in the FreeBSD go team?
Comment 13 Adam Weinberger freebsd_committer freebsd_triage 2025-03-05 15:49:51 UTC
(In reply to Mikael Urankar from comment #12)

Our go ports are largely neglected. As far as I'm concerned, anybody who cares about go on FreeBSD and wants to help is on the team.
Comment 14 Mikael Urankar freebsd_committer freebsd_triage 2025-03-05 17:01:24 UTC
(In reply to Adam Weinberger from comment #11)
Looking at https://cgit.freebsd.org/ports/commit/?id=a4183d5b557f7b332410266433887f0eae90cb2f

we should put 1.25-devel
Comment 15 Jordan Ostreff 2025-03-05 17:20:06 UTC
go 1.24.1 released
Comment 16 commit-hook freebsd_committer freebsd_triage 2025-03-06 17:00:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c70b0d4db4d2f8ad4f6cdf5d5775ede4c3166220

commit c70b0d4db4d2f8ad4f6cdf5d5775ede4c3166220
Author:     Denis Shaposhnikov <dsh@bamus.cz>
AuthorDate: 2025-03-06 16:57:55 +0000
Commit:     Adam Weinberger <adamw@FreeBSD.org>
CommitDate: 2025-03-06 16:59:19 +0000

    lang/go124: Add port

    PR:             284764

 Mk/Uses/go.mk                                      |  2 +-
 Mk/bsd.default-versions.mk                         |  2 +-
 lang/Makefile                                      |  1 +
 lang/go124/Makefile (new)                          | 29 ++++++++++++++++++++++
 lang/go124/distinfo (new)                          | 13 ++++++++++
 lang/go124/files/patch-src_cmd_dist_build.go (new) | 23 +++++++++++++++++
 ...tch-src_cmd_go_internal_modload_vendor.go (new) | 11 ++++++++
 7 files changed, 79 insertions(+), 2 deletions(-)
Comment 17 Adam Weinberger freebsd_committer freebsd_triage 2025-03-06 17:07:32 UTC
Committed (at 1.24.1).

Thanks for all your work on this!
Comment 18 Jordan Ostreff 2025-03-06 17:25:16 UTC
(In reply to Adam Weinberger from comment #17)
Congrats! And thanks for your contribution!

I have following go1.24 related changes for other ports: 
sysutils/podman
sysutils/skopeo
www/mattermost-server
sysutils/buildah
net-mgmt/netdata

All these are compiled with go-1.24.1 and are working fine. I have all those as git diff output - to be possible easy to -R them.
Comment 19 Adam Weinberger freebsd_committer freebsd_triage 2025-03-07 01:13:06 UTC
(In reply to Jordan Ostreff from comment #18)
Jordan, please Cc: me on that PR once you're ready.

Go support on FreeBSD has fallen on tough times lately, as the main people involved are now spread thin.

I'd love to see FreeBSD get our Go ports back up to date, and then fix and improve the framework. If the people on this PR are up for it, I'm in.